Create ns with helm (#157)

Added support `--create-namespace` in helm module.

molecule/default/roles/helm/tasks/main.yml

@@ -4,4 +4,4 @@
   loop_control:
     loop_var: helm_version
   with_items:
-    - "v3.1.2"
+    - "v3.2.4"

molecule/default/roles/helm/tasks/tests_chart.yml

@@ -1,11 +1,4 @@
 ---
-- name: Create helm namespace
-  k8s:
-    api_version: v1
-    kind: Namespace
-    name: "{{ helm_namespace }}"
-    wait: true
-
 - name: Check helm_info empty
   helm_info:
     binary_path: "{{ helm_binary }}"
@@ -18,6 +11,22 @@
     that:
       - empty_info.status is undefined
 
+- name: "Install fail {{ chart_test }} from {{ source }}"
+  helm:
+    binary_path: "{{ helm_binary }}"
+    name: test
+    chart_ref: "{{ chart_source }}"
+    chart_version: "{{ chart_source_version | default(omit) }}"
+    namespace: "{{ helm_namespace }}"
+  ignore_errors: yes
+  register: install_fail
+
+- name: "Assert that Install fail {{ chart_test }} from {{ source }}"
+  assert:
+    that:
+      - install_fail is failed
+      - "'Error: create: failed to create: namespaces \"' + helm_namespace + '\" not found' in install_fail.stderr"
+
 - name: "Install {{ chart_test }} from {{ source }}"
   helm:
     binary_path: "{{ helm_binary }}"
@@ -25,6 +34,7 @@
     chart_ref: "{{ chart_source }}"
     chart_version: "{{ chart_source_version | default(omit) }}"
     namespace: "{{ helm_namespace }}"
+    create_namespace: true
   register: install
 
 - name: "Assert that {{ chart_test }} chart is installed from {{ source }}"

plugins/modules/helm.py

@@ -126,15 +126,21 @@ options:
       - If set, the installation process deletes the installation on failure.
     type: bool
     default: False
+  create_namespace:
+    description:
+      - Create the release namespace if not present.
+    type: bool
+    default: False
+    version_added: "0.11.1"
 '''
 
 EXAMPLES = r'''
-- name: Create helm namespace as HELM 3 doesn't create it automatically
+- name: Deploy latest version of Prometheus chart inside monitoring namespace (and create it)
-  community.kubernetes.k8s:
+  community.kubernetes.helm:
-    api_version: v1
+    name: test
-    kind: Namespace
+    chart_ref: stable/prometheus
-    name: "monitoring"
+    release_namespace: monitoring
-    wait: true
+    create_namespace: true
 
 # From repository
 - name: Add stable chart repo
@@ -329,7 +335,7 @@ def fetch_chart_info(command, chart_ref):
     return yaml.safe_load(out)
 
 
-def deploy(command, release_name, release_values, chart_name, wait, wait_timeout, disable_hook, force, atomic=False):
+def deploy(command, release_name, release_values, chart_name, wait, wait_timeout, disable_hook, force, atomic=False, create_namespace=False):
     """
     Install/upgrade/rollback release chart
     """
@@ -352,6 +358,9 @@ def deploy(command, release_name, release_values, chart_name, wait, wait_timeout
     if disable_hook:
         deploy_command += " --no-hooks"
 
+    if create_namespace:
+        deploy_command += " --create-namespace"
+
     if release_values != {}:
         fd, path = tempfile.mkstemp(suffix='.yml')
         with open(path, 'w') as yaml_file:
@@ -404,6 +413,7 @@ def main():
             wait=dict(type='bool', default=False),
             wait_timeout=dict(type='str'),
             atomic=dict(type='bool', default=False),
+            create_namespace=dict(type='bool', default=False),
         ),
         required_if=[
             ('release_state', 'present', ['release_name', 'chart_ref']),
@@ -436,6 +446,7 @@ def main():
     wait = module.params.get('wait')
     wait_timeout = module.params.get('wait_timeout')
     atomic = module.params.get('atomic')
+    create_namespace = module.params.get('create_namespace')
 
     if bin_path is not None:
         helm_cmd_common = bin_path
@@ -474,13 +485,13 @@ def main():
 
         if release_status is None:  # Not installed
             helm_cmd = deploy(helm_cmd, release_name, release_values, chart_ref, wait, wait_timeout,
-                              disable_hook, False, atomic=atomic)
+                              disable_hook, False, atomic=atomic, create_namespace=create_namespace)
             changed = True
 
         elif force or release_values != release_status['values'] \
                 or (chart_info['name'] + '-' + chart_info['version']) != release_status["chart"]:
             helm_cmd = deploy(helm_cmd, release_name, release_values, chart_ref, wait, wait_timeout,
-                              disable_hook, force, atomic=atomic)
+                              disable_hook, force, atomic=atomic, create_namespace=create_namespace)
             changed = True
 
     if module.check_mode: