From 3d313cf8379ddee0e17e5a6879a1c9a56e4891c5 Mon Sep 17 00:00:00 2001
From: Bikouo Aubin <79859644+abikouo@users.noreply.github.com>
Date: Tue, 7 Feb 2023 15:55:14 +0100
Subject: [PATCH] helm fix with release_values option set (#573)

helm - delete temporary file created when using option release_values

SUMMARY

closes #530

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

helm
---
 ...mporary-file-created-when-using-option-release_values.yaml | 3 +++
 plugins/modules/helm.py                                       | 4 ++++
 2 files changed, 7 insertions(+)
 create mode 100644 changelogs/fragments/helm-delete-temporary-file-created-when-using-option-release_values.yaml

diff --git a/changelogs/fragments/helm-delete-temporary-file-created-when-using-option-release_values.yaml b/changelogs/fragments/helm-delete-temporary-file-created-when-using-option-release_values.yaml
new file mode 100644
index 00000000..9ad5ab88
--- /dev/null
+++ b/changelogs/fragments/helm-delete-temporary-file-created-when-using-option-release_values.yaml
@@ -0,0 +1,3 @@
+---
+bugfixes:
+  - helm - delete temporary file created when deploying chart with option release_values set (https://github.com/ansible-collections/kubernetes.core/issues/530).
diff --git a/plugins/modules/helm.py b/plugins/modules/helm.py
index 9b2ed386..3d35e07e 100644
--- a/plugins/modules/helm.py
+++ b/plugins/modules/helm.py
@@ -455,6 +455,7 @@ def fetch_chart_info(module, command, chart_ref):
 
 
 def deploy(
+    module,
     command,
     release_name,
     release_values,
@@ -520,6 +521,7 @@ def deploy(
         with open(path, "w") as yaml_file:
             yaml.dump(release_values, yaml_file, default_flow_style=False)
         deploy_command += " -f=" + path
+        module.add_cleanup_file(path)
 
     if post_renderer:
         deploy_command = " --post-renderer=" + post_renderer
@@ -805,6 +807,7 @@ def main():
                 set_value_args = module.get_helm_set_values_args(set_values)
 
             helm_cmd = deploy(
+                module,
                 helm_cmd,
                 release_name,
                 release_values,
@@ -863,6 +866,7 @@ def main():
                     set_value_args = module.get_helm_set_values_args(set_values)
 
                 helm_cmd = deploy(
+                    module,
                     helm_cmd,
                     release_name,
                     release_values,