From 1705ced1b5e7b2374877d2a5f9d7c400b59ca2b0 Mon Sep 17 00:00:00 2001 From: James Mighion Date: Tue, 22 Jul 2025 09:49:34 -0700 Subject: [PATCH] Revert "Remove kubeconfig value from module invocation log (#826)" (#899) This reverts commit 6efabd3. SUMMARY Fixes #870 A better solution is necessary to address #782. The current code makes getting manifests practically unusable. We need to revert this commit until a better solution is found. ISSUE TYPE Bugfix Pull Request COMPONENT NAME kubeconfig Reviewed-by: Bianca Henderson --- changelogs/fragments/20250411-kubeconfig-no_log-revert.yaml | 3 +++ plugins/module_utils/args_common.py | 2 +- plugins/module_utils/helm_args_common.py | 1 - 3 files changed, 4 insertions(+), 2 deletions(-) create mode 100644 changelogs/fragments/20250411-kubeconfig-no_log-revert.yaml diff --git a/changelogs/fragments/20250411-kubeconfig-no_log-revert.yaml b/changelogs/fragments/20250411-kubeconfig-no_log-revert.yaml new file mode 100644 index 00000000..0dd34e21 --- /dev/null +++ b/changelogs/fragments/20250411-kubeconfig-no_log-revert.yaml @@ -0,0 +1,3 @@ +--- +bugfixes: + - kubeconfig option should return the full manifest output (https://github.com/ansible-collections/kubernetes.core/issues/870). diff --git a/plugins/module_utils/args_common.py b/plugins/module_utils/args_common.py index c3114f3c..27f4eacc 100644 --- a/plugins/module_utils/args_common.py +++ b/plugins/module_utils/args_common.py @@ -18,7 +18,7 @@ AUTH_PROXY_HEADERS_SPEC = dict( ) AUTH_ARG_SPEC = { - "kubeconfig": {"type": "raw", "no_log": True}, + "kubeconfig": {"type": "raw"}, "context": {}, "host": {}, "api_key": {"no_log": True}, diff --git a/plugins/module_utils/helm_args_common.py b/plugins/module_utils/helm_args_common.py index 277be01d..ebf8e9f5 100644 --- a/plugins/module_utils/helm_args_common.py +++ b/plugins/module_utils/helm_args_common.py @@ -16,7 +16,6 @@ HELM_AUTH_ARG_SPEC = dict( type="raw", aliases=["kubeconfig_path"], fallback=(env_fallback, ["K8S_AUTH_KUBECONFIG"]), - no_log=True, ), host=dict(type="str", fallback=(env_fallback, ["K8S_AUTH_HOST"])), ca_cert=dict(