Fix sanity failures (#220)

* Fix sanity failures

* Add github workflows

plugins/inventory/openshift.py

@@ -133,9 +133,10 @@ class InventoryModule(K8sInventoryModule):
     transport = 'oc'
 
     def check_kubernetes_collection(self):
-
         if not HAS_KUBERNETES_COLLECTION:
-            K8sInventoryException("The kubernetes.core collection must be installed")
+            raise K8sInventoryException(
+                "The kubernetes.core collection must be installed"
+            )
 
     def fetch_objects(self, connections):
         self.check_kubernetes_collection()

plugins/module_utils/openshift_adm_prune_auth.py

@@ -66,7 +66,7 @@ class OpenShiftAdmPruneAuth(AnsibleOpenshiftModule):
     def update_resource_binding(self, ref_kind, ref_names, namespaced=False):
 
         kind = 'ClusterRoleBinding'
-        api_version = "rbac.authorization.k8s.io/v1",
+        api_version = "rbac.authorization.k8s.io/v1"
         if namespaced:
             kind = "RoleBinding"
         resource = self.find_resource(kind=kind, api_version=api_version, fail=True)

plugins/module_utils/openshift_adm_prune_deployments.py

@@ -4,7 +4,6 @@ from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
 
 from datetime import datetime, timezone
-import traceback
 
 from ansible.module_utils._text import to_native
 

plugins/module_utils/openshift_adm_prune_images.py

@@ -4,7 +4,6 @@ from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
 
 from datetime import datetime, timezone, timedelta
-import traceback
 import copy
 
 from ansible.module_utils._text import to_native

plugins/module_utils/openshift_builds.py

@@ -4,7 +4,6 @@ from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
 
 from datetime import datetime, timezone, timedelta
-import traceback
 import time
 
 from ansible.module_utils._text import to_native

plugins/module_utils/openshift_groups.py

@@ -7,7 +7,6 @@ from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
 
 
-import traceback
 from datetime import datetime
 
 from ansible.module_utils.parsing.convert_bool import boolean

plugins/module_utils/openshift_import_image.py

@@ -3,10 +3,8 @@
 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
 
-import traceback
 import copy
 
-from ansible.module_utils._text import to_native
 from ansible.module_utils.parsing.convert_bool import boolean
 from ansible.module_utils.six import string_types
 
@@ -315,7 +313,7 @@ class OpenShiftImportImage(AnsibleOpenshiftModule):
         if not result["api_found"]:
             msg = 'Failed to find API for resource with apiVersion "{0}" and kind "{1}"'.format(
                 api_version, kind
-            ),
+            )
             self.fail_json(msg=msg)
         imagestream = None
         if len(result["resources"]) > 0:

plugins/module_utils/openshift_process.py

@@ -4,7 +4,6 @@ from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
 
 import os
-import traceback
 
 from ansible.module_utils._text import to_native
 

plugins/modules/openshift_adm_groups_sync.py

@@ -192,7 +192,6 @@ builds:
 # ENDREMOVE (downstream)
 
 import copy
-import traceback
 
 from ansible_collections.kubernetes.core.plugins.module_utils.args_common import AUTH_ARG_SPEC