mirror of
https://github.com/ansible-collections/community.general.git
synced 2026-04-15 05:11:23 +00:00
9bbe71154c
The last fix allowing multiple definitions of the same option key (for permitopen support) introduced a set() which removed the guaranteed ordering of the options. This change restores ordering. The change is larger than simply removing the set because we do need to handle the non-dict semantics around keys not being unique in the data structure. The new code make use of __setitem__() and items() to do its work. Trying to use getitem() or keys() should be looked upon with suspicion as neither of those follow dictionary semantics and it is quite possible the coder doesn't realize this. The next time we need to touch or enhance the keydict code it should probably be rewritten to not pretend to extend the dictionary interface.