mirror of
https://github.com/ansible-collections/community.general.git
synced 2026-04-15 05:11:23 +00:00
d01187d03b
Ensure standard locale in run_command (group5-batch1) (#11768)
* ensure standard locale in run_command (group5-batch1)
Adds ``LANGUAGE=C`` and ``LC_ALL=C`` to ``run_command()`` calls in modules
that parse command output, to prevent locale-dependent parsing failures on
non-C-locale systems.
Modules updated: apache2_module, composer, facter_facts, known_hosts module
utils, lvg_rename, macports, modprobe, monit, open_iscsi, pacman_key,
rhsm_release, rpm_ostree_pkg, sysupgrade.
* add changelog fragment for group5-batch1
* Remove lvg_rename from locale fix — superseded by PR #11746
PR #11746 (feat: use CmdRunner for LVM commands) takes priority and
will handle lvg_rename.py via CmdRunner refactor. Removing our
run_command_environ_update change to avoid conflict.
---------
(cherry picked from commit b40608a39d)
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
86 lines
2.2 KiB
Python
86 lines
2.2 KiB
Python
#!/usr/bin/python
|
|
|
|
# Copyright (c) 2023, Alexei Znamensky
|
|
# Copyright (c) 2012, Michael DeHaan <michael.dehaan@gmail.com>
|
|
# GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
|
|
# SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
from __future__ import annotations
|
|
|
|
DOCUMENTATION = r"""
|
|
module: facter_facts
|
|
short_description: Runs the discovery program C(facter) on the remote system and return Ansible facts
|
|
version_added: 8.0.0
|
|
description:
|
|
- Runs the C(facter) discovery program (U(https://github.com/puppetlabs/facter)) on the remote system, returning Ansible
|
|
facts from the JSON data that can be useful for inventory purposes.
|
|
extends_documentation_fragment:
|
|
- community.general.attributes
|
|
- community.general.attributes.facts
|
|
- community.general.attributes.facts_module
|
|
options:
|
|
arguments:
|
|
description:
|
|
- Specifies arguments for facter.
|
|
type: list
|
|
elements: str
|
|
requirements:
|
|
- facter
|
|
- ruby-json
|
|
author:
|
|
- Ansible Core Team
|
|
- Michael DeHaan
|
|
"""
|
|
|
|
EXAMPLES = r"""
|
|
- name: Execute facter no arguments
|
|
community.general.facter_facts:
|
|
|
|
- name: Execute facter with arguments
|
|
community.general.facter_facts:
|
|
arguments:
|
|
- -p
|
|
- system_uptime
|
|
- timezone
|
|
- is_virtual
|
|
"""
|
|
|
|
RETURN = r"""
|
|
ansible_facts:
|
|
description: Dictionary with one key C(facter).
|
|
returned: always
|
|
type: dict
|
|
contains:
|
|
facter:
|
|
description: Dictionary containing facts discovered in the remote system.
|
|
returned: always
|
|
type: dict
|
|
"""
|
|
|
|
import json
|
|
|
|
from ansible.module_utils.basic import AnsibleModule
|
|
|
|
|
|
def main():
|
|
module = AnsibleModule(
|
|
argument_spec=dict(
|
|
arguments=dict(type="list", elements="str"),
|
|
),
|
|
supports_check_mode=True,
|
|
)
|
|
module.run_command_environ_update = {"LANGUAGE": "C", "LC_ALL": "C"}
|
|
|
|
facter_path = module.get_bin_path("facter", opt_dirs=["/opt/puppetlabs/bin"])
|
|
|
|
cmd = [facter_path, "--json"]
|
|
if module.params["arguments"]:
|
|
cmd += module.params["arguments"]
|
|
|
|
rc, out, err = module.run_command(cmd, check_rc=True)
|
|
module.exit_json(ansible_facts=dict(facter=json.loads(out)))
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main()
|