Files
community.general/plugins/modules/homebrew_tap.py
patchback[bot] 119623952d [PR #11848/c4ed3467 backport][stable-12] homebrew_tap: fix None in command, redundant brew tap calls, format strings, and drop no-op locale vars (#11865)
homebrew_tap: fix None in command, redundant brew tap calls, format strings, and drop no-op locale vars (#11848)

* homebrew_tap: fix None in command list, redundant brew tap calls, and bad format strings

- Fix None being injected into the run_command list when url is not
  provided to add_tap (filter with [opt for opt in [...] if opt])
- Reduce redundant `brew tap` calls: add_taps and remove_taps now
  fetch the tap list once upfront and pass it to the per-tap functions;
  already_tapped accepts an optional pre-fetched list to avoid re-running
  brew for every tap in a batch
- Fix mixed f-string/%-formatting in error messages in add_taps and
  remove_taps, replaced with plain f-strings



* homebrew_tap: simplify command construction in add_tap

Replace the opaque list comprehension filter with an explicit conditional
append — only url is ever optional, so testing the known-present items
was misleading.



* homebrew_tap: remove unnecessary locale env vars

Homebrew has no i18n/l10n support — all output is hardcoded English.
LANGUAGE=C and LC_ALL=C have no effect on brew output.



* homebrew_tap: add changelog fragment for #11848



* remove hombrew_tap from PR #11783 changelog - change reverted here

---------


(cherry picked from commit c4ed3467b6)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-17 18:32:10 +02:00

264 lines
7.4 KiB
Python

#!/usr/bin/python
# Copyright (c) 2013, Daniel Jaouen <dcj24@cornell.edu>
# Copyright (c) 2016, Indrajit Raychaudhuri <irc+code@indrajit.com>
#
# Based on homebrew (Andrew Dunham <andrew@du.nham.ca>)
#
# GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
# SPDX-License-Identifier: GPL-3.0-or-later
from __future__ import annotations
DOCUMENTATION = r"""
module: homebrew_tap
author:
- "Indrajit Raychaudhuri (@indrajitr)"
- "Daniel Jaouen (@danieljaouen)"
short_description: Tap a Homebrew repository
description:
- Tap external Homebrew repositories.
extends_documentation_fragment:
- community.general.attributes
attributes:
check_mode:
support: full
diff_mode:
support: none
options:
name:
description:
- The GitHub user/organization repository to tap.
required: true
aliases: ['tap']
type: list
elements: str
url:
description:
- The optional git URL of the repository to tap. The URL is not assumed to be on GitHub, and the protocol does not have
to be HTTP. Any location and protocol that git can handle is fine.
- O(name) option may not be a list of multiple taps (but a single tap instead) when this option is provided.
type: str
state:
description:
- State of the repository.
choices: ['present', 'absent']
default: 'present'
type: str
path:
description:
- A V(:) separated list of paths to search for C(brew) executable.
default: '/usr/local/bin:/opt/homebrew/bin:/home/linuxbrew/.linuxbrew/bin'
type: path
version_added: '2.1.0'
requirements: [homebrew]
"""
EXAMPLES = r"""
- name: Tap a Homebrew repository, state present
community.general.homebrew_tap:
name: homebrew/dupes
- name: Tap a Homebrew repository, state absent
community.general.homebrew_tap:
name: homebrew/dupes
state: absent
- name: Tap a Homebrew repository, state present
community.general.homebrew_tap:
name: homebrew/dupes,homebrew/science
state: present
- name: Tap a Homebrew repository using url, state present
community.general.homebrew_tap:
name: telemachus/brew
url: 'https://bitbucket.org/telemachus/brew'
"""
import re
from ansible.module_utils.basic import AnsibleModule
def a_valid_tap(tap):
"""Returns True if the tap is valid."""
regex = re.compile(r"^([\w-]+)/(homebrew-)?([\w-]+)$")
return regex.match(tap)
def already_tapped(module, brew_path, tap, taps=None):
"""Returns True if already tapped."""
if taps is None:
rc, out, err = module.run_command([brew_path, "tap"])
taps = [tap_.strip().lower() for tap_ in out.split("\n") if tap_]
tap_name = re.sub("homebrew-", "", tap.lower())
return tap_name in taps
def add_tap(module, brew_path, tap, url=None, taps=None):
"""Adds a single tap."""
failed, changed, msg = False, False, ""
if not a_valid_tap(tap):
failed = True
msg = f"not a valid tap: {tap}"
elif not already_tapped(module, brew_path, tap, taps):
if module.check_mode:
module.exit_json(changed=True)
cmd = [brew_path, "tap", tap]
if url:
cmd.append(url)
rc, out, err = module.run_command(cmd)
if rc == 0:
changed = True
msg = f"successfully tapped: {tap}"
else:
failed = True
msg = f"failed to tap: {tap} due to {err}"
else:
msg = f"already tapped: {tap}"
return (failed, changed, msg)
def add_taps(module, brew_path, taps):
"""Adds one or more taps."""
failed, changed, unchanged, added, msg = False, False, 0, 0, ""
rc, out, err = module.run_command([brew_path, "tap"])
tapped = [t.strip().lower() for t in out.split("\n") if t]
for tap in taps:
(failed, changed, msg) = add_tap(module, brew_path, tap, taps=tapped)
if failed:
break
if changed:
added += 1
else:
unchanged += 1
if failed:
msg = f"added: {added}, unchanged: {unchanged}, error: {msg}"
elif added:
changed = True
msg = f"added: {added}, unchanged: {unchanged}"
else:
msg = f"added: {added}, unchanged: {unchanged}"
return (failed, changed, msg)
def remove_tap(module, brew_path, tap, taps=None):
"""Removes a single tap."""
failed, changed, msg = False, False, ""
if not a_valid_tap(tap):
failed = True
msg = f"not a valid tap: {tap}"
elif already_tapped(module, brew_path, tap, taps):
if module.check_mode:
module.exit_json(changed=True)
rc, out, err = module.run_command([brew_path, "untap", tap])
if not already_tapped(module, brew_path, tap):
changed = True
msg = f"successfully untapped: {tap}"
else:
failed = True
msg = f"failed to untap: {tap} due to {err}"
else:
msg = f"already untapped: {tap}"
return (failed, changed, msg)
def remove_taps(module, brew_path, taps):
"""Removes one or more taps."""
failed, changed, unchanged, removed, msg = False, False, 0, 0, ""
rc, out, err = module.run_command([brew_path, "tap"])
tapped = [t.strip().lower() for t in out.split("\n") if t]
for tap in taps:
(failed, changed, msg) = remove_tap(module, brew_path, tap, taps=tapped)
if failed:
break
if changed:
removed += 1
else:
unchanged += 1
if failed:
msg = f"removed: {removed}, unchanged: {unchanged}, error: {msg}"
elif removed:
changed = True
msg = f"removed: {removed}, unchanged: {unchanged}"
else:
msg = f"removed: {removed}, unchanged: {unchanged}"
return (failed, changed, msg)
def main():
module = AnsibleModule(
argument_spec=dict(
name=dict(aliases=["tap"], type="list", required=True, elements="str"),
url=dict(),
state=dict(default="present", choices=["present", "absent"]),
path=dict(
default="/usr/local/bin:/opt/homebrew/bin:/home/linuxbrew/.linuxbrew/bin",
type="path",
),
),
supports_check_mode=True,
)
path = module.params["path"]
if path:
path = path.split(":")
brew_path = module.get_bin_path(
"brew",
required=True,
opt_dirs=path,
)
taps = module.params["name"]
url = module.params["url"]
if module.params["state"] == "present":
if url is None:
# No tap URL provided explicitly, continue with bulk addition
# of all the taps.
failed, changed, msg = add_taps(module, brew_path, taps)
else:
# When an tap URL is provided explicitly, we allow adding
# *single* tap only. Validate and proceed to add single tap.
if len(taps) > 1:
msg = "List of multiple taps may not be provided with 'url' option."
module.fail_json(msg=msg)
else:
failed, changed, msg = add_tap(module, brew_path, taps[0], url)
if failed:
module.fail_json(msg=msg)
else:
module.exit_json(changed=changed, msg=msg)
elif module.params["state"] == "absent":
failed, changed, msg = remove_taps(module, brew_path, taps)
if failed:
module.fail_json(msg=msg)
else:
module.exit_json(changed=changed, msg=msg)
if __name__ == "__main__":
main()