Commit Graph

270 Commits

Author SHA1 Message Date
Patrik Lundin
dc4914bd19 Improve debug log some more. 2016-12-08 11:34:28 -05:00
Patrik Lundin
108205ffc6 Make fail messages all use lowercase messages. 2016-12-08 11:34:28 -05:00
Patrik Lundin
3ac32cf365 Improve debug logging some more. 2016-12-08 11:34:28 -05:00
Patrik Lundin
89c5cddda1 No support for build=true with 'branch' syntax. 2016-12-08 11:34:28 -05:00
Patrik Lundin
04409cc214 Improve debug logging for build code. 2016-12-08 11:34:28 -05:00
Patrik Lundin
09b0871f17 Add a break and extra debug log for clarity. 2016-12-08 11:34:28 -05:00
Patrik Lundin
e8b1d27057 openbsd_pkg: no need to call .rstrip. 2016-12-08 11:34:28 -05:00
Patrik Lundin
24eab14695 openbsd_pkg: fix build=true corner case.
* Fix bug where we were actually checking for the availability of the
  requested package name and not 'sqlports' even if that was the goal.

* Add check that the sqlports database file exists before using it.

* Sprinkle some debug messages for an easier time following the code when
  developing.
2016-12-08 11:34:27 -05:00
Patrik Lundin
f686994af6 openbsd_pkg: support "pkgname%branch" syntax.
* Such package names requires at least OpenBSD 6.0.

* Rework get_package_state() to use 'pkg_info -Iq inst:' instead of 'pkg_info -e'
  because it understands the branch syntax. It also means we can get rid of
  some additional special handling.

  This was suggested by Marc Espie:
  http://marc.info/?l=openbsd-tech&m=146659756711614&w=2

* Drop get_current_name() because the use of 'pkg_info -Iq inst:' in
  get_package_state() means we already have that information available without
  needing to do custom parsing. This was also necessary because a name such as
  "postfix%stable" does not in itself contain the version information necessary
  for the custom parsing. pkg_info -Iq translates such a name to the actual
  package name seamlessly.

* Add support for finding more than one package for the supplied package name
  which may happen if we only supply a stem.
2016-12-08 11:34:27 -05:00
Shinichi TAMURA
73b95ab853 Added fallback for parse_error(string) on elasticsearch_plugin module. (#2517) 2016-12-08 11:34:27 -05:00
_srsh_
a9e3b6aa05 module was failing on python 2.7 after last update (#2459) 2016-12-08 11:34:26 -05:00
René Moser
20a1d49e2b doc: maven_artifact: add a note about s3 support since version 2.2 (#2417)
See #2317
2016-12-08 11:34:22 -05:00
Gonçalo Luiz
711e94346b added s3 download support to maven module (#2317)
* added s3 download support

* removed extraneous import
2016-12-08 11:34:22 -05:00
Andrew Miller
7ac4909357 Cpanm module could not use less than Python 2.6
Removed str.format() dependency to allow cpanm module to work on nodes with versions of Python less than 2.6.
2016-12-08 11:34:21 -05:00
Chris Weber
c3a1efee4f Fixed exception compatablity for py3 (and 2.4 in yum_repository.py) (#2369)
* Fixed exception compatablity for py3 (and 2.4 in yum_repository.py)

* Moved Import
2016-12-08 11:34:20 -05:00
Jiri Tyr
8d09b74908 Fixing wrong type of params option in yum_repository module (#2371)
This commit fixes incorrect type of the "params" option of the
"yum_repository" module. Without this fix the value of the "params"
option is read as a string instead of as a dictionary which makes
it impossible to define any additional YUM repository parameters.
2016-12-08 11:34:20 -05:00
Louis-Michel Couture
48a2f1e4d3 Update bundler example to match the param name (#2322) 2016-12-08 11:34:20 -05:00
Dmitry Marakasov
a6ee449d6b Improve documentation for pkgng module (#2338)
According to module checklist:

- Descriptions should always start with a Capital letter and end with a
  full stop.
- Ensure that you make use of U() for urls, C() for files and options,
  I() for params, M() for modules.
2016-12-08 11:34:19 -05:00
Brian Coca
beabafa99f minor fixes
removed unused imports
rearranged basic import
added if/main for testing/importability
2016-12-08 11:34:19 -05:00
Dmitry Marakasov
472bf733e0 Freebsd pkgng autoremove support (#2324)
* Whitespace cleanup

* Add autoremove capability to pkgng

* Add "default" and "choices" documentnation items for autoremove
2016-12-08 11:34:18 -05:00
Adrian Likins
f096cd6322 Fix pkgutil "upgrade_catalog must be one of" err (#2149)
The arg spec for update_catalog include 'type=bool'
and 'choices=["yes", "no"] which can never both be
true.

Remove the 'choices' directive, and update doc string.

Fixes #2144
2016-12-08 11:34:17 -05:00
Dag Wieers
0e3713971a Convert module to work with python 2.4 and fix a bug (#2251)
- Avoiding the use of 'with ... as ...' and 'except ... as ...' constructs.

- Make use of posixpath.join() rather than concatenating slashes ourselves
  (To avoid having consecutive slashes which broke something on our side)
2016-12-08 11:34:16 -05:00
Alex
e031f37407 zypper: (Bugfix) Change command option --verbose to --details which is supported since 2008 (#2224) 2016-12-08 11:34:15 -05:00
Rene Moser
9ba13c2d1c homebrew_cask: fix doc version_added for install_options
See #2086
2016-12-08 11:34:12 -05:00
Robin Roth
107c257293 refactor zypper module
* refactor zypper module

Cleanup:
* remove mention of old_zypper (no longer supported)
  * requirement goes up to zypper 1.0, SLES 11.0, openSUSE 11.1
  * allows to use newer features (xml output)
  * already done for zypper_repository
* use zypper instead of rpm to get old version information, based on work by @jasonmader
* don't use rpm, zypper can do everything itself
* run zypper only twice, first to determine current state, then to apply changes

New features:
* determine change by parsing zypper xmlout
* determine failure by checking return code
* allow simulataneous installation/removal of packages (using '-' and '+' prefix)
  * allows to swap out alternatives without removing packages depending
    on them
* implement checkmode, using zypper --dry-run
* implement diffmode
* implement 'name=* state=latest' and 'name=* state=latest type=patch'
* add force parameter, handed to zypper to allow downgrade or change of vendor/architecture

Fixes/Replaces:
* fixes #1627, give changed=False on installed patches
* fixes #2094, handling URLs for packages
* fixes #1461, fixes #546, allow state=latest name='*'
* fixes #299, changed=False on second install, actually this was fixed earlier, but it is explicitly tested now
* fixes #1824, add type=application
* fixes #1256, install rpm from path, this is done by passing URLs and paths directly to zypper

* fix typo in package_update_all

* minor fixes

* remove commented code block
* bump version added to 2.2
* deal with zypper return codes 103 and 106
2016-12-08 11:34:12 -05:00
Indrajit Raychaudhuri
dd59cadfd6 Fix homebrew_cask examples 2016-12-08 11:34:12 -05:00
Indrajit Raychaudhuri
b718e10a88 Add version_added doc property for install_options in homebrew_cask 2016-12-08 11:34:12 -05:00
Indrajit Raychaudhuri
028aa0828c Add additional examples for parameter install_options in homebrew_cask 2016-12-08 11:34:11 -05:00
Enric Lluelles
be64687bf5 Adding install_options to homebrew_cask 2016-12-08 11:34:11 -05:00
Gonçalo Luiz
8a1aee53bc fixed not resolving latest to snapshot for MD5 check when the file ex… 2016-12-08 11:34:11 -05:00
Michael Scherer
557d27513c Use type=path for arguments, and remove code doing the conversion (#1903) 2016-12-08 11:34:10 -05:00
Emil Bostijancic
3d24895606 Fixes maven_artifact - verify_md5 only called for SNAPSHOT
* fixed https://github.com/ansible/ansible-modules-extras/issues/2066

* fixes https://github.com/ansible/ansible-modules-extras/issues/2066
2016-12-08 11:34:08 -05:00
Robin Roth
5464b71561 Zypper repository rewrite (#1990)
* Remove support for ancient zypper versions

Even SLES11 has zypper 1.x.

* zypper_repository: don't silently ignore repo changes

So far when a repo URL changes this got silently ignored (leading to
incorrect package installations) due to this code:

    elif 'already exists. Please use another alias' in stderr:
        changed = False

Removing this reveals that we correctly detect that a repo definition
has changes (via repo_subset) but don't indicate this as change but as a
nonexistent repo. This makes us currenlty bail out silently in the above
statement.

To fix this distinguish between non existent and modified repos and
remove the repo first in case of modifications (since there is no force
option in zypper to overwrite it and 'zypper mr' uses different
arguments).

To do this we have to identify a repo by name, alias or url.

* Don't fail on empty values

This unbreaks deleting repositories

* refactor zypper_repository module

* add properties enabled and priority
* allow changing of one property and correctly report changed
* allow overwrite of multiple repositories by alias and URL
* cleanup of unused code and more structuring

* respect enabled option

* make zypper_repository conform to python2.4

* allow repo deletion only by alias

* check for non-existant url field and use alias instead

* remove empty notes and aliases

* add version_added for priority and overwrite_multiple

* add version requirement on zypper and distribution

* zypper 1.0 is enough and exists

* make suse versions note, not requirement

based on comment by @alxgu
2016-12-08 11:34:07 -05:00
Jiri Tyr
48c20dd981 Describing the _none_ value of the proxy option (#2053) 2016-12-08 11:34:06 -05:00
Michael Scherer
b4c3d32366 Mark conf_file as a path, for various user expansion 2016-12-08 11:34:06 -05:00
Christopher M. Fuhrman
310b7ce3d8 pkgin: Fix bad regexp which did not catch packages such as p5-SVN-Notify
The previous version of my regexp did not take into account packages
such as 'p5-Perl-Tidy' or 'p5-Test-Output', so use a greedy match up to
the last occurrance of '-' for matching the package.  This regex has
been extensively tested using all packages as provided by pkgsrc-2016Q1[1].

Footnotes:
[1]  http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/?only_with_tag=pkgsrc-2016Q1
2016-12-08 11:34:06 -05:00
Jasper Lievisse Adriaanse
0fb01e45fb Sprinkle some LANG/LC_* where command output is parsed (#2019) 2016-12-08 11:34:05 -05:00
Jasper Lievisse Adriaanse
8913f1a11d Tweak and extend the pkgin module
- make path to pkgin a global and stop passing it around; it's not going
  to change while ansible is running
- add support for several new options:
  * upgrade
  * full_upgrade
  * force
  * clean
- allow for update_cache to be run in the same task as upgrading/installing
  packages instead of needing a separate task for that
2016-12-08 11:34:05 -05:00
stoned
6a77e62df4 cpanm: search both its stderr and its stdout for the message 'is up t…
Note that since cpanm version 1.6926 its messages are sent to stdout
when previously they were sent to stderr.

Also there is no need to initialize out_cpanm and err_cpanm and
check for their truthiness as module.run_command() and str.find()
take care of that.
2016-12-08 11:34:04 -05:00
Joerg Fiedler
518b03d73f add chroot flag to pkgng in order to allow installation of packages into chroot environments, e.g. jails (#1218) 2016-12-08 11:34:04 -05:00
Him You Ten
87ce503767 added stdout and stderr outputs (#1900)
* added stdout and stderr outputs

Added stdout and stderr outputs of the results from composer as the current msg output strips \n so very hard to read when debugging

* using stdout for fail_json

using stdout for fail_json so we get the stdout_lines array
2016-12-08 11:34:04 -05:00
Jasper Lievisse Adriaanse
3a319b9a84 support for 'update_cache' in pkgin module 2016-12-08 11:34:04 -05:00
Michael Scherer
f47a756c46 Add proper type to cpanm arguments
from_path, locallib, executable should be path to benefits
from path expansion for ~user.
2016-12-08 11:34:03 -05:00
Michael Scherer
a21ab5b990 Use type='path' for reposdir, since that's a path 2016-12-08 11:34:01 -05:00
Michael Scherer
dc94ce72c7 Use boolean instead of "yes" + choice for most option
This enable a more standard behavior with others modules
2016-12-08 11:34:01 -05:00
Michael Scherer
2a0c9bb3a2 Use type 'path' for rootdir, for pkgng 2016-12-08 11:34:01 -05:00
Brian Coca
0ebabc50e4 change name to be a list type
remove implicit split that expects a , separated string, let list type
deal with multiple possible compatible input types.
also removed unused imports
2016-12-08 11:34:00 -05:00
Matthew Gamble
b58eaca7e8 Remove dead code from pacman module
The manual check to see if get_bin_path() returned anything is
redundant, because we pass True to the required parameter of
get_bin_path(). This automatically causes the task to fail if the pacman
binary isn't available. Therefore, the code within the if statement
being removed is never called.
2016-12-08 11:33:59 -05:00
Michael Scherer
eefd716e8c Add better type checking for elasticsearch_plugin 2016-12-08 11:33:59 -05:00
Michael Scherer
4c63a958e5 Use no_log for the password for maven_artifact module 2016-12-08 11:33:59 -05:00