Evgeni Golov
ab07c9c7e8
do not set LXC default config
...
this was accidentally re-introduced in 7120fb4b
Signed-off-by: Evgeni Golov <evgeni@golov.de >
2016-12-08 11:34:04 -05:00
Ricardo Carrillo Cruz
079a7dc490
Add os_user_facts module
...
This module gather facts about one or more OpenStack users
2016-12-08 11:34:04 -05:00
Ricardo Carrillo Cruz
aba0597e45
Add os_keystone_domain_facts module
...
This module gathers one or more OpenStack domains facts
2016-12-08 11:34:04 -05:00
Michael Scherer
971b570b67
Do not leak passwords in case of error in cloudstack modules
2016-12-08 11:34:04 -05:00
Michael Scherer
ed69d8335e
Properly label path argument with type='path' ( #1940 )
2016-12-08 11:34:03 -05:00
Rob
b93fda8573
Updated Amazon module guidelines regarding boto3
...
* Updated Amazon module guidelines regarding boto3
* Spelling correction
2016-12-08 11:34:03 -05:00
Andy Baker
c0d281e290
type should be 'list' not the default of 'string'
2016-12-08 11:34:03 -05:00
Evgeni Golov
1847f19e41
don't create world-readable archives of LXC containers
...
with the default umask tar will create a world-readable archive of the
container, which may contain sensitive data
Signed-off-by: Evgeni Golov <evgeni@golov.de >
2016-12-08 11:34:03 -05:00
Evgeni Golov
16b2d85d34
do not use a predictable filenames in the LXC plugin
...
* do not use a predictable filename for the LXC attach script
* don't use predictable filenames for LXC attach script logging
* don't set a predictable archive_path
this should prevent symlink attacks which could result in
* data corruption
* data leakage
* privilege escalation
2016-12-08 11:34:03 -05:00
Evgeni Golov
88d8820f1b
explicitly set "default: null" in the docs
2016-12-08 11:34:02 -05:00
Evgeni Golov
e1846d2e4b
do not set a default config for lxc containers
...
otherwise deploying user-containers fail as these require information
from ~/.config/lxc/default.conf that the LXC tools will load if no
--config was supplied
Signed-off-by: Evgeni Golov <evgeni@golov.de >
2016-12-08 11:34:02 -05:00
Chris Porter
2b8b04638d
fix security vulnerability in lxc module
...
octal/decimal confusion makes file world-writable before executing it
2016-12-08 11:34:02 -05:00
John Barker
d20b7ee6e6
restore version_added in dynamodb_table.py
2016-12-08 11:34:01 -05:00
Rene Moser
051b11b983
openstack: doc: add return doc, fixes build
2016-12-08 11:34:01 -05:00
David Shrewsbury
33d3616bab
Add OpenStack os_user_role module
2016-12-08 11:34:01 -05:00
David Shrewsbury
2dddfbe67c
Add shade version check to os_flavor_facts
...
The range_search() API was added to the shade library in version
1.5.0 so let's check for that and let the user know they need to
upgrade if they try to use it.
2016-12-08 11:34:00 -05:00
Brian Coca
41af347d8d
renamed sl to sl_vm and updated docs
...
namespace for softlayer modules should now be sl_
2016-12-08 11:33:59 -05:00
Matt Colton
8f444b8c4b
Added Softlayer Module
2016-12-08 11:33:59 -05:00
Julia Kreger
011267c04e
Add os_ironic_inspect module
...
Addition of an os_ironic_inspect module to leverage the OpenStack
Baremetal inspector add-on to ironic or ironic driver out-of-band
hardware introspection, if supported and configured.
2016-12-08 11:33:59 -05:00
Ricardo Carrillo Cruz
ba3515bc30
Allow passing domain name on os_project
2016-12-08 11:33:59 -05:00
Rene Moser
7a28ad63f7
dynamodb_table: doc fix
2016-12-08 11:33:59 -05:00
Matt Ferrante
99c8e82b60
dynamo db indexes
2016-12-08 11:33:59 -05:00
Casey Lucas
4cd9933388
fix edge case where boto returns empty list after subnet creation
2016-12-08 11:33:59 -05:00
Dennis Conrad
0254cbad9a
Fix for existing ENIs w/ multiple security groups
...
Do a sorted comparison of the list of security groups supplied via `module.params.get('security_groups')` and the list of security groups fetched via `get_sec_group_list(eni.groups)`. This fixes an incorrect "The specified address is already in use" error if the order of security groups in those lists differ.
2016-12-08 11:33:58 -05:00
Rob White
7b0b4262e5
Allow SNS topics to be created without subscriptions. Also added better error handling around boto calls.
2016-12-08 11:33:58 -05:00
Fernando J Pando
be083a8fbe
author added
2016-12-08 11:33:58 -05:00
Fernando J Pando
6d69956f83
Fix SNS topic attribute typo
...
Enables adding SNS topic policy. 'Policy' attribute is capitalized.
2016-12-08 11:33:58 -05:00
Joel Thompson
61672e5c61
Ensure ec2_win_password doesn't leak file handle
...
Currently the module doesn't explicitly close the file handle. This
wraps the reading of the private key in a try/finally block to ensure
the file is properly closed.
2016-12-08 11:33:58 -05:00
Rene Moser
b92b30e3b3
ec2_vpc_dhcp_options: doc fix, add version_added to new args
...
See #1640
2016-12-08 11:33:58 -05:00
Andy Nelson
5718a5caac
Updated ec2_vpc_dhcp_options
2016-12-08 11:33:57 -05:00
Darek Kaczyński
9e918b5955
Removed debug return values
2016-12-08 11:33:57 -05:00
Darek Kaczyński
7127a45d96
ecs_service will now compare whole model and update it if any difference found. Documentation #1483 . Workaround for datetime fileds #1348 .
2016-12-08 11:33:57 -05:00
Darek Kaczyński
9b27ed6c5d
ecs_service_facts documentation fixes #1483 . Workaround for datetime fileds #1348 .
2016-12-08 11:33:57 -05:00
Alex Kalinin
e97ca89953
Fix vmware_portgroup throwing an error if port group already exists
2016-12-08 11:33:57 -05:00
Toshio Kuratomi
5b84102a15
Doc fixes
2016-12-08 11:33:56 -05:00
Gabriel Burkholder
6a202054f8
Fixes route53_facts to use max_items parameter with record_sets query.
2016-12-08 11:33:56 -05:00
nonshankus
a1fdff4c97
Adding missing attributes regarding the hosted zone.
2016-12-08 11:33:56 -05:00
David Shrewsbury
cd2c7deec4
Add os_group.py OpenStack module
...
Allows an admin (or privileged user) to manage Keystone v3
groups.
2016-12-08 11:33:56 -05:00
David Shrewsbury
e25c04aeb0
Add new os_flavor_facts.py module
...
New module to retrieve facts about existing instance flavors.
By default, facts on all available flavors will be returned.
This can be narrowed by naming a flavor or specifying criteria
about flavor RAM or VCPUs.
2016-12-08 11:33:56 -05:00
David Shrewsbury
b697d986c1
Add new os_keystone_role module.
...
This new module allows for creating and deleting Keystone
roles.
2016-12-08 11:33:56 -05:00
Rene Moser
fd68e66827
cloudstack: new module cs_zone_facts
2016-12-08 11:33:55 -05:00
Ritesh Khadgaray
06d2682b08
Fix test failure for lxc_container
...
TRACE:
while parsing a block mapping
in "<string>", line 33, column 13:
description: resulting state of ...
^
expected <block end>, but found ','
in "lxc_container.RETURN", line 419, column 53:
... "/tmp/test-container-config.tar",
ERROR: RETURN is not valid YAML. Line 419 column 53
2016-12-08 11:33:54 -05:00
Brian Coca
bb355e6ccd
add container name to return and document return
...
fixes #1848
2016-12-08 11:33:54 -05:00
liquidat
87bc5fcb24
remove legacy action style from examples
...
- "action" style invoking is a legacy way to call modules
- the examples were updated to the typical style of calling complex
modules:
ovirt:
parameter1: value1
parameter2: value2
...
2016-12-08 11:33:53 -05:00
Ricardo Carrillo Cruz
9fea94b5bf
Fix instantiation of openstack_cloud object in os_project
...
The os_project module instantiates the openstack cloud object
by passing the module params kwargs.
As the params contain a key named 'domain_id', this is used
for domain in the OpenStack connection, instead of the domain value
the user specifies on the OSCC clouds.yaml or OpenStack envvars.
This fix corrects this by popping the 'domain_id' key, so it we
keep the value but it's not passed later on module.params.
2016-12-08 11:33:53 -05:00
Darek Kaczyński
17a6cea512
ecs_task module documentation fixes
2016-12-08 11:33:53 -05:00
Joseph Callen
773db55233
Resolves issue with vmware_migrate_vmk module for v2.0
...
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing. This PR resolves that issue with the vmware_migrate_vmk module.
@kamsz reported this issue in https://github.com/ansible/ansible-modules-extras/pull/1568
Playbook
```
- name: Migrate Management vmk
local_action:
module: vmware_migrate_vmk
hostname: "{{ mgmt_ip_address }}"
username: "{{ vcsa_user }}"
password: "{{ vcsa_pass }}"
esxi_hostname: "{{ hostvars[item].hostname }}"
device: vmk1
current_switch_name: temp_vswitch
current_portgroup_name: esx-mgmt
migrate_switch_name: dvSwitch
migrate_portgroup_name: Management
with_items: groups['foundation_esxi']
```
Module Testing
```
TASK [Migrate Management vmk] **************************************************
task path: /opt/autodeploy/projects/emmet/tasks/deploy/migrate_vmk.yml:3
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252 )" )
localhost PUT /tmp/tmpdlhr6t TO /root/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252/vmware_migrate_vmk
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252/vmware_migrate_vmk; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168 )" )
localhost PUT /tmp/tmpqfZqh1 TO /root/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168/vmware_migrate_vmk
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168/vmware_migrate_vmk; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882 )" )
localhost PUT /tmp/tmpf3rKZq TO /root/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882/vmware_migrate_vmk
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882/vmware_migrate_vmk; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882/" > /dev/null 2>&1
ok: [foundation-vcsa -> localhost] => (item=foundation-esxi-01) => {"changed": false, "invocation": {"module_args": {"current_portgroup_name": "esx-mgmt", "current_switch_name": "temp_vswitch", "device": "vmk1", "esxi_hostname": "cscesxtmp001", "hostname": "172.27.0.100", "migrate_portgroup_name": "Management", "migrate_switch_name": "dvSwitch", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root"}, "module_name": "vmware_migrate_vmk"}, "item": "foundation-esxi-01"}
ok: [foundation-vcsa -> localhost] => (item=foundation-esxi-02) => {"changed": false, "invocation": {"module_args": {"current_portgroup_name": "esx-mgmt", "current_switch_name": "temp_vswitch", "device": "vmk1", "esxi_hostname": "cscesxtmp002", "hostname": "172.27.0.100", "migrate_portgroup_name": "Management", "migrate_switch_name": "dvSwitch", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root"}, "module_name": "vmware_migrate_vmk"}, "item": "foundation-esxi-02"}
ok: [foundation-vcsa -> localhost] => (item=foundation-esxi-03) => {"changed": false, "invocation": {"module_args": {"current_portgroup_name": "esx-mgmt", "current_switch_name": "temp_vswitch", "device": "vmk1", "esxi_hostname": "cscesxtmp003", "hostname": "172.27.0.100", "migrate_portgroup_name": "Management", "migrate_switch_name": "dvSwitch", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root"}, "module_name": "vmware_migrate_vmk"}, "item": "foundation-esxi-03"}
```
2016-12-08 11:33:53 -05:00
Joseph Callen
eece1346ab
missing doc fragment
2016-12-08 11:33:53 -05:00
Joseph Callen
3721a4647c
Resolves issue with vmware_vm_vss_dvs_migrate module for v2.0
...
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing. This PR resolves that issue with the vmware_vm_vss_dvs_migrate module.
@kamsz reported this issue in https://github.com/ansible/ansible-modules-extras/pull/1568
Playbook
```
- name: Migrate VCSA to vDS
local_action:
module: vmware_vm_vss_dvs_migrate
hostname: "{{ mgmt_ip_address }}"
username: "{{ vcsa_user }}"
password: "{{ vcsa_pass }}"
vm_name: "{{ hostname }}"
dvportgroup_name: Management
```
Module Testing
```
ASK [Migrate VCSA to vDS] *****************************************************
task path: /opt/autodeploy/projects/emmet/site_deploy.yml:260
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859 )" )
localhost PUT /tmp/tmpkzD4pF TO /root/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859/vmware_vm_vss_dvs_migrate
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859/vmware_vm_vss_dvs_migrate; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859/" > /dev/null 2>&1
changed: [foundation-vcsa -> localhost] => {"changed": true, "invocation": {"module_args": {"dvportgroup_name": "Management", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root", "vm_name": "cscvcatmp001"}, "module_name": "vmware_vm_vss_dvs_migrate"}, "result": null}
```
2016-12-08 11:33:53 -05:00
Joseph Callen
cef9e42896
Resolves issue with vmware_host module for v2.0
...
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing. This PR resolves that issue with the vmware_host module.
@kamsz reported this issue in https://github.com/ansible/ansible-modules-extras/pull/1568
Playbook
```
- name: Add Host
local_action:
module: vmware_host
hostname: "{{ mgmt_ip_address }}"
username: "{{ vcsa_user }}"
password: "{{ vcsa_pass }}"
datacenter_name: "{{ mgmt_vdc }}"
cluster_name: "{{ mgmt_cluster }}"
esxi_hostname: "{{ hostvars[item].hostname }}"
esxi_username: "{{ esxi_username }}"
esxi_password: "{{ site_passwd }}"
state: present
with_items: groups['foundation_esxi']
```
Module Testing
```
TASK [Add Host] ****************************************************************
task path: /opt/autodeploy/projects/emmet/site_deploy.yml:214
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693866.1-87710459703937 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693866.1-87710459703937 )" )
localhost PUT /tmp/tmppmr9i9 TO /root/.ansible/tmp/ansible-tmp-1454693866.1-87710459703937/vmware_host
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454693866.1-87710459703937/vmware_host; rm -rf "/root/.ansible/tmp/ansible-tmp-1454693866.1-87710459703937/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693943.8-75870536677834 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693943.8-75870536677834 )" )
localhost PUT /tmp/tmpVB81f2 TO /root/.ansible/tmp/ansible-tmp-1454693943.8-75870536677834/vmware_host
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454693943.8-75870536677834/vmware_host; rm -rf "/root/.ansible/tmp/ansible-tmp-1454693943.8-75870536677834/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693991.56-163414752982563 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693991.56-163414752982563 )" )
localhost PUT /tmp/tmpFB7VQB TO /root/.ansible/tmp/ansible-tmp-1454693991.56-163414752982563/vmware_host
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454693991.56-163414752982563/vmware_host; rm -rf "/root/.ansible/tmp/ansible-tmp-1454693991.56-163414752982563/" > /dev/null 2>&1
changed: [foundation-vcsa -> localhost] => (item=foundation-esxi-01) => {"changed": true, "invocation": {"module_args": {"cluster_name": "Foundation", "datacenter_name": "Test-Lab", "esxi_hostname": "cscesxtmp001", "esxi_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "esxi_username": "root", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "username": "root"}, "module_name": "vmware_host"}, "item": "foundation-esxi-01", "result": "'vim.HostSystem:host-15'"}
changed: [foundation-vcsa -> localhost] => (item=foundation-esxi-02) => {"changed": true, "invocation": {"module_args": {"cluster_name": "Foundation", "datacenter_name": "Test-Lab", "esxi_hostname": "cscesxtmp002", "esxi_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "esxi_username": "root", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "username": "root"}, "module_name": "vmware_host"}, "item": "foundation-esxi-02", "result": "'vim.HostSystem:host-20'"}
changed: [foundation-vcsa -> localhost] => (item=foundation-esxi-03) => {"changed": true, "invocation": {"module_args": {"cluster_name": "Foundation", "datacenter_name": "Test-Lab", "esxi_hostname": "cscesxtmp003", "esxi_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "esxi_username": "root", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "username": "root"}, "module_name": "vmware_host"}, "item": "foundation-esxi-03", "result": "'vim.HostSystem:host-21'"}
```
2016-12-08 11:33:53 -05:00