internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-04-18 14:51:09 +00:00
Code Issues Packages Projects Releases Wiki Activity
44,713 Commits 13 Branches 227 Tags
463a7ff5cab37404038eba975af8ca93da98f708
Commit Graph

266 Commits

Author SHA1 Message Date
Trishna Guha
2e8a3efccb Revert nxos, ios, iosxr return_timestamps (#56206) 
* Revert "nxos_command:run_commands results failure when commands array size >1 (#52670)"
This reverts commit 0df5b92af3.
* Revert "added timestamps to nxos_command module (#50261)"
This reverts commit e150943314.
* Revert "added timestamps to ios_command module (#50323)"
This reverts commit 2a432a093b.
* Revert "added response_timestamps to iosxr_command module (#50095)"
This reverts commit 2a0c356da9.
 2019-05-08 20:49:29 +05:30
John R Barker
52a1e4a599 Fix some module author names (#55770) 
* Fix some module author names

During some data analysis we noticed some typos in author lines.
 2019-04-26 16:11:35 +01:00
Albert Siersema
5f8342bc4c "no macro" command should not be handled by edit_macro(), fixes #55212 (#55218) 2019-04-22 14:54:48 +05:30
Trishna Guha
a41028244d Add platform facts in network facts modules (#51434) 
* Add platform facts in network facts modules

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add nxos

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add vyos

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add iosxr

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add junos

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix pep8

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update unit test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix vyos_facts unittest

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix ios_facts unittest

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix iosxr unittests

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix CI failure

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix junos test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2019-03-11 10:56:39 +05:30
hexdump0x0200
4d407d1781 ios_logging: fix idempotence errors (#53109) 
* ios_logging: fix the error checking the existence of "host" destinations (IOS 12)

In the "have" list, records of type "host" do not contain the key "size",
although in the list "want" it is always there. Because of this, the module
assumes that the "host" type destinations is not configured and does it again.
This does not change the configuration on the device, but is redundant and
the status of the task will always be "changed". This patch fixes it.

* ios_logging: fixes #53227

* ios_logging: minor changes in string matching
 2019-03-07 17:40:03 +05:30
Nilashish Chakraborty
55bfa18c0c New module to support BGP configuration management in IOS (#49121) 
* ios_bgp initial push

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Added tests for ios_bgp

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fixed docs

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Added space

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix Shippable Errors

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix Shippable Errors

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add support for af_neighbor option

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add support for af_neighbor option - 2

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add support for af_neighbor option - 3

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix typo

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Refactor BGP

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix CI and previous reviews

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add missing params documentation

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Remove previous tests

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Remove elements=dict from keys with type=list from args spec for element validation to pass

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Added function to validate input

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix sanity test failure

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Minor bug fixes

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix typo in fixture

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add integration tests

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
 2019-03-04 13:37:57 +05:30
Nilashish Chakraborty
5d8f307116 Revert back to using section (#53069) 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
 2019-02-28 13:43:34 -05:00
Dag Wieers
f9ab9b4d68 Assorted pylint fixes 2019-02-15 06:54:47 -08:00
Matt Clay
3e778d3f8f Fix pycodestyle E117 issues. 2019-02-13 23:35:39 -08:00
Geraint Jones
d1b2ef9c5c ios_user: include filter works just as well. (#51845) 2019-02-08 10:00:39 -05:00
Dennis Israelsson
9243c927ba Ios static route new parameters (#41478) 
* Update ios_static_route.py

* Update version_added
 2019-02-07 10:38:20 -05:00
Federico87
f94378fc2f ios_ntp module (#50705) 
* ios_ntp module

* add execute_module for config func

* fix units test

* test empty list

* update example

* change want logic to follow have - removed try/except

* update commands list for config test

* add idempotent test case

* add more test
 2019-02-01 09:20:02 -05:00
vaneuk
2a432a093b added timestamps to ios_command module (#50323) 
ios_command module now returns timestamps field, which shows command execution time
 2019-01-31 18:11:53 +05:30
Nilashish Chakraborty
92b0cd8e0e Add more return values to *_config modules (#50702) 
* Add more return values to *_config modules

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add more rv

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Exclude from cli_config docs for now

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add new rv docs for junos_config

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix CI errors

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Support date time for configurable backup path

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Change logic based on configurable path

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Remove unwanted import

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix docs

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add filename rv

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Change dosc filename rv

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Make new rv code more readable

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
 2019-01-28 20:49:56 +05:30
Nilashish Chakraborty
69dd03d472 ios_user: Add support for multiple sshkeys (#51173) 
* Add support for multiple sshkeys

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix CI

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add the keys at on go

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Update tests

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
 2019-01-28 13:44:15 +05:30
Ganesh Nalawade
70bf9b9919 Add backup filename and dir path option for config network modules (#50801) 
* Add configurable backup path option for network config modules

Fixes #50283
Fixes #32724

*  Add back_options in network config module argspec
*  Handle backup path options in network action plugin

* Fix review comments

* Add integration tests

* Update changelog
 2019-01-24 09:36:16 +05:30
Nathaniel Case
9702893729 Remove deprecated options from modules (#50246) 
* Remove deprecated options from modules

* Update tests

* Add porting guide notes
 2019-01-22 09:18:26 -05:00
Nilashish Chakraborty
422604fb3e Fix malformed string error for hashed_password (#51007) 
* Fix malformed string error using ast

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Update doc for this option

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Revert "Update doc for this option"

This reverts commit 3579d1912129ab14d5009785ba896de820063d46.

* Revert type value

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
 2019-01-17 13:05:49 +05:30
Felix Fontein
41de2855ae Remove elements= from arg_spec when type is not 'list'. (#50484) 2019-01-09 19:40:17 +05:30
Dag Wieers
05c6ff79f9 Convert to reduced list of known types (#50010) 2018-12-19 07:25:30 +10:00
Nilashish Chakraborty
d729614d72 Add support for hashed password (#49464) 
* Add support for hashed password

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix Shippable errors

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Make pwd options mutually exclusive

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
 2018-12-12 22:22:15 +05:30
Sandra McCann
62af321909 added jinja2 example (#49740) 2018-12-10 13:10:17 -06:00
Paul Neumann
a914f494a8 ios_facts: Gather CDP neighbor data (#49129) 
* ios_facts: Gather CDP neighbor data

* ios_facts: Create tests for ansible_net_neighbors
 2018-11-29 14:05:17 -05:00
Sandra McCann
13a6b4a856 Gather subset fix (#49264) 
*  reword subset description for ios_facts
 2018-11-28 15:33:16 -06:00
Abhijeet Kasurde
bc3e7bbeba E325 Removal - Part II (#49196) 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2018-11-28 13:55:52 +05:30
Paul Neumann
3cc1b8d7d3 ios_facts: Strip header from running-config (#48047) 
IOS prepends a show running-config with lines that are not part of the
configuration, keeping the output from being an entirely valid configuration:
R1#show run
Building configuration...

Current configuration : 2045 bytes
...

In order to be able to use the config from ios_facts as-is, strip this
header.
 2018-11-08 20:28:47 +05:30
Nilashish Chakraborty
f0a057b63a Add support for 25G and 100G interfaces (#47852) 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
 2018-10-31 19:09:53 +05:30
Nilashish Chakraborty
baae7fa9ba Fix ios_user not able to handle certain scenario (#47656) 
* added support for users with password(not secret) configs

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Added example

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix typo

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix pep8

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add integration tests

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
 2018-10-31 16:51:46 +05:30
Matt Clay
37b013aca3 Enable additional pylint rules and resolve issues found. (#47221) 
* Resolve unneeded-not.
* Resolve global-at-module-level.
* Resolve useless-import-alias.
* Resolve bad-whitespace.
* Resolve global-variable-not-assigned.
* Resolve logging-not-lazy.
* Resolve comparison-with-itself.
 2018-10-18 13:38:08 -07:00
Paul Neumann
39673dfc37 ios_facts: Fix minor aesthetical glitches (#46577) 
* ios_facts: Fix LLDP gathering without neighbors

When LLDP is enabled but no neighbors are present, the following
structure is generated:
...
            "ansible_net_neighbors": {
                "null": [
                    {
                        "host": null,
                        "port": null
                    }
                ]
            },
...
If we are not able to find any relevant LLDP information, bail out early
so cases like shown above are handled more gracefully.

* ios_facts: Remove trailing space in lineprotocol

Some Cisco devices (at least CSR1000V 16.6.4) add a space after the
line protocol. This causes the space to be present in the result of
fact gathering:
            "ansible_net_interfaces": {
                "GigabitEthernet2": {
...
                    "lineprotocol": "up ",

Be more clear about scanning the output to avoid this behaviour.
 2018-10-10 08:02:14 -04:00
Sebastien Pouplin
4ba0cfeb4b Added iostype details in network ios_facts module (#46599) 2018-10-10 08:00:25 -04:00
akira6592
8213096b7f The sshkey option is available in version 2.7 and above (#46103) 2018-09-25 10:41:23 +01:00
Joachim Mathes
30314c15c7 Generalize config retrieval in ios_l3_interface module (#45270) 
This makes it work with Cisco 3750E.
 2018-09-25 12:28:32 +05:30
Nathaniel Case
285b927889 network command modules cleanup (#45242) 
* Standardize _command modules

* Centralize command transformation process

* Fix check mode error test
 2018-09-13 08:55:35 -04:00
Nilashish Chakraborty
0f268e70a1 Fix ios_user issues (#44904) 
* Fix ios_user issues

* Modify regex and fix unittests
 2018-08-31 11:08:46 +05:30
Ryan Breaker
c9adfdf68b Reword documentation for IOS L2/L3 interface modules (#44870) 
* Update documentation to be cohesive with ios_l2_interface

* Fix small typo in documentation
 2018-08-30 14:48:43 -05:00
Justin Yaple
a767929456 Fix 'macro name' timeout (#44001) 
* Fix 'macro name' timeout

Added function to send macro to device using 'sendonly'.

* Filter 'macro' from normal commands

* Removed white space

* Undefined variable 'cmd'
 2018-08-30 18:11:51 +05:30
Dennis Israelsson
49f692b08f ios_vrf speed fix (#43765) 2018-08-27 08:51:33 -04:00
Clement Trebuchet
401c45384e FIX ISSUE:#43878 when the vlans string have a final comma. (#43879) 2018-08-20 12:48:46 +05:30
Chris Smolen
3f5cf2aad4 add example using the "when" keyword (#41038) 
* add example using the "when" keyword

<!--- Your description here -->
add example using the "when" keyword comparing group_var variable to returned value from ios_facts
+label: docsite_pr
+label: issue #311

* Update ios_config.py

* Update ios_config.py
 2018-08-17 14:30:37 -04:00
housysadm
bb553f138b ios_user purge example (#42904) 
* Update ios_user.py

Added an example of purging all users except those listed and admin

* Update ios_user.py
 2018-08-14 17:23:10 -04:00
Nilashish Chakraborty
b14f256d41 Fixes ios_l2_interface and ios_vlan not working on certain interface types issue (#43819) 
* Fixes #43654 and #43582

* Remove q statement

* Fix shippable errors

* Fix more shippable errors

* Fix unittest
 2018-08-14 11:35:09 +05:30
Joren Vrancken
b954917761 Surround top-level function and class definitions with two blank lines. 2018-07-31 12:06:56 -07:00
Ganesh Nalawade
21dcaa4349 Handle ConnectionError exception in network modules (#43353) 
* Handle ConnectionError exception in network modules

* Catch ConnectionError expection and fail module in case
  expection is raised.

* Fix CI failure
 2018-07-30 10:24:58 +05:30
Ganesh Nalawade
af3f510316 nxos cliconf plugin refactor (#43203) 
* nxos cliconf plugin refactor

Fixes #39056

*  Refactor nxos cliconf plugin as per new api definition
*  Minor changes in ios, eos, vyos cliconf plugin
*  Change nxos httpapi plugin edit_config method to be in sync with
   nxos cliconf edit_config

* Fix CI failure

* Fix unit test failure and review comment
 2018-07-27 11:05:40 +05:30
Matej Vadnjal
7c318d4e30 ios_user module - implement sshkey option (#38782) 
* ios_user module - add sshkey support

* ios_user - Add version_added to sshkey option

* ios_user - pep8 indentation fixes in unit tests

* ios_user - use b64decode method that works on python 2 and 3
 2018-07-19 10:28:52 -04:00
Clement Trebuchet
7c97bb5077 Devel ios vrf submode (#41659) 
* add submode features ipv4/ipv6

* add tests for submode

* the parameters both_ * were not idempotent, in what is read in the configuration we have a list with 2 entries (import, export) while the input parameter has only one parameter which will be applied twice

* add docstring to the ios_vrf module + provide a fix for: https://github.com/ansible/ansible/issues/41581

* complete tests

* add missing description

* fix KeyError for address-family ipv*

* fix both_* tests

* fix E231, W292, W293

* fix W293

* remove set has it doesn't preserve order of routes

* fix E106

* remove ImportError: cannot import name OrderedDict

* We should be able to mix the parameters for the routes targets , while remaining imdepotent. During the first implementation we did not take this into account, which did not correspond to the reality of the needs in production (to be able to use each parameter indifemently together)

* remove epdb reference

* FIX E111, E106

* FIX E302

* using loop produce a result who  was not imdepotent

* FIX E241

* fix: used pass intead of list
 2018-07-12 20:27:10 +05:30
Nilashish Chakraborty
fa624eba29 Fixed regex to pick correct items (#42557) 2018-07-11 19:20:50 +05:30
Zhikang Zhang
70e33ef92c Make ios_vlan identify vlans starting with 9 (#42247) 
* Make ios_vlan identify vlans starting with 9

* Add unit test for vlan id start with 9
 2018-07-09 09:50:06 -04:00
Paul Neumann
dfb2b3fdd5 ios_facts: Report space of file systems (#41850) 
* ios_facts: Report file system space

Parse total and free space from dir output. For this, add a hash
filesystems_info containing the keys spacetotal_kb and spacefree_kb.

* ios_facts: Add unit test for file system space reporting

* ios_facts: Add integration test for file system space reporting
 2018-07-09 09:15:31 -04:00