Rename inconsistent azure_rm_virtualmachine_scaleset modules (#54579)

@yungezz yes, i remember. pls keep in mind that they are not broken

test/integration/targets/azure_rm_autoscale/tasks/main.yml

@@ -18,7 +18,7 @@
     virtual_network: testVnet
 
 - name: Create VMSS
-  azure_rm_virtualmachine_scaleset:
+  azure_rm_virtualmachinescaleset:
     resource_group: "{{ resource_group }}"
     name: testVMSS{{ rpfx }}
     vm_size: Standard_DS1_v2
@@ -199,7 +199,7 @@
       - not output.changed
 
 - name: Clean VMSS
-  azure_rm_virtualmachine_scaleset:
+  azure_rm_virtualmachinescaleset:
     resource_group: "{{ resource_group }}"
     vm_size: Standard_DS1_v2
     name: testVMSS{{ rpfx }}

test/integration/targets/azure_rm_virtualmachinescaleset/aliases

@@ -1,7 +1,7 @@
 cloud/azure
 shippable/azure/group4
 destructive
-azure_rm_virtualmachine_scaleset_facts
+azure_rm_virtualmachinescaleset_facts
 azure_rm_virtualmachinescalesetinstance_facts
 azure_rm_virtualmachinescalesetextension
 azure_rm_virtualmachinescalesetextension_facts

test/integration/targets/azure_rm_virtualmachinescaleset/tasks/main.yml

@@ -92,7 +92,7 @@
     state: absent
 
 - name: Create VMSS (check mode)
-  azure_rm_virtualmachine_scaleset:
+  azure_rm_virtualmachinescaleset:
     resource_group: "{{ resource_group }}"
     name: testVMSS{{ rpfx }}
     vm_size: Standard_B1s
@@ -125,7 +125,7 @@
     that: results.changed
 
 - name: Get VMSS to assert no VMSS is created in check mode
-  azure_rm_virtualmachine_scaleset_facts:
+  azure_rm_virtualmachinescaleset_facts:
     resource_group: "{{ resource_group }}"
     name: testVMSS{{ rpfx }}
     format: curated
@@ -137,7 +137,7 @@
       - output_scaleset.ansible_facts.azure_vmss | length == 0
 
 - name: Create VMSS
-  azure_rm_virtualmachine_scaleset:
+  azure_rm_virtualmachinescaleset:
     resource_group: "{{ resource_group }}"
     name: testVMSS{{ rpfx }}
     vm_size: Standard_B1s
@@ -170,7 +170,7 @@
     that: results.changed
 
 - name: Create VMSS -- test upgrade_policy idempotence and load balancer
-  azure_rm_virtualmachine_scaleset:
+  azure_rm_virtualmachinescaleset:
     resource_group: "{{ resource_group }}"
     name: testVMSS{{ rpfx }}
     vm_size: Standard_B1s
@@ -203,7 +203,7 @@
     that: results.changed
 
 - name: Retrieve scaleset facts
-  azure_rm_virtualmachine_scaleset_facts:
+  azure_rm_virtualmachinescaleset_facts:
     resource_group: "{{ resource_group }}"
     name: testVMSS{{ rpfx }}
     format: curated
@@ -236,7 +236,7 @@
     body: "{{ output_scaleset.vmss[0] }}"
 
 - name: Try to update VMSS using output as input
-  azure_rm_virtualmachine_scaleset:
+  azure_rm_virtualmachinescaleset:
     resource_group: "{{ body.resource_group }}"
     name: "{{ body.name }}"
     vm_size: "{{ body.vm_size }}"
@@ -382,13 +382,13 @@
 
 
 - name: Delete VMSS
-  azure_rm_virtualmachine_scaleset:
+  azure_rm_virtualmachinescaleset:
     resource_group: "{{ resource_group }}"
     name: testVMSS{{ rpfx }}
     state: absent
 
 - name: Create VMSS with security group in same resource group, with accelerated networking(check mode).
-  azure_rm_virtualmachine_scaleset:
+  azure_rm_virtualmachinescaleset:
     resource_group: "{{ resource_group }}"
     name: testVMSS{{ rpfx }}2
     vm_size: Standard_D3_v2
@@ -412,7 +412,7 @@
     that: results.changed
 
 - name: Create VMSS with security group in same resource group, with accelerated networking.
-  azure_rm_virtualmachine_scaleset:
+  azure_rm_virtualmachinescaleset:
     resource_group: "{{ resource_group }}"
     name: testVMSS{{ rpfx }}2
     vm_size: Standard_D3_v2
@@ -438,7 +438,7 @@
       - 'results.ansible_facts.azure_vmss.properties.virtualMachineProfile.networkProfile.networkInterfaceConfigurations.0.properties.networkSecurityGroup != {}'
 
 - name: Create VMSS with security group in same resource group, with accelerated networking.
-  azure_rm_virtualmachine_scaleset:
+  azure_rm_virtualmachinescaleset:
     resource_group: "{{ resource_group }}"
     name: testVMSS{{ rpfx }}2
     vm_size: Standard_D3_v2
@@ -462,7 +462,7 @@
       - not results.changed
 
 - name: Create VMSS with security group in same resource group, with accelerated networking.
-  azure_rm_virtualmachine_scaleset:
+  azure_rm_virtualmachinescaleset:
     resource_group: "{{ resource_group }}"
     name: testVMSS{{ rpfx }}2
     vm_size: Standard_D3_v2
@@ -486,7 +486,7 @@
       - results.changed
 
 - name: update VMSS with security group in different resource group.
-  azure_rm_virtualmachine_scaleset:
+  azure_rm_virtualmachinescaleset:
     resource_group: "{{ resource_group }}"
     name: testVMSS{{ rpfx }}2
     vm_size: Standard_B1s
@@ -513,13 +513,13 @@
 #      - '"testNetworkSecurityGroup2" in results.ansible_facts.azure_vmss.properties.virtualMachineProfile.networkProfile.networkInterfaceConfigurations.0.properties.networkSecurityGroup.id'
 
 - name: Delete VMSS
-  azure_rm_virtualmachine_scaleset:
+  azure_rm_virtualmachinescaleset:
     resource_group: "{{ resource_group }}"
     name: testVMSS{{ rpfx }}2
     state: absent
 
 - name: Fail when instance type is not supported to enable accelerated networking
-  azure_rm_virtualmachine_scaleset:
+  azure_rm_virtualmachinescaleset:
     resource_group: "{{ resource_group }}"
     name: testVMSS{{ rpfx }}4
     vm_size: Standard_B1s
@@ -577,7 +577,7 @@
 # TODO: Until we have a module to create/delete images this is the best tests
 # I can do
 - name: assert error thrown with invalid image dict
-  azure_rm_virtualmachine_scaleset:
+  azure_rm_virtualmachinescaleset:
       resource_group: "{{ resource_group }}"
       name: testvm002
       vm_size: Standard_B1s
@@ -587,7 +587,7 @@
   failed_when: 'fail_invalid_image_dict.msg != "parameter error: expecting image to contain [publisher, offer, sku, version] or [name, resource_group]"'
 
 - name: assert error thrown with invalid image type
-  azure_rm_virtualmachine_scaleset:
+  azure_rm_virtualmachinescaleset:
       resource_group: "{{ resource_group }}"
       name: testvm002
       vm_size: Standard_B1s
@@ -597,7 +597,7 @@
   failed_when: 'fail_invalid_image_type.msg != "parameter error: expecting image to be a string or dict not list"'
 
 - name: assert error finding missing custom image
-  azure_rm_virtualmachine_scaleset:
+  azure_rm_virtualmachinescaleset:
       resource_group: "{{ resource_group }}"
       name: testvm002
       vm_size: Standard_B1s
@@ -606,7 +606,7 @@
   failed_when: fail_missing_custom_image.msg != "Error could not find image with name invalid-image"
 
 - name: assert error finding missing custom image (dict style)
-  azure_rm_virtualmachine_scaleset:
+  azure_rm_virtualmachinescaleset:
       resource_group: "{{ resource_group }}"
       name: testvm002
       vm_size: Standard_B1s