Ansible Config part2 (#27448)

* Ansible Config part2

- made dump_me nicer, added note this is not prod
- moved internal key removal function to vars
- carry tracebacks in errors we can now show tracebacks for plugins on vvv
- show inventory plugin tracebacks on vvv
- minor fixes to cg groups plugin
- draft config from plugin docs
- made search path warning 'saner' (top level dirs only)
- correctly display config entries and others
- removed unneeded code
- commented out some conn plugin specific from base.yml
- also deprecated sudo/su
- updated ssh conn docs
- shared get option method for connection plugins
- note about needing eval for defaults
- tailored yaml ext
- updated strategy entry
- for connection pliugins, options load on plugin load
- allow for long types in definitions
- better display in ansible-doc
- cleaned up/updated source docs and base.yml
- added many descriptions
- deprecated include toggles as include is
- draft backwards compat get_config
- fixes to ansible-config, added --only-changed
- some code reoorg
- small license headers
- show default in doc type
- pushed module utils details to 5vs
- work w/o config file
- PEPE ATE!
- moved loader to it's own file
- fixed rhn_register test
- fixed boto requirement in make tests
- I ate Pepe
- fixed dynamic eval of defaults
- better doc code

skip ipaddr filter tests when missing netaddr
removed devnull string from config
better becoem resolution

* killed extra space with extreeme prejudice

cause its an affront against all that is holy that 2 spaces touch each other!

shippable timing out on some images, but merging as it passes most

test/runner/lib/ansible_util.py

@@ -21,20 +21,19 @@ def ansible_environment(args, color=True):
     if not path.startswith(ansible_path + os.pathsep):
         path = ansible_path + os.pathsep + path
 
-    ansible_config = '/dev/null'
-    if os.path.isfile('test/integration/%s.cfg' % args.command):
-        ansible_config = os.path.abspath('test/integration/%s.cfg' % args.command)
-
     ansible = dict(
         ANSIBLE_FORCE_COLOR='%s' % 'true' if args.color and color else 'false',
         ANSIBLE_DEPRECATION_WARNINGS='false',
-        ANSIBLE_CONFIG=ansible_config,
         ANSIBLE_HOST_KEY_CHECKING='false',
         PYTHONPATH=os.path.abspath('lib'),
         PAGER='/bin/cat',
         PATH=path,
     )
 
+    if os.path.isfile('test/integration/%s.cfg' % args.command):
+        ansible_config = os.path.abspath('test/integration/%s.cfg' % args.command)
+        ansible['ANSIBLE_CONFIG'] = ansible_config
+
     env.update(ansible)
 
     if args.debug:

test/sanity/pep8/legacy-files.txt

@@ -1,4 +1,5 @@
 lib/ansible/cli/config.py
+lib/ansible/constants.py
 lib/ansible/config/data.py
 lib/ansible/config/manager.py
 lib/ansible/modules/cloud/amazon/_ec2_ami_search.py

test/units/executor/test_task_executor.py

@@ -24,7 +24,7 @@ from ansible.compat.tests.mock import patch, MagicMock
 from ansible.errors import AnsibleError, AnsibleParserError
 from ansible.executor.task_executor import TaskExecutor
 from ansible.playbook.play_context import PlayContext
-from ansible.plugins import action_loader, lookup_loader
+from ansible.plugins.loader import action_loader, lookup_loader
 from ansible.parsing.yaml.objects import AnsibleUnicode
 
 from units.mock.loader import DictDataLoader

test/units/modules/cloud/amazon/test_data_pipeline.py

@@ -16,14 +16,20 @@
 # along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
 
 import pytest
-import boto3
 import os
 import json
 import collections
 from . placebo_fixtures import placeboify, maybe_sleep
+from nose.plugins.skip import SkipTest
+
 from ansible.modules.cloud.amazon import data_pipeline
 from ansible.module_utils._text import to_text
 
+try:
+    import boto3
+except ImportError:
+    raise SkipTest("test_api_gateway.py requires the `boto3` and `botocore` modules")
+
 
 @pytest.fixture(scope='module')
 def dp_setup():

test/units/modules/packaging/os/test_rhn_register.py

@@ -3,6 +3,7 @@ import json
 from ansible.compat.tests import unittest
 from ansible.compat.tests.mock import PropertyMock, patch, mock_open
 from ansible.module_utils import basic
+from ansible.module_utils._text import to_native
 from ansible.module_utils.six.moves import xmlrpc_client
 from ansible.modules.packaging.os import rhn_register
 
@@ -96,7 +97,7 @@ class TestRhnRegister(unittest.TestCase):
             orig_import = __import__
             with patch('__builtin__.__import__', side_effect=mock_import):
                 rhn = self.module.Rhn()
-                self.assertEqual('123456789', rhn.systemid)
+                self.assertEqual('123456789', to_native(rhn.systemid))
 
     def test_without_required_parameters(self):
         """Failure must occurs when all parameters are missing"""

test/units/plugins/filter/test_ipaddr.py

@@ -20,6 +20,11 @@ __metaclass__ = type
 from ansible.compat.tests import unittest
 from ansible.plugins.filter.ipaddr import (ipaddr, _netmask_query, nthhost, next_nth_usable,
                                            previous_nth_usable, network_in_usable, network_in_network)
+try:
+    import netaddr
+except ImportError:
+    from nose.plugins.skip import SkipTest
+    raise SkipTest("This test  requires the `netaddr` python library")
 
 
 class TestIpFilter(unittest.TestCase):

test/units/plugins/lookup/test_password.py

@@ -29,7 +29,7 @@ from ansible.compat.tests.mock import mock_open, patch
 from ansible.errors import AnsibleError
 from ansible.module_utils.six import text_type
 from ansible.module_utils.six.moves import builtins
-from ansible.plugins import PluginLoader
+from ansible.plugins.loader import PluginLoader
 from ansible.plugins.lookup import password
 from ansible.utils import encrypt
 

test/units/plugins/test_plugins.py

@@ -24,7 +24,7 @@ import os
 
 from ansible.compat.tests import BUILTINS, unittest
 from ansible.compat.tests.mock import mock_open, patch, MagicMock
-from ansible.plugins import MODULE_CACHE, PATH_CACHE, PLUGIN_PATH_CACHE, PluginLoader
+from ansible.plugins.loader import MODULE_CACHE, PATH_CACHE, PLUGIN_PATH_CACHE, PluginLoader
 
 
 class TestErrors(unittest.TestCase):