small fixes and additions to bigip_virtual_address (#40362)

* Updated parameter names to match updated features in BIGIP
* Added support for route domains
This commit is contained in:
Tim Rupp
2018-05-17 20:45:53 -07:00
committed by GitHub
parent 9eb2a6b41b
commit f87cda8a54
2 changed files with 186 additions and 60 deletions

View File

@@ -21,6 +21,7 @@ from ansible.module_utils.basic import AnsibleModule
try:
from library.modules.bigip_virtual_address import Parameters
from library.modules.bigip_virtual_address import ModuleParameters
from library.modules.bigip_virtual_address import ModuleManager
from library.modules.bigip_virtual_address import ArgumentSpec
from library.module_utils.network.f5.common import F5ModuleError
@@ -29,6 +30,7 @@ try:
except ImportError:
try:
from ansible.modules.network.f5.bigip_virtual_address import Parameters
from ansible.modules.network.f5.bigip_virtual_address import ModuleParameters
from ansible.modules.network.f5.bigip_virtual_address import ModuleManager
from ansible.modules.network.f5.bigip_virtual_address import ArgumentSpec
from ansible.module_utils.network.f5.common import F5ModuleError
@@ -69,10 +71,10 @@ class TestParameters(unittest.TestCase):
arp_state='enabled',
auto_delete='enabled',
icmp_echo='enabled',
advertise_route='always',
availability_calculation='always',
use_route_advertisement='yes'
)
p = Parameters(params=args)
p = ModuleParameters(params=args)
assert p.state == 'present'
assert p.address == '1.1.1.1'
assert p.netmask == '2.2.2.2'
@@ -80,8 +82,8 @@ class TestParameters(unittest.TestCase):
assert p.arp_state == 'enabled'
assert p.auto_delete is True
assert p.icmp_echo == 'enabled'
assert p.advertise_route == 'none'
assert p.use_route_advertisement == 'enabled'
assert p.availability_calculation == 'none'
assert p.route_advertisement_type == 'enabled'
def test_api_parameters(self):
args = load_fixture('load_ltm_virtual_address_default.json')
@@ -94,22 +96,22 @@ class TestParameters(unittest.TestCase):
assert p.state == 'enabled'
assert p.icmp_echo == 'enabled'
assert p.netmask == '255.255.255.255'
assert p.use_route_advertisement == 'disabled'
assert p.advertise_route == 'any'
assert p.route_advertisement_type == 'disabled'
assert p.availability_calculation == 'any'
def test_module_parameters_advertise_route_all(self):
args = dict(
advertise_route='when_all_available'
availability_calculation='when_all_available'
)
p = Parameters(params=args)
assert p.advertise_route == 'all'
assert p.availability_calculation == 'all'
def test_module_parameters_advertise_route_any(self):
args = dict(
advertise_route='when_any_available'
availability_calculation='when_any_available'
)
p = Parameters(params=args)
assert p.advertise_route == 'any'
assert p.availability_calculation == 'any'
def test_module_parameters_icmp_echo_disabled(self):
args = dict(
@@ -143,7 +145,7 @@ class TestParameters(unittest.TestCase):
args = dict(
use_route_advertisement='no'
)
p = Parameters(params=args)
p = ModuleParameters(params=args)
assert p.use_route_advertisement == 'disabled'
def test_module_parameters_state_present(self):