ios test changes (#35510)

* Fix over-byte

* Update ios tests to call `provider`

To continue to support testing `connection: local`

* Fix command dict handling in ios_user

* Clean up unit tests, too

test/integration/targets/ios_interface/tests/cli/basic.yaml

@@ -8,7 +8,7 @@
     speed: 1000
     mtu: 1800
     state: present
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - name: Configure interface
@@ -16,7 +16,7 @@
     name: "{{ test_interface }}"
     description: test-interface-initial
     state: present
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -30,7 +30,7 @@
     name: "{{ test_interface }}"
     description: test-interface-initial
     state: present
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -43,7 +43,7 @@
     description: test-interface
     mtu: 2000
     state: present
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -59,7 +59,7 @@
     description: test-interface-1
     mtu: 1800
     state: present
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -73,7 +73,7 @@
   ios_interface:
     name: "{{ test_interface }}"
     enabled: False
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -86,7 +86,7 @@
   ios_interface:
     name: "{{ test_interface }}"
     enabled: True
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -102,7 +102,7 @@
     speed: 1000
     mtu: 1800
     state: present
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - name: Add interface aggregate
@@ -112,7 +112,7 @@
     - { name: "{{ test_interface2 }}", mtu: 2000, description: test-interface-2 }
     speed: 1000
     state: present
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -131,7 +131,7 @@
     - { name: "{{ test_interface2 }}", mtu: 2000, description: test-interface-2 }
     speed: 1000
     state: present
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -145,7 +145,7 @@
     - { name: "{{ test_interface2 }}" }
     enabled: False
     state: present
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -163,7 +163,7 @@
     - { name: "{{ test_interface2 }}" }
     enabled: True
     state: present
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -180,7 +180,7 @@
     - name: Loopback9
     - name: Loopback10
     state: absent
-    authorize: yes
+    provider: "{{ cli }}"
 
 - name: Create loopback interface aggregate
   ios_interface:
@@ -188,7 +188,7 @@
     - name: Loopback9
     - name: Loopback10
     state: present
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -203,7 +203,7 @@
     - name: Loopback9
     - name: Loopback10
     state: absent
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -218,7 +218,7 @@
     - name: Loopback9
     - name: Loopback10
     state: absent
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:

test/integration/targets/ios_interface/tests/cli/intent.yaml

@@ -7,7 +7,7 @@
     state: up
     tx_rate: ge(0)
     rx_rate: ge(0)
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -20,7 +20,7 @@
     state: down
     tx_rate: gt(0)
     rx_rate: lt(0)
-    authorize: yes
+    provider: "{{ cli }}"
   ignore_errors: yes
   register: result
 
@@ -36,7 +36,7 @@
     name: "{{ test_interface }}"
     enabled: False
     state: down
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -47,7 +47,7 @@
   ios_interface:
     name: "{{ test_interface }}"
     enabled: False
-    authorize: yes
+    provider: "{{ cli }}"
     state: up
   ignore_errors: yes
   register: result
@@ -61,7 +61,7 @@
   ios_command:
     commands:
       - show lldp neighbors
-    authorize: yes
+    provider: "{{ cli }}"
   register: show_lldp_neighbors_result
 
 - block:
@@ -71,7 +71,7 @@
         neighbors:
           - port: eth0
             host: netdev
-        authorize: yes
+        provider: "{{ cli }}"
       register: result
 
     - assert:
@@ -84,7 +84,7 @@
         neighbors:
           - port: dummy_port
             host: dummy_host
-        authorize: yes
+        provider: "{{ cli }}"
       ignore_errors: yes
       register: result
 
@@ -101,7 +101,7 @@
       - name: "{{ test_interface }}"
         enabled: True
         state: up
-    authorize: yes
+    provider: "{{ cli }}"
   ignore_errors: yes
   register: result
 
@@ -117,7 +117,7 @@
             neighbors:
               - port: eth0
                 host: netdev
-        authorize: yes
+        provider: "{{ cli }}"
       ignore_errors: yes
       register: result
 
@@ -134,7 +134,7 @@
             host: netdev
           - port: dummy_port
             host: dummy_host
-        authorize: yes
+        provider: "{{ cli }}"
       ignore_errors: yes
       register: result
 

test/integration/targets/ios_interface/tests/cli/net_interface.yaml

@@ -11,7 +11,7 @@
     speed: 1000
     mtu: 1800
     state: present
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - name: Configure interface using platform agnostic module
@@ -19,7 +19,7 @@
     name: "{{ test_interface }}"
     description: test-interface-initial
     state: present
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert:
@@ -34,7 +34,7 @@
     description: test-interface
     mtu: 2000
     state: present
-    authorize: yes
+    provider: "{{ cli }}"
   register: result
 
 - assert: