yum always return changes dict, not only in check mode (#51987)

Previously the yum module would provide a `changes` dict when
executed in check mode but omit it when not in check mode in favor
of the `results` data which is raw output from the yum command. This
pull request makes that output uniform.

Fixes #51724

Signed-off-by: Adam Miller <admiller@redhat.com>
This commit is contained in:
Adam Miller
2019-02-13 16:46:32 -06:00
committed by ansibot
parent 9e71ec71a3
commit ea0e2bf2b3
4 changed files with 97 additions and 29 deletions

View File

@@ -0,0 +1,61 @@
- name: install htop in check mode to verify changes dict returned
yum:
name: htop
state: present
check_mode: yes
register: yum_changes_check_mode_result
- name: install verify changes dict returned in check mode
assert:
that:
- "yum_changes_check_mode_result is success"
- "yum_changes_check_mode_result is changed"
- "'changes' in yum_changes_check_mode_result"
- "'installed' in yum_changes_check_mode_result['changes']"
- "'htop' in yum_changes_check_mode_result['changes']['installed']"
- name: install htop to verify changes dict returned
yum:
name: htop
state: present
register: yum_changes_result
- name: install verify changes dict returned
assert:
that:
- "yum_changes_result is success"
- "yum_changes_result is changed"
- "'changes' in yum_changes_result"
- "'installed' in yum_changes_result['changes']"
- "'htop' in yum_changes_result['changes']['installed']"
- name: remove htop in check mode to verify changes dict returned
yum:
name: htop
state: absent
check_mode: yes
register: yum_changes_check_mode_result
- name: remove verify changes dict returned in check mode
assert:
that:
- "yum_changes_check_mode_result is success"
- "yum_changes_check_mode_result is changed"
- "'changes' in yum_changes_check_mode_result"
- "'removed' in yum_changes_check_mode_result['changes']"
- "'htop' in yum_changes_check_mode_result['changes']['removed']"
- name: remove htop to verify changes dict returned
yum:
name: htop
state: absent
register: yum_changes_result
- name: remove verify changes dict returned
assert:
that:
- "yum_changes_result is success"
- "yum_changes_result is changed"
- "'changes' in yum_changes_result"
- "'removed' in yum_changes_result['changes']"
- "'htop' in yum_changes_result['changes']['removed']"

View File

@@ -71,3 +71,7 @@
- (ansible_distribution in ['RedHat', 'CentOS', 'ScientificLinux'] and ansible_distribution_major_version|int > 6)
- include: 'proxy.yml'
- include: 'check_mode_consistency.yml'
when:
- (ansible_distribution in ['RedHat', 'CentOS', 'ScientificLinux'] and ansible_distribution_major_version|int == 7)