mirror of
https://github.com/ansible-collections/community.general.git
synced 2026-05-07 13:52:54 +00:00
Fixes for WinRM/PowerShell support in v2.
- Add support for inserting module args into PowerShell modules. Fixes #11661. - Support Windows paths containing spaces. Applies changes from #10727 to v2. Fixes #9999. Should also fix ansible/ansible-modules-core#944 and ansible/ansible-modules-core#1007. - Change how execution policy is set for running remote scripts. Applies changes from #11092 to v2. Also fixes ansible/ansible-modules-core#1776. - Use codepage 65001 (UTF-8) for WinRM connection instead of default (CP437), convert command to UTF-8 and results from UTF-8. Replaces changes from #10024. Fixes #11198. - Close WinRM connection when task completes. - Use win_stat, win_file and win_copy modules instead of stat, file and copy when called from within other action plugins (only when using WinRM+PowerShell). - Unquote Windows path arguments before passing to win_stat, win_file, win_copy and slurp modules (only when using WinRM/PowerShell). - Check for win_ping module to determine if core modules are missing (only when using WinRM/PowerShell). - Add stdout_lines to result from running low level commands (so stdout_lines is available when using raw/script). - Update copy action plugin to use shell functions for joining paths and checking for trailing slash. - Update fetch action plugin to unquote source path when using Windows paths. - Add win_copy and win_template action plugins that inherit from copy and template. - Support running .bat and .cmd scripts using default system encoding instead of UTF-8. - Always send PowerShell commands as base64-encoded blobs to allow for running simple PowerShell commands via raw. - Support running modules on Windows with interpreters other than PowerShell. - Update integration tests to support above changes and test unicode fixes. - Add test for win_user error from ansible/ansible-modules-core#1241 (fixed by ansible/ansible-modules-core#1774). - Add test for additional win_stat output values (implemented by ansible/ansible-modules-core#1473). - Add test for OS architecture and name from setup.ps1 (implemented by ansible/ansible-modules-core#1100). All WinRM integration tests pass for me with these changes.
This commit is contained in:
committed by
James Cammarata
parent
fa8043c0ba
commit
e87cf4a3cc
@@ -28,7 +28,7 @@
|
||||
- "win_ping_result.ping == 'pong'"
|
||||
|
||||
- name: test win_ping with data
|
||||
win_ping: data=blah
|
||||
win_ping: data=☠
|
||||
register: win_ping_with_data_result
|
||||
|
||||
- name: check win_ping result with data
|
||||
@@ -36,21 +36,11 @@
|
||||
that:
|
||||
- "not win_ping_with_data_result|failed"
|
||||
- "not win_ping_with_data_result|changed"
|
||||
- "win_ping_with_data_result.ping == 'blah'"
|
||||
- "win_ping_with_data_result.ping == '☠'"
|
||||
|
||||
#- name: test local ping (should use default ping)
|
||||
# local_action: ping
|
||||
# register: local_ping_result
|
||||
|
||||
#- name: check local ping result
|
||||
# assert:
|
||||
# that:
|
||||
# - "not local_ping_result|failed"
|
||||
# - "not local_ping_result|changed"
|
||||
# - "local_ping_result.ping == 'pong'"
|
||||
|
||||
- name: test win_ping.ps1 with data
|
||||
win_ping.ps1: data=bleep
|
||||
- name: test win_ping.ps1 with data as complex args
|
||||
win_ping.ps1:
|
||||
data: bleep
|
||||
register: win_ping_ps1_result
|
||||
|
||||
- name: check win_ping.ps1 result with data
|
||||
@@ -60,13 +50,32 @@
|
||||
- "not win_ping_ps1_result|changed"
|
||||
- "win_ping_ps1_result.ping == 'bleep'"
|
||||
|
||||
#- name: test win_ping with invalid args
|
||||
# win_ping: arg=invalid
|
||||
# register: win_ping_ps1_invalid_args_result
|
||||
|
||||
#- name: check that win_ping.ps1 with invalid args fails
|
||||
# assert:
|
||||
# that:
|
||||
# - "win_ping_ps1_invalid_args_result|failed"
|
||||
# - "win_ping_ps1_invalid_args_result.msg"
|
||||
- name: test win_ping with extra args to verify that v2 module replacer escaping works as expected
|
||||
win_ping:
|
||||
data: bloop
|
||||
a_null: null
|
||||
a_boolean: true
|
||||
another_boolean: false
|
||||
a_number: 299792458
|
||||
another_number: 22.7
|
||||
yet_another_number: 6.022e23
|
||||
a_string: |
|
||||
it's magic
|
||||
"@'
|
||||
'@"
|
||||
an_array:
|
||||
- first
|
||||
- 2
|
||||
- 3.0
|
||||
an_object:
|
||||
- the_thing: the_value
|
||||
- the_other_thing: 0
|
||||
- the_list_of_things: [1, 2, 3, 5]
|
||||
register: win_ping_extra_args_result
|
||||
|
||||
- name: check that win_ping with extra args succeeds and ignores everything except data
|
||||
assert:
|
||||
that:
|
||||
- "not win_ping_extra_args_result|failed"
|
||||
- "not win_ping_extra_args_result|changed"
|
||||
- "win_ping_extra_args_result.ping == 'bloop'"
|
||||
|
||||
Reference in New Issue
Block a user