internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-08 06:12:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

swallow errors during async polling (#17760)

Browse Source 
also use connection reset on exceptions if available (eg, prevent reuse of "stuck" WinRM connections due to reboot/NIC bounce/etc)
This commit is contained in:
Matt Davis
2016-09-27 10:31:40 -07:00
committed by GitHub
parent cf7822e201
commit e7819609ce
1 changed files with 18 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
lib/ansible/executor/task_executor.py
View File

@@ -619,14 +619,24 @@ class TaskExecutor:
while time_left > 0: while time_left > 0:
time.sleep(self._task.poll) time.sleep(self._task.poll)
async_result = normal_handler.run(task_vars=task_vars) try:
# We do not bail out of the loop in cases where the failure async_result = normal_handler.run(task_vars=task_vars)
# is associated with a parsing error. The async_runner can # We do not bail out of the loop in cases where the failure
# have issues which result in a half-written/unparseable result # is associated with a parsing error. The async_runner can
# file on disk, which manifests to the user as a timeout happening # have issues which result in a half-written/unparseable result
# before it's time to timeout. # file on disk, which manifests to the user as a timeout happening
if int(async_result.get('finished', 0)) == 1 or ('failed' in async_result and async_result.get('_ansible_parsed', False)) or 'skipped' in async_result: # before it's time to timeout.
break if int(async_result.get('finished', 0)) == 1 or ('failed' in async_result and async_result.get('_ansible_parsed', False)) or 'skipped' in async_result:
break
except Exception as e:
# Connections can raise exceptions during polling (eg, network bounce, reboot); these should be non-fatal.
# On an exception, call the connection's reset method if it has one (eg, drop/recreate WinRM connection; some reused connections are in a broken state)
display.vvvv("Exception during async poll, retrying... (%s)" % to_text(e))
display.debug("Async poll exception was:\n%s" % to_text(traceback.format_exc()))
try:
normal_handler._connection._reset()
except AttributeError:
pass
time_left -= self._task.poll time_left -= self._task.poll