internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-04-10 19:01:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

corrected no_log for items and skipped tasks

Browse Source 
corrected output from default callback
added new tests for no_log loops
updated makefile test to check for both positive and negative occurrences of no_log
This commit is contained in:
Brian Coca
2015-10-02 14:33:02 -04:00
parent 86ef20c73b
commit e2ae3215f6
5 changed files with 16 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
test/integration/Makefile
View File

@@ -192,5 +192,6 @@ test_lookup_paths:
ansible-playbook lookup_paths/play.yml -i $(INVENTORY) -v $(TEST_FLAGS)
no_log:
[ "$$(ansible-playbook no_log_local.yml -i $(INVENTORY) -vvvvv | grep DO_NOT_LOG)" = "" ]
# This test expects 7 loggable vars and 0 non loggable ones, if either mismatches it fails, run the ansible-playbook command to debug
[ "$$(ansible-playbook no_log_local.yml -i $(INVENTORY) -vvvvv | awk -e 'BEGIN { logme = 0; nolog = 0; } /LOG_ME/ { logme += 1;} /DO_NOT_LOG/ { nolog += 1;} END { printf "%d/%d", logme, nolog; }')" = "7/0" ]

15
test/integration/no_log_local.yml
View File

@@ -16,10 +16,11 @@
failed_when: true
ignore_errors: true
- name: failed item args should be logged in the absence of no_log
- name: item args should be logged in the absence of no_log
shell: echo {{ item }}
with_items: [ "LOG_ME_ITEM_FAILED" ]
failed_when: true
with_items: [ "LOG_ME_ITEM", "LOG_ME_SKIPPED", "LOG_ME_ITEM_FAILED" ]
when: item != "LOG_ME_SKIPPED"
failed_when: item == "LOG_ME_ITEM_FAILED"
ignore_errors: true
- name: args should not be logged when task-level no_log set
@@ -49,11 +50,13 @@
no_log: true
when: false
- name: skipped item args should be suppressed with no_log
- name: items args should be suppressed with no_log in every state
shell: echo {{ item }}
no_log: true
with_items: [ "DO_NOT_LOG_ITEM_SKIPPED", "DO_NOT_LOG_ITEM_SKIPPED_2" ]
when: item == False
with_items: [ "DO_NOT_LOG_ITEM", "DO_NOT_LOG_ITEM_SKIPPED", "DO_NOT_LOG_ITEM_FAILED" ]
when: item != "DO_NOT_LOG_ITEM_SKIPPED"
failed_when: item == "DO_NOT_LOG_ITEM_FAILED"
ignore_errors: yes
- name: async task args should suppressed with no_log
async: 10