From e2371d4b5285627738ac86fb3c3be9ddab309c80 Mon Sep 17 00:00:00 2001 From: Hannes Ljungberg Date: Tue, 19 Mar 2019 13:49:45 +0100 Subject: [PATCH] docker_swarm_service: Report warnings on update (#53999) * Report warnings on update * Add comment about warnings support --- lib/ansible/modules/cloud/docker/docker_swarm_service.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/ansible/modules/cloud/docker/docker_swarm_service.py b/lib/ansible/modules/cloud/docker/docker_swarm_service.py index 1ea3476122..f4b40f5b70 100644 --- a/lib/ansible/modules/cloud/docker/docker_swarm_service.py +++ b/lib/ansible/modules/cloud/docker/docker_swarm_service.py @@ -2249,14 +2249,14 @@ class DockerServiceManager(object): def update_service(self, name, old_service, new_service): service_data = new_service.build_docker_service(self.get_networks_names_ids()) - self.client.update_service( + result = self.client.update_service( old_service.service_id, old_service.service_version, name=name, **service_data ) - # Unfortunately, docker-py f***ed up and doesn't return the structure - # the corresponding API call returns, which would include a list of warnings. + # Prior to Docker SDK 4.0.0 no warnings were returned and will thus be ignored. + self.client.report_warnings(result, ['Warning']) def create_service(self, name, service): service_data = service.build_docker_service(self.get_networks_names_ids())