Migrate Network Tests into ansible/ansible (#18233)

* Docs Networking tests

* Copy networking tests from test-network-modules

* Networking transport settings - group_vars

* Network playbooks

* Debug should be off by default

* Update nxos.yaml

* Remove items from top level

* Use dependencies, not pre-tasks

* Remove trailing blank lines

* Remove backup files

* newlines

test/integration/targets/nxos_config/tests/cli/backup.yaml

@@ -0,0 +1,50 @@
+---
+- debug: msg="START cli/backup.yaml"
+
+- name: setup
+  nxos_config:
+    commands:
+      - no description
+      - no shutdown
+    parents:
+      - interface Ethernet2/5
+    match: none
+    provider: "{{ cli }}"
+
+- name: collect any backup files
+  find:
+    paths: "{{ role_path }}/backup"
+    pattern: "{{ inventory_hostname }}_config*"
+  register: backup_files
+  delegate_to: localhost
+
+- name: delete backup files
+  file:
+    path: "{{ item.path }}"
+    state: absent
+  with_items: "{{backup_files.files|default([])}}"
+
+- name: configure device with config
+  nxos_config:
+    src: basic/config.j2
+    backup: yes
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == true"
+      - "result.updates is not defined"
+
+- name: collect any backup files
+  find:
+    paths: "{{ role_path }}/backup"
+    pattern: "{{ inventory_hostname }}_config*"
+  register: backup_files
+  delegate_to: localhost
+
+- assert:
+    that:
+      - "backup_files.files is defined"
+
+- debug: msg="END cli/backup.yaml"

test/integration/targets/nxos_config/tests/cli/defaults.yaml

@@ -0,0 +1,42 @@
+---
+- debug: msg="START cli/defaults.yaml"
+
+- name: setup
+  nxos_config:
+    commands:
+      - no description
+      - shutdown
+    parents:
+      - interface Ethernet2/5
+    match: none
+    provider: "{{ cli }}"
+
+- name: configure device with defaults included
+  nxos_config:
+    src: defaults/config.j2
+    defaults: yes
+    provider: "{{ cli }}"
+  register: result
+
+- debug: var=result
+
+- assert:
+    that:
+      - "result.changed == true"
+      - "result.updates is not defined"
+
+- name: check device with defaults included
+  nxos_config:
+    src: defaults/config.j2
+    defaults: yes
+    provider: "{{ cli }}"
+  register: result
+
+- debug: var=result
+
+- assert:
+    that:
+      - "result.changed == false"
+      - "result.updates is not defined"
+
+- debug: msg="END cli/defaults.yaml"

test/integration/targets/nxos_config/tests/cli/multilevel.yaml

@@ -0,0 +1,58 @@
+---
+- debug: msg="START cli/mulitlevel.yaml"
+
+- name: get config
+  nxos_command:
+    commands: show running-config
+    provider: "{{ cli }}"
+  register: config
+
+- name: enable feature bgp
+  nxos_config:
+    lines: feature bgp
+    provider: "{{ cli }}"
+  when: "'feature bgp' not in config.stdout[0]"
+
+- name: remove bgp
+  nxos_config:
+    lines: no router bgp 1
+    provider: "{{ cli }}"
+  when: "'router bgp 1' in config.stdout[0]"
+
+- name: configure multi level command
+  nxos_config:
+    lines: maximum-paths 14
+    parents:
+      - router bgp 1
+      - address-family ipv4 unicast
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == true"
+      - "'router bgp 1' in result.updates"
+      - "'address-family ipv4 unicast' in result.updates"
+      - "'maximum-paths 14' in result.updates"
+
+- name: check multi level command
+  nxos_config:
+    lines: maximum-paths 14
+    parents:
+      - router bgp 1
+      - address-family ipv4 unicast
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == false"
+
+- name: teardown
+  nxos_config:
+    lines:
+      - no feature bgp
+    match: none
+    provider: "{{ cli }}"
+
+- debug: msg="END cli/mulitlevel.yaml"

test/integration/targets/nxos_config/tests/cli/save.yaml

@@ -0,0 +1,35 @@
+---
+- debug: msg="START cli/save.yaml"
+
+- name: setup
+  nxos_config:
+    commands:
+      - no description
+      - no shutdown
+    parents:
+      - interface Ethernet2/5
+    match: none
+    provider: "{{ cli }}"
+
+
+- name: save config
+  nxos_config:
+    save: true
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == true"
+
+- name: save should always run
+  nxos_config:
+    save: true
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == true"
+
+- debug: msg="END cli/save.yaml"

test/integration/targets/nxos_config/tests/cli/src_basic.yaml

@@ -0,0 +1,38 @@
+---
+- debug: msg="START cli/src_basic.yaml"
+
+- name: setup
+  nxos_config:
+    commands:
+      - no description
+      - no shutdown
+    parents:
+      - interface Ethernet2/5
+    match: none
+    provider: "{{ cli }}"
+
+- name: configure device with config
+  nxos_config:
+    src: basic/config.j2
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == true"
+# https://github.com/ansible/ansible-modules-core/issues/4807
+      - "result.updates is not defined"
+
+- name: check device with config
+  nxos_config:
+    src: basic/config.j2
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == false"
+# https://github.com/ansible/ansible-modules-core/issues/4807
+      - "result.updates is not defined"
+
+- debug: msg="END cli/src_basic.yaml"

test/integration/targets/nxos_config/tests/cli/src_invalid.yaml

@@ -0,0 +1,19 @@
+---
+- debug: msg="START cli/src_invalid.yaml"
+
+
+# Defend https://github.com/ansible/ansible-modules-core/issues/4797
+- name: configure with invalid src
+  nxos_config:
+    src: basic/foobar.j2
+    provider: "{{ cli }}"
+  register: result
+  ignore_errors: yes
+
+- assert:
+    that:
+      - "result.changed == false"
+      - "result.failed == true"
+      - "result.msg == 'path specified in src not found'"
+
+- debug: msg="END cli/src_invalid.yaml"

test/integration/targets/nxos_config/tests/cli/src_match_none.yaml

@@ -0,0 +1,40 @@
+---
+- debug: msg="START cli/src_match_none.yaml"
+
+- name: setup
+  nxos_config:
+    commands:
+      - no description
+      - no shutdown
+    parents:
+      - interface Ethernet2/5
+    match: none
+    provider: "{{ cli }}"
+
+- name: configure device with config
+  nxos_config:
+    src: basic/config.j2
+    provider: "{{ cli }}"
+    match: none
+  register: result
+
+- assert:
+    that:
+      - "result.changed == true"
+# Defend https://github.com/ansible/ansible-modules-core/issues/4807
+      - "result.updates is not defined"
+
+- name: check device with config
+  nxos_config:
+    src: basic/config.j2
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      # Idempotent test
+# Defend https://github.com/ansible/ansible-modules-core/issues/4807
+      - "result.changed == false"
+      - "result.updates is not defined"
+
+- debug: msg="END cli/src_match_none.yaml"

test/integration/targets/nxos_config/tests/cli/sublevel.yaml

@@ -0,0 +1,40 @@
+---
+- debug: msg='START cli/sublevel.yaml'
+
+- name: setup
+  nxos_config:
+    lines: no ip access-list test
+    provider: "{{ cli }}"
+    match: none
+
+- name: configure sub level command
+  nxos_config:
+    lines: 10 permit ip any any log
+    parents: ip access-list test
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == true"
+      - "'ip access-list test' in result.updates"
+      - "'10 permit ip any any log' in result.updates"
+
+- name: configure sub level command idempotent check
+  nxos_config:
+    lines: 10 permit ip any any log
+    parents: ip access-list test
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == false"
+
+- name: teardown
+  nxos_config:
+    lines: no ip access-list test
+    provider: "{{ cli }}"
+    match: none
+
+- debug: msg='END cli/sublevel.yaml'

test/integration/targets/nxos_config/tests/cli/sublevel_block.yaml

@@ -0,0 +1,57 @@
+---
+- debug: msg='START cli/sublevel_block.yaml'
+
+- name: setup
+  nxos_config:
+    lines:
+      - 10 permit ip 1.1.1.1/32 any log
+      - 20 permit ip 2.2.2.2/32 any log
+      - 30 permit ip 3.3.3.3/32 any log
+    parents: ip access-list test
+    provider: "{{ cli }}"
+    match: none
+
+- name: configure sub level command using block resplace
+  nxos_config:
+    lines:
+      - 10 permit ip 1.1.1.1/32 any log
+      - 20 permit ip 2.2.2.2/32 any log
+      - 30 permit ip 3.3.3.3/32 any log
+      - 40 permit ip 4.4.4.4/32 any log
+    parents: ip access-list test
+    replace: block
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == true"
+      - "'ip access-list test' in result.updates"
+      - "'10 permit ip 1.1.1.1/32 any log' in result.updates"
+      - "'20 permit ip 2.2.2.2/32 any log' in result.updates"
+      - "'30 permit ip 3.3.3.3/32 any log' in result.updates"
+      - "'40 permit ip 4.4.4.4/32 any log' in result.updates"
+
+- name: check sub level command using block replace
+  nxos_config:
+    lines:
+      - 10 permit ip 1.1.1.1/32 any log
+      - 20 permit ip 2.2.2.2/32 any log
+      - 30 permit ip 3.3.3.3/32 any log
+      - 40 permit ip 4.4.4.4/32 any log
+    parents: ip access-list test
+    replace: block
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == false"
+
+- name: teardown
+  nxos_config:
+    lines: no ip access-list test
+    provider: "{{ cli }}"
+    match: none
+
+- debug: msg='END cli/sublevel_block.yaml'

test/integration/targets/nxos_config/tests/cli/sublevel_exact.yaml

@@ -0,0 +1,62 @@
+---
+- debug: msg='START cli/sublevel_exact.yaml'
+
+- name: setup
+  nxos_config:
+    commands:
+      - 10 permit ip 1.1.1.1/32 any log
+      - 20 permit ip 2.2.2.2/32 any log
+      - 30 permit ip 3.3.3.3/32 any log
+      - 40 permit ip 4.4.4.4/32 any log
+      - 50 permit ip 5.5.5.5/32 any log
+    parents: ip access-list test
+    before: no ip access-list test
+    provider: "{{ cli }}"
+    match: none
+
+- name: configure sub level command using exact match
+  nxos_config:
+    commands:
+      - 10 permit ip 1.1.1.1/32 any log
+      - 20 permit ip 2.2.2.2/32 any log
+      - 30 permit ip 3.3.3.3/32 any log
+      - 40 permit ip 4.4.4.4/32 any log
+    parents: ip access-list test
+    match: exact
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == true"
+      - "'ip access-list test' in result.updates"
+      - "'10 permit ip 1.1.1.1/32 any log' in result.updates"
+      - "'20 permit ip 2.2.2.2/32 any log' in result.updates"
+      - "'30 permit ip 3.3.3.3/32 any log' in result.updates"
+      - "'40 permit ip 4.4.4.4/32 any log' in result.updates"
+      - "'50 permit ip 5.5.5.5/32 any log' not in result.updates"
+
+- name: check sub level command using exact match
+  nxos_config:
+    lines:
+      - 10 permit ip 1.1.1.1/32 any log
+      - 20 permit ip 2.2.2.2/32 any log
+      - 30 permit ip 3.3.3.3/32 any log
+      - 40 permit ip 4.4.4.4/32 any log
+      - 50 permit ip 5.5.5.5/32 any log
+    parents: ip access-list test
+    match: exact
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == false"
+
+- name: teardown
+  nxos_config:
+    lines: no ip access-list test
+    provider: "{{ cli }}"
+    match: none
+
+- debug: msg='END cli/sublevel_exact.yaml'

test/integration/targets/nxos_config/tests/cli/sublevel_strict.yaml

@@ -0,0 +1,63 @@
+---
+- debug: msg='START cli/sublevel_strict.yaml'
+
+- name: setup
+  nxos_config:
+    commands:
+      - 10 permit ip 1.1.1.1/32 any log
+      - 20 permit ip 2.2.2.2/32 any log
+      - 30 permit ip 3.3.3.3/32 any log
+      - 40 permit ip 4.4.4.4/32 any log
+      - 50 permit ip 5.5.5.5/32 any log
+    parents: ip access-list test
+    before: no ip access-list test
+    provider: "{{ cli }}"
+    match: none
+
+- name: configure sub level command using strict match
+  nxos_config:
+    lines:
+      - 10 permit ip 1.1.1.1/32 any log
+      - 30 permit ip 3.3.3.3/32 any log
+      - 20 permit ip 2.2.2.2/32 any log
+      - 40 permit ip 4.4.4.4/32 any log
+    parents: ip access-list test
+    before: no ip access-list test
+    match: strict
+    replace: block
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == true"
+      - "'ip access-list test' in result.updates"
+      - "'10 permit ip 1.1.1.1/32 any log' in result.updates"
+      - "'20 permit ip 2.2.2.2/32 any log' in result.updates"
+      - "'30 permit ip 3.3.3.3/32 any log' in result.updates"
+      - "'40 permit ip 4.4.4.4/32 any log' in result.updates"
+      - "'50 permit ip 5.5.5.5/32 any log' not in result.updates"
+
+- name: check sub level command using strict match
+  nxos_config:
+    lines:
+      - 10 permit ip 1.1.1.1/32 any log
+      - 20 permit ip 2.2.2.2/32 any log
+      - 30 permit ip 3.3.3.3/32 any log
+      - 40 permit ip 4.4.4.4/32 any log
+    parents: ip access-list test
+    match: strict
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == false"
+
+- name: teardown
+  nxos_config:
+    commands: no ip access-list test
+    provider: "{{ cli }}"
+    match: none
+
+- debug: msg='END cli/sublevel_strict.yaml'

test/integration/targets/nxos_config/tests/cli/toplevel.yaml

@@ -0,0 +1,37 @@
+---
+- debug: msg='START cli/toplevel.yaml'
+
+- name: setup
+  nxos_config:
+    lines: hostname {{ inventory_hostname }}
+    provider: "{{ cli }}"
+    match: none
+
+- name: configure top level command
+  nxos_config:
+    lines: hostname foo
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == true"
+      - "'hostname foo' in result.updates"
+
+- name: configure top level command idempotent check
+  nxos_config:
+    lines: hostname foo
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == false"
+
+- name: teardown
+  nxos_config:
+    lines: hostname {{ inventory_hostname }}
+    provider: "{{ cli }}"
+    match: none
+
+- debug: msg='END cli/toplevel.yaml'

test/integration/targets/nxos_config/tests/cli/toplevel_after.yaml

@@ -0,0 +1,44 @@
+---
+- debug: msg='START cli/toplevel_after.yaml'
+
+- name: setup
+  nxos_config:
+    lines:
+      - "snmp-server contact ansible"
+      - "hostname {{ inventory_hostname }}"
+    provider: "{{ cli }}"
+    match: none
+
+- name: configure top level command with before
+  nxos_config:
+    lines: hostname foo
+    after: snmp-server contact bar
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == true"
+      - "'hostname foo' in result.updates"
+      - "'snmp-server contact bar' in result.updates"
+
+- name: configure top level command with before idempotent check
+  nxos_config:
+    lines: hostname foo
+    after: snmp-server contact foo
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == false"
+
+- name: teardown
+  nxos_config:
+    lines:
+      - "no snmp-server contact"
+      - "hostname {{ inventory_hostname }}"
+    provider: "{{ cli }}"
+    match: none
+
+- debug: msg='END cli/toplevel_after.yaml'

test/integration/targets/nxos_config/tests/cli/toplevel_before.yaml

@@ -0,0 +1,44 @@
+---
+- debug: msg='START cli/toplevel_before.yaml'
+
+- name: setup
+  nxos_config:
+    lines:
+      - "snmp-server contact ansible"
+      - "hostname {{ inventory_hostname }}"
+    provider: "{{ cli }}"
+    match: none
+
+- name: configure top level command with before
+  nxos_config:
+    lines: hostname foo
+    before: snmp-server contact bar
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == true"
+      - "'hostname foo' in result.updates"
+      - "'snmp-server contact bar' in result.updates"
+
+- name: configure top level command with before idempotent check
+  nxos_config:
+    lines: hostname foo
+    before: snmp-server contact foo
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == false"
+
+- name: teardown
+  nxos_config:
+    lines:
+      - "no snmp-server contact"
+      - "hostname {{ inventory_hostname }}"
+    provider: "{{ cli }}"
+    match: none
+
+- debug: msg='END cli/toplevel_before.yaml'

test/integration/targets/nxos_config/tests/cli/toplevel_nonidempotent.yaml

@@ -0,0 +1,39 @@
+---
+- debug: msg="START cli/nonidempotent.yaml"
+
+- name: setup
+  nxos_config:
+    lines: hostname {{ inventory_hostname }}
+    provider: "{{ cli }}"
+    match: none
+
+- name: configure top level command
+  nxos_config:
+    lines: hostname foo
+    provider: "{{ cli }}"
+    match: strict
+  register: result
+
+- assert:
+    that:
+      - "result.changed == true"
+      - "'hostname foo' in result.updates"
+
+- name: configure top level command idempotent check
+  nxos_config:
+    lines: hostname foo
+    provider: "{{ cli }}"
+    match: strict
+  register: result
+
+- assert:
+    that:
+      - "result.changed == true"
+
+- name: teardown
+  nxos_config:
+    lines: hostname {{ inventory_hostname }}
+    provider: "{{ cli }}"
+    match: none
+
+- debug: msg="END cli/nonidempotent.yaml"