internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-08 14:22:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

[PR #10455/bd84f654 backport][stable-10] Improve capabilities module by detecting /sbin/getcap error message and stop early with a meaningful error message (#10562)

Browse Source 
Improve capabilities module by detecting /sbin/getcap error message and stop early with a meaningful error message (#10455)

* modules/capabilities.py: fail & propagate if getcap command error

* Fix comment spacing (pep8)

* Add changelogs fragment for PR 10455

* Update changelogs/fragments/10455-capabilities-improve-error-detection.yml



---------



(cherry picked from commit bd84f65456)

Co-authored-by: hakril <github@hakril.net>
Co-authored-by: clement rouault <clement.rouault@exatrack.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
patchback[bot]
2025-08-02 17:30:10 +02:00
committed by GitHub
parent 69563766ec
commit ddbfbcb47e
2 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
changelogs/fragments/10455-capabilities-improve-error-detection.yml Normal file
View File

@@ -0,0 +1,2 @@
bugfixes:
- capabilities - using invalid path (symlink/directory/...) returned unrelated and incoherent error messages (https://github.com/ansible-collections/community.general/issues/5649, https://github.com/ansible-collections/community.general/pull/10455).

2
plugins/modules/capabilities.py
View File

@@ -123,6 +123,8 @@ class CapabilitiesModule(object):
if ' =' in stdout: if ' =' in stdout:
# process output of an older version of libcap # process output of an older version of libcap
caps = stdout.split(' =')[1].strip().split() caps = stdout.split(' =')[1].strip().split()
elif stdout.strip().endswith(")"): # '/foo (Error Message)'
self.module.fail_json(msg="Unable to get capabilities of %s" % path, stdout=stdout.strip(), stderr=stderr)
else: else:
# otherwise, we have a newer version here # otherwise, we have a newer version here
# see original commit message of cap/v0.2.40-18-g177cd41 in libcap.git # see original commit message of cap/v0.2.40-18-g177cd41 in libcap.git