Refactoring code of cnos_portchannel as cnos_linkagg in tune with other vendors. (#49467)

* Refactoring code of cnos_portchannel as cnos_linkagg in tune with other vendors.
This commit is contained in:
Anil Kumar Muraleedharan
2018-12-05 21:33:42 +05:30
committed by Nathaniel Case
parent 287a42eba0
commit dd004321d4
16 changed files with 783 additions and 825 deletions

View File

@@ -0,0 +1,36 @@
!
hostname ip10-241-107-39
!
interface Ethernet1/33
description anil
microburst-detection enable threshold 25
lldp tlv-select max-frame-size
lacp port-priority 33
!
interface Ethernet1/44
!
interface Ethernet1/10
no switchport
ip address 10.241.108.10/24
vrrp 202
address 10.241.108.20
shutdown
!
interface Ethernet1/11
no switchport
mtu 1402
ip address 1.1.1.2/8
!
interface port-channel20
!
interface port-channel33
description Hentammoo
load-interval counter 2 33
switchport access vlan 33
storm-control broadcast level 12.50
mtu 66
spanning-tree mst 33-35 cost 33
spanning-tree bpduguard enable
!
interface Ethernet1/9
!

View File

@@ -1,25 +0,0 @@
Flags:
D - Down P - Up in port-channel (members)
S - Switched R - Routed
I - Individual s - Suspended
U - Up (port-channel)
B - standBy (members)
------+----------------+--------+-----------------------------------------------
Group Port-Channel Protocol Member Ports
------+----------------+--------+-----------------------------------------------
1 po1 (SD) NONE
2 po2 (SD) NONE
11 po11 (SD) LACP Ethernet1/23(D)
12 po12 (SD) NONE
13 po13 (SD) NONE
14 po14 (SD) NONE
15 po15 (SD) NONE
17 po17 (SD) NONE
20 po20 (SD) NONE
33 po33 (SD) NONE Ethernet1/1(D)
100 po100 (SD) NONE
1001 po1001 (SD) LACP Ethernet1/2(D)
1002 po1002 (SD) NONE
1003 po1003 (SD) LACP Ethernet1/3(D)
1004 po1004 (SD) LACP Ethernet1/4(D)

View File

@@ -0,0 +1,147 @@
#
# (c) 2018 Red Hat Inc.
# Copyright (C) 2017 Lenovo.
#
# This file is part of Ansible
#
# Ansible is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# Ansible is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Ansible. If not, see <http://www.gnu.org/licenses/>.
#
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
import re
import json
from units.compat.mock import patch
from ansible.modules.network.cnos import cnos_linkagg
from units.modules.utils import set_module_args
from .cnos_module import TestCnosModule, load_fixture
class TestCnosLinkaggModule(TestCnosModule):
module = cnos_linkagg
def setUp(self):
super(TestCnosLinkaggModule, self).setUp()
self._patch_get_config = patch(
'ansible.modules.network.cnos.cnos_linkagg.get_config'
)
self._patch_load_config = patch(
'ansible.modules.network.cnos.cnos_linkagg.load_config'
)
self._get_config = self._patch_get_config.start()
self._load_config = self._patch_load_config.start()
def tearDown(self):
super(TestCnosLinkaggModule, self).tearDown()
self._patch_get_config.stop()
self._patch_load_config.stop()
def load_fixtures(self, commands=None):
config_file = 'cnos_linkagg_config.cfg'
self._get_config.return_value = load_fixture(config_file)
self._load_config.return_value = None
def test_cnos_linkagg_group_present(self, *args, **kwargs):
set_module_args(dict(
group='10',
state='present'
))
result = self.execute_module(changed=True)
self.assertEqual(
result,
{
'commands': [
'interface port-channel 10',
'exit'
],
'changed': True
}
)
def test_cnos_linkagg_group_members_active(self, *args, **kwargs):
set_module_args(dict(
group='10',
mode='active',
members=[
'Ethernet 1/33',
'Ethernet 1/44'
]
))
result = self.execute_module(changed=True)
self.assertEqual(
result,
{
'commands': [
'interface port-channel 10',
'exit',
'interface Ethernet 1/33',
'channel-group 10 mode active',
'interface Ethernet 1/44',
'channel-group 10 mode active'
],
'changed': True
}
)
def test_cnos_linkagg_group_member_removal(self, *args, **kwargs):
set_module_args(dict(
group='20',
mode='active',
members=[
'Ethernet 1/10',
]
))
result = self.execute_module(changed=True)
self.assertEqual(
result,
{
'commands': [
'interface port-channel 20',
'exit',
'interface Ethernet 1/10',
'channel-group 20 mode active'
],
'changed': True
}
)
def test_cnos_linkagg_group_members_absent(self, *args, **kwargs):
set_module_args(dict(
group='20',
state='absent'
))
result = self.execute_module(changed=True)
self.assertEqual(
result,
{
'commands': [
'no interface port-channel 20'
],
'changed': True
}
)
set_module_args(dict(
group='10',
state='absent'
))
result = self.execute_module(changed=False)
self.assertEqual(
result,
{
'commands': [],
'changed': False
}
)

View File

@@ -1,84 +0,0 @@
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
import json
import os
from units.compat.mock import patch
from ansible.modules.network.cnos import cnos_portchannel
from units.modules.utils import set_module_args
from .cnos_module import TestCnosModule, load_fixture
class TestCnosPortchannelModule(TestCnosModule):
module = cnos_portchannel
def setUp(self):
super(TestCnosPortchannelModule, self).setUp()
self.mock_run_cnos_commands = patch('ansible.module_utils.network.cnos.cnos.run_cnos_commands')
self.run_cnos_commands = self.mock_run_cnos_commands.start()
def tearDown(self):
super(TestCnosPortchannelModule, self).tearDown()
self.mock_run_cnos_commands.stop()
def load_fixtures(self, commands=None, transport='cli'):
self.run_cnos_commands.return_value = [load_fixture('cnos_portchannel_config.cfg')]
def test_portchannel_channelgroup(self):
set_module_args({'username': 'admin', 'password': 'pass',
'host': '10.241.107.39', 'deviceType': 'g8272_cnos',
'outputfile': self.test_log, 'interfaceRange': '33',
'interfaceArg1': 'channel-group', 'interfaceArg2': '33', 'interfaceArg3': 'on'})
result = self.execute_module(changed=True)
expected_result = 'Port Channel Configuration is done'
self.assertEqual(result['msg'], expected_result)
def test_cnos_portchannel_lacp(self):
set_module_args({'username': 'admin', 'password': 'pass',
'host': '10.241.107.39', 'deviceType': 'g8272_cnos',
'outputfile': self.test_log, 'interfaceRange': '33',
'interfaceArg1': 'lacp', 'interfaceArg2': 'port-priority', 'interfaceArg3': '33'})
result = self.execute_module(changed=True)
expected_result = 'Port Channel Configuration is done'
self.assertEqual(result['msg'], expected_result)
def test_cnos_portchannel_duplex(self):
set_module_args({'username': 'admin', 'password': 'pass',
'host': '10.241.107.39', 'deviceType': 'g8272_cnos',
'outputfile': self.test_log, 'interfaceRange': '2',
'interfaceArg1': 'duplex', 'interfaceArg2': 'auto'})
result = self.execute_module(changed=True)
expected_result = 'Port Channel Configuration is done'
self.assertEqual(result['msg'], expected_result)
def test_cnos_portchannel_mtu(self):
set_module_args({'username': 'admin', 'password': 'pass',
'host': '10.241.107.39', 'deviceType': 'g8272_cnos',
'outputfile': self.test_log, 'interfaceRange': '33',
'interfaceArg1': 'mtu', 'interfaceArg2': '1300'})
result = self.execute_module(changed=True)
expected_result = 'Port Channel Configuration is done'
self.assertEqual(result['msg'], expected_result)
def test_cnos_portchannel_spanningtree(self):
set_module_args({'username': 'admin', 'password': 'pass',
'host': '10.241.107.39', 'deviceType': 'g8272_cnos',
'outputfile': self.test_log, 'interfaceRange': '33',
'interfaceArg1': 'spanning-tree', 'interfaceArg2': 'mst',
'interfaceArg3': '33-35', 'interfaceArg4': 'cost',
'interfaceArg5': '33'})
result = self.execute_module(changed=True)
expected_result = 'Port Channel Configuration is done'
self.assertEqual(result['msg'], expected_result)
def test_cnos_portchannel_ip(self):
set_module_args({'username': 'admin', 'password': 'pass',
'host': '10.241.107.39', 'deviceType': 'g8272_cnos',
'outputfile': self.test_log, 'interfaceRange': '33',
'interfaceArg1': 'ip', 'interfaceArg2': 'port',
'interfaceArg3': 'anil'})
result = self.execute_module(changed=True)
expected_result = 'Port Channel Configuration is done'
self.assertEqual(result['msg'], expected_result)