internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-02 19:32:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

lvol: fix thin-pool creation with percentage size (#11925)

Browse Source 
* fix(lvol): use --extents (-l) for thin-pool creation with percentage size

Fixes #11923

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* chore(lvol): add changelog fragment for #11925

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* test(lvol): add integration tests for thin-pool creation with percentage sizes

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* test(lvol): use extent-aligned size for thin-pool absolute-size idempotency test

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* test(lvol): reduce thin-pool sizes to leave space for test_pvs.yml

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* test(lvol): add shrink=false to thin-pool absolute-size idempotency check

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* test(lvol): add shrink: false to thin volume idempotency test

LVM reports thin volume size slightly above requested (metadata overhead),
triggering spurious shrink attempts. Disable shrink for idempotency checks
to avoid false failures.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Alexei Znamensky
2026-04-29 21:55:47 +12:00
committed by GitHub
parent c0d3464fa7
commit d0f0e9d00f
4 changed files with 125 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
plugins/modules/lvol.py
View File

@@ -505,15 +505,26 @@ def main():
vg=[f"{vg}/{thinpool}"],
)
else:
with lvcreate("test yes size_L opts thin vg pvs") as ctx:
rc, dummy, err = ctx.run(
test=module.check_mode,
yes=use_yes,
size_L=size_value,
opts=opts,
vg=[f"{vg}/{thinpool}"],
pvs=pvs,
)
if size_opt == "l":
with lvcreate("test yes size_l opts thin vg pvs") as ctx:
rc, dummy, err = ctx.run(
test=module.check_mode,
yes=use_yes,
size_l=size_value,
opts=opts,
vg=[f"{vg}/{thinpool}"],
pvs=pvs,
)
else:
with lvcreate("test yes size_L opts thin vg pvs") as ctx:
rc, dummy, err = ctx.run(
test=module.check_mode,
yes=use_yes,
size_L=size_value,
opts=opts,
vg=[f"{vg}/{thinpool}"],
pvs=pvs,
)
else:
if size_opt == "l":
with lvcreate("test yes lv size_l opts vg pvs") as ctx: