Lenovo cnos l2interface (#50641)

* Adding cnos_l2 interface module and its associated Integration test as well as Unit test code
This commit is contained in:
Anil Kumar Muraleedharan
2019-01-09 21:16:56 +05:30
committed by Nathaniel Case
parent f5ebd9736c
commit cb89b1758d
16 changed files with 1214 additions and 0 deletions

View File

@@ -0,0 +1,2 @@
# No Lenovo Switch simulator yet, so not enabled
unsupported

View File

@@ -0,0 +1,14 @@
# You have to paste this dummy information in /etc/ansible/hosts
# Notes:
# - Comments begin with the '#' character
# - Blank lines are ignored
# - Groups of hosts are delimited by [header] elements
# - You can enter hostnames or ip addresses
# - A hostname/ip can be a member of multiple groups
#
# In the /etc/ansible/hosts file u have to enter [cnos_l2_interface_sample] tag
# Following you should specify IP Adresses details
# Please change <username> and <password> with appropriate value for your switch.
[cnos_l2_interface_sample]
10.241.107.39 ansible_network_os=cnos ansible_ssh_user=admin ansible_ssh_pass=admin deviceType=g8272_cnos test_interface=ethernet1/33 test_interface2=ethernet1/44

View File

@@ -0,0 +1,2 @@
---
testcase: "*"

View File

@@ -0,0 +1,24 @@
---
- name: collect all cli test cases
find:
paths: "{{ role_path }}/tests/cli"
patterns: "{{ testcase }}.yaml"
register: test_cases
delegate_to: localhost
- name: set test_items
set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"
- name: run test cases (connection=network_cli)
include: "{{ test_case_to_run }}"
with_items: "{{ test_items }}"
loop_control:
loop_var: test_case_to_run
- name: run test case (connection=local)
include: "{{ test_case_to_run }} ansible_connection=local"
with_first_found:
- files: "{{ test_items|default([]) }}"
skip: true
loop_control:
loop_var: test_case_to_run

View File

@@ -0,0 +1,5 @@
---
- { include: cli.yaml, tags: ['cli'] }
#- block:
# - { include: cli.yaml, tags: ['cli'] }
# when: 'switch_type == "L2"'

View File

@@ -0,0 +1,81 @@
---
- debug: msg="START connection={{ ansible_connection }} cnos_l2_interface aggregate test"
- name: Setup - Ensure interfaces are switchport
cnos_config:
lines:
- switchport
parents:
- "interface {{ item }}"
loop:
- "{{ test_interface }}"
- "{{ test_interface2 }}"
- name: "Setup vlans"
cnos_vlan:
aggregate:
- vlan_id: 6
- vlan_id: 15
provider: "{{ cli }}"
- name: Setup - Remove interface aggregate before testing
cnos_l2_interface:
aggregate:
- { name: "{{ test_interface }}", mode: access, access_vlan: 6 }
- { name: "{{ test_interface2 }}", mode: access, access_vlan: 15 }
state: absent
provider: "{{ cli }}"
- block:
- name: Configure interface for access_vlan aggregate
cnos_l2_interface: &conf_agg
aggregate:
- { name: "{{ test_interface }}", mode: access, access_vlan: 6 }
- { name: "{{ test_interface2 }}", mode: access, access_vlan: 15 }
provider: "{{ cli }}"
register: result
- assert:
that:
- "result.changed == true"
- name: Configure interface for access_vlan aggregate(Idempotence)
cnos_l2_interface: *conf_agg
register: result
- assert:
that:
- "result.changed == false"
- name: Remove interface aggregate
cnos_l2_interface: &rm_agg
aggregate:
- { name: "{{ test_interface }}", mode: access, access_vlan: 6 }
- { name: "{{ test_interface2 }}", mode: access, access_vlan: 15 }
provider: "{{ cli }}"
state: absent
register: result
- assert:
that:
- "result.changed == true"
- name: Remove interface aggregate(Idempotence)
cnos_l2_interface: *rm_agg
register: result
- assert:
that:
- "result.changed == false"
always:
- name: "remove vlans"
cnos_vlan:
aggregate:
- vlan_id: 6
- vlan_id: 15
state: absent
provider: "{{ cli }}"
ignore_errors: yes
- debug: msg="END connection={{ ansible_connection }} cnos_l2_interface aggregate test"

View File

@@ -0,0 +1,168 @@
---
- debug: msg="START connection={{ ansible_connection }} cnos_l2_interface sanity test"
- name: "Setup interface"
cnos_config: &default
lines:
- "interface {{ test_interface }}"
provider: "{{ cli }}"
#- name: set trunk encapsulation type
# cnos_config:
# lines:
# - switchport trunk encapsulation dot1q
# parents:
# - "interface {{ test_interface }}"
# provider: "{{ cli }}"
- name: "Setup vlans"
cnos_vlan:
aggregate:
- vlan_id: 5
- vlan_id: 6
- vlan_id: 7
- vlan_id: 8
- vlan_id: 9
- vlan_id: 10
- vlan_id: 20
provider: "{{ cli }}"
- block:
- name: Ensure interface is in its default switchport state
cnos_l2_interface: &def_swi
name: "{{ test_interface }}"
state: unconfigured
provider: "{{ cli }}"
- name: Ensure interface is configured for access vlan 20
cnos_l2_interface: &acc_vl
name: "{{ test_interface }}"
mode: access
access_vlan: 20
provider: "{{ cli }}"
register: result
- assert: &true
that:
- "result.changed == true"
- name: "access vlan Idempotence"
cnos_l2_interface: *acc_vl
register: result
- assert: &false
that:
- "result.changed == false"
- name: Ensure interface only has vlans 5-10 as trunk vlans
cnos_l2_interface: &tr_vl
name: "{{ test_interface }}"
mode: trunk
native_vlan: 10
trunk_allowed_vlans: 5-10
provider: "{{ cli }}"
register: result
- assert: *true
- name: "trunk vlan Idempotence"
cnos_l2_interface: *tr_vl
register: result
- assert: *false
- name: Ensure interface is a trunk port and ensure 2-50 are being tagged (doesn't mean others aren't also being tagged)
cnos_l2_interface: &tag
name: "{{ test_interface }}"
mode: trunk
native_vlan: 10
trunk_vlans: 2-50
provider: "{{ cli }}"
register: result
- assert: *true
- name: "tag vlan Idempotence"
cnos_l2_interface: *tag
register: result
- assert: *true
- name: Remove full trunk vlan range 2-50
cnos_l2_interface: &no_tag
name: "{{ test_interface }}"
mode: trunk
trunk_vlans: 2-50
state: absent
provider: "{{ cli }}"
register: result
- assert: *true
- name: Check Idempotence Remove full trunk vlan range 2-50
cnos_l2_interface: *no_tag
register: result
- assert: *false
- name: Reconfigure interface trunk port and ensure 2-50 are being tagged
cnos_l2_interface: *tag
register: result
- assert: *true
- name: Check Idempotence Reconfigure interface trunk port and ensure 2-50 are being tagged
cnos_l2_interface: *tag
register: result
- assert: *true
- name: Remove partial trunk vlan range 30-4094 are removed
cnos_l2_interface: &partial
name: "{{ test_interface }}"
mode: trunk
trunk_vlans: 30-4094
state: absent
provider: "{{ cli }}"
register: result
- assert: *false
- name: Check Idempotence Remove partial trunk vlan range 30-4094 are removed
cnos_l2_interface: *partial
register: result
- assert: *false
- name: put interface default state
cnos_l2_interface: *def_swi
register: result
- assert: *true
- name: "default state idempotence"
cnos_l2_interface: *def_swi
register: result
- assert: *true
always:
- name: "remove vlans"
cnos_vlan:
aggregate:
- vlan_id: 5
- vlan_id: 6
- vlan_id: 7
- vlan_id: 8
- vlan_id: 9
- vlan_id: 10
- vlan_id: 20
state: absent
provider: "{{ cli }}"
ignore_errors: yes
- name: "default interface"
cnos_config: *default
ignore_errors: yes
- debug: msg="END connection={{ ansible_connection }} cnos_l2_interface sanity test"

View File

@@ -0,0 +1,9 @@
---
cli:
host: "{{ inventory_hostname }}"
port: 22
username: admin
password: admin
timeout: 30
authorize: True
auth_pass:

View File

@@ -0,0 +1,13 @@
Interface Ethernet1/33
Switchport : enabled
Switchport mode : access
Ingress filter : enable
Tag Ingress PVID : disabled
Acceptable frame types : all
Default/Native Vlan : 1
Configured Vlans : 1
Enabled Vlans : 1
Egress-Tagged Vlans : None
Private-VLAN : Disabled
Private-VLAN Port Type : None
Primary/Secondary VLAN : None/None

View File

@@ -0,0 +1,14 @@
Interface Ethernet1/45
Switchport : enabled
Switchport mode : access
Ingress filter : enable
Tag Ingress PVID : disabled
Acceptable frame types : all
Default/Native Vlan : 1
Configured Vlans : 1
Enabled Vlans : 1
Egress-Tagged Vlans : None
Private-VLAN : Disabled
Private-VLAN Port Type : None
Primary/Secondary VLAN : None/None

View File

@@ -0,0 +1,13 @@
Interface Ethernet1/33
Switchport : enabled
Switchport mode : access
Ingress filter : enable
Tag Ingress PVID : disabled
Acceptable frame types : all
Default/Native Vlan : 1
Configured Vlans : 1
Enabled Vlans : 1
Egress-Tagged Vlans : None
Private-VLAN : Disabled
Private-VLAN Port Type : None
Primary/Secondary VLAN : None/None

View File

@@ -0,0 +1,14 @@
Interface Ethernet1/45
Switchport : enabled
Switchport mode : access
Ingress filter : enable
Tag Ingress PVID : disabled
Acceptable frame types : all
Default/Native Vlan : 1
Configured Vlans : 1
Enabled Vlans : 1
Egress-Tagged Vlans : None
Private-VLAN : Disabled
Private-VLAN Port Type : None
Primary/Secondary VLAN : None/None

View File

@@ -0,0 +1,97 @@
VLAN Name Status IPMC FLOOD Ports
======== ================================ ======= ========== ===================
1 default ACTIVE IPv6
po1(u)
po2(u)
po11(u)
po12(u)
po13(t)
po14(u)
po15(u)
po17(t)
po20(u)
po100(t)
po1001(u)
po1002(u)
po1003(t)
po1004(t)
Ethernet1/2(u)
Ethernet1/3(t)
Ethernet1/4(t)
Ethernet1/9(u)
Ethernet1/10(u)
Ethernet1/14(u)
Ethernet1/15(u)
Ethernet1/16(u)
Ethernet1/17(u)
Ethernet1/18(u)
Ethernet1/19(u)
Ethernet1/20(u)
Ethernet1/21(u)
Ethernet1/22(u)
Ethernet1/23(u)
Ethernet1/24(u)
Ethernet1/25(u)
Ethernet1/26(u)
Ethernet1/27(u)
Ethernet1/28(u)
Ethernet1/29(u)
Ethernet1/30(u)
Ethernet1/31(u)
Ethernet1/32(u)
Ethernet1/33(u)
Ethernet1/34(u)
Ethernet1/35(u)
Ethernet1/36(u)
Ethernet1/37(u)
Ethernet1/38(u)
Ethernet1/39(u)
Ethernet1/40(u)
Ethernet1/41(u)
Ethernet1/42(u)
Ethernet1/43(u)
Ethernet1/44(u)
Ethernet1/45(u)
Ethernet1/46(u)
Ethernet1/47(u)
Ethernet1/48(u)
Ethernet1/49(u)
Ethernet1/50(u)
Ethernet1/51(u)
Ethernet1/52(u)
Ethernet1/53(u)
Ethernet1/54(u)
2 VLAN0002 ACTIVE IPv6
po13(t)
po17(t)
po100(t)
po1003(t)
po1004(t)
Ethernet1/3(t)
Ethernet1/4(t)
3 VLAN0003 ACTIVE IPv4,IPv6
po13(t)
po17(t)
po100(t)
po1003(t)
po1004(t)
Ethernet1/3(t)
Ethernet1/4(t)
12 VLAN0012 ACTIVE IPv4,IPv6
po13(t)
po17(t)
po100(t)
po1003(t)
po1004(t)
Ethernet1/3(t)
Ethernet1/4(t)
13 anil ACTIVE IPv4,IPv6
po13(t)
po17(t)
po100(t)
po1003(t)
po1004(t)
Ethernet1/3(t)
Ethernet1/4(t)

View File

@@ -0,0 +1,158 @@
#
# (c) 2018 Lenovo.
#
# This file is part of Ansible
#
# Ansible is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# Ansible is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Ansible. If not, see <http://www.gnu.org/licenses/>.
#
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
import re
import json
from units.compat.mock import patch
from ansible.modules.network.cnos import cnos_l2_interface
from units.modules.utils import set_module_args
from .cnos_module import TestCnosModule, load_fixture
class TestCnosL2InterfaceModule(TestCnosModule):
module = cnos_l2_interface
def setUp(self):
super(TestCnosL2InterfaceModule, self).setUp()
self._patch_get_config = patch(
'ansible.modules.network.cnos.cnos_l2_interface.get_config'
)
self._patch_load_config = patch(
'ansible.modules.network.cnos.cnos_l2_interface.load_config'
)
self._patch_run_commands = patch(
'ansible.modules.network.cnos.cnos_l2_interface.run_commands'
)
self._get_config = self._patch_get_config.start()
self._load_config = self._patch_load_config.start()
self._run_commands = self._patch_run_commands.start()
self._run_commands.side_effect = self.run_commands_load_fixtures
def run_commands_load_fixtures(self, module, commands, *args, **kwargs):
return self.load_fixtures(
commands,
destination=self._run_commands,
return_values=True
)
def tearDown(self):
super(TestCnosL2InterfaceModule, self).tearDown()
self._patch_get_config.stop()
self._patch_load_config.stop()
self._patch_run_commands.stop()
def load_fixtures(self, commands=None,
destination=None, return_values=False):
side_effects = []
if not destination:
destination = self._get_config
if not commands:
commands = ['cnos_config_config.cfg']
for command in commands:
filename = str(command).replace(' ', '_')
filename = str(filename).replace('/', '_')
side_effects.append(load_fixture(filename))
if return_values is True:
return side_effects
destination.side_effect = side_effects
return None
def test_cnos_l2_interface_access_vlan(self, *args, **kwargs):
set_module_args(dict(
name='Ethernet 1/33',
mode='access',
access_vlan=13,
))
result = self.execute_module(changed=True)
self.assertEqual(
result,
{
'commands': [
'interface ethernet 1/33',
'switchport access vlan 13'
],
'changed': True,
'warnings': []
}
)
def test_cnos_l2_interface_vlan_does_not_exist(self, *args, **kwargs):
set_module_args(dict(
name='Ethernet 1/33',
mode='access',
access_vlan=10,
))
result = self.execute_module(failed=True)
self.assertEqual(
result,
{
'msg': 'You are trying to configure a VLAN on an interface '
'that\ndoes not exist on the switch yet!',
'failed': True,
'vlan': '10'
}
)
def test_cnos_l2_interface_incorrect_state(self, *args, **kwargs):
set_module_args(dict(
name='Ethernet 1/44',
mode='access',
access_vlan=10,
))
result = self.execute_module(failed=True)
self.assertEqual(
result,
{
'msg': 'Ensure interface is configured to be a L2\nport first '
'before using this module. You can use\nthe cnos_'
'interface module for this.',
'failed': True
}
)
def test_cnos_l2_interface_trunk(self, *args, **kwargs):
set_module_args(dict(
name='Ethernet 1/45',
mode='trunk',
native_vlan='12',
trunk_allowed_vlans='13,12'
))
result = self.execute_module(changed=True)
self.assertEqual(
result,
{
'commands': [
'interface ethernet 1/45',
'switchport mode trunk',
'switchport trunk allowed vlan 13,12',
'switchport trunk native vlan 12'
],
'changed': True,
'warnings': []
}
)