ios integration tests to network_cli (#33920)

* Preliminary steps

* Fix Python3 network_cli ios

* Add connection to debug strings

* Fix ios confirm prompt by way of optional newline

Also update ios_user delete tests

test/integration/targets/ios_interface/tasks/cli.yaml

@@ -4,12 +4,19 @@
     paths: "{{ role_path }}/tests/cli"
     patterns: "{{ testcase }}.yaml"
   register: test_cases
+  delegate_to: localhost
 
 - name: set test_items
   set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"
 
-- name: run test case
-  include: "{{ test_case_to_run }}"
+- name: run test cases (connection=network_cli)
+  include: "{{ test_case_to_run }} ansible_connection=network_cli"
   with_items: "{{ test_items }}"
   loop_control:
     loop_var: test_case_to_run
+
+- name: run test case (connection=local)
+  include: "{{ test_case_to_run }} ansible_connection=local ansible_become=no"
+  with_first_found: "{{ test_items }}"
+  loop_control:
+    loop_var: test_case_to_run

test/integration/targets/ios_interface/tests/cli/basic.yaml

@@ -1,10 +1,11 @@
 ---
-- debug: msg="START ios_interface cli/basic.yaml"
+- debug: msg="START ios_interface cli/basic.yaml on connection={{ ansible_connection }}"
 
 - name: Run show version
   ios_command:
     commands: show version
     authorize: yes
+  become: yes
   register: show_version_result
 
 - block:
@@ -23,6 +24,7 @@
           - no negotiation auto
         parents: int GigabitEthernet2
         authorize: yes
+      become: yes
 
     - name: Set test interface 2 to GigabitEthernet3 as we are on Cisco IOS-XE
       set_fact: test_interface2=GigabitEthernet3
@@ -32,6 +34,7 @@
           - no negotiation auto
         parents: int GigabitEthernet3
         authorize: yes
+      become: yes
   when: "'Cisco IOS-XE' in show_version_result.stdout[0]"
 
 - name: Configure interface (setup)
@@ -42,6 +45,7 @@
     mtu: 1800
     state: present
     authorize: yes
+  become: yes
   register: result
 
 - name: Configure interface
@@ -50,6 +54,7 @@
     description: test-interface-initial
     state: present
     authorize: yes
+  become: yes
   register: result
 
 - assert:
@@ -64,6 +69,7 @@
     description: test-interface-initial
     state: present
     authorize: yes
+  become: yes
   register: result
 
 - assert:
@@ -77,6 +83,7 @@
     mtu: 2000
     state: present
     authorize: yes
+  become: yes
   register: result
 
 - assert:
@@ -93,6 +100,7 @@
     mtu: 1800
     state: present
     authorize: yes
+  become: yes
   register: result
 
 - assert:
@@ -107,6 +115,7 @@
     name: "{{ test_interface }}"
     enabled: False
     authorize: yes
+  become: yes
   register: result
 
 - assert:
@@ -120,6 +129,7 @@
     name: "{{ test_interface }}"
     enabled: True
     authorize: yes
+  become: yes
   register: result
 
 - assert:
@@ -136,6 +146,7 @@
     mtu: 1800
     state: present
     authorize: yes
+  become: yes
   register: result
 
 - name: Add interface aggregate
@@ -146,6 +157,7 @@
     speed: 1000
     state: present
     authorize: yes
+  become: yes
   register: result
 
 - assert:
@@ -165,6 +177,7 @@
     speed: 1000
     state: present
     authorize: yes
+  become: yes
   register: result
 
 - assert:
@@ -179,6 +192,7 @@
     enabled: False
     state: present
     authorize: yes
+  become: yes
   register: result
 
 - assert:
@@ -197,6 +211,7 @@
     enabled: True
     state: present
     authorize: yes
+  become: yes
   register: result
 
 - assert:
@@ -214,6 +229,7 @@
     - name: Loopback10
     state: absent
     authorize: yes
+  become: yes
 
 - name: Create loopback interface aggregate
   ios_interface:
@@ -222,6 +238,7 @@
     - name: Loopback10
     state: present
     authorize: yes
+  become: yes
   register: result
 
 - assert:
@@ -237,6 +254,7 @@
     - name: Loopback10
     state: absent
     authorize: yes
+  become: yes
   register: result
 
 - assert:
@@ -252,10 +270,11 @@
     - name: Loopback10
     state: absent
     authorize: yes
+  become: yes
   register: result
 
 - assert:
     that:
       - 'result.changed == false'
 
-- debug: msg="END ios_interface cli/basic.yaml"
+- debug: msg="END ios_interface cli/basic.yaml on connection={{ ansible_connection }}"

test/integration/targets/ios_interface/tests/cli/intent.yaml

@@ -1,10 +1,11 @@
 ---
-- debug: msg="START ios_interface cli/intent.yaml"
+- debug: msg="START ios_interface cli/intent.yaml on connection={{ ansible_connection }}"
 
 - name: Run show version
   ios_command:
     commands: show version
     authorize: yes
+  become: yes
   register: show_version_result
 
 - name: Set test interface to GigabitEthernet0/2 if we are on Cisco IOS
@@ -23,6 +24,7 @@
     tx_rate: ge(0)
     rx_rate: ge(0)
     authorize: yes
+  become: yes
   register: result
 
 - assert:
@@ -36,6 +38,7 @@
     tx_rate: gt(0)
     rx_rate: lt(0)
     authorize: yes
+  become: yes
   ignore_errors: yes
   register: result
 
@@ -52,6 +55,7 @@
     enabled: False
     state: down
     authorize: yes
+  become: yes
   register: result
 
 - assert:
@@ -64,6 +68,7 @@
     enabled: False
     authorize: yes
     state: up
+  become: yes
   ignore_errors: yes
   register: result
 
@@ -77,6 +82,7 @@
     commands:
       - show lldp neighbors
     authorize: yes
+  become: yes
   register: show_lldp_neighbors_result
 
 - block:
@@ -87,6 +93,7 @@
           - port: eth0
             host: netdev
         authorize: yes
+      become: yes
       register: result
 
     - assert:
@@ -100,6 +107,7 @@
           - port: dummy_port
             host: dummy_host
         authorize: yes
+      become: yes
       ignore_errors: yes
       register: result
 
@@ -117,6 +125,7 @@
         enabled: True
         state: up
     authorize: yes
+  become: yes
   ignore_errors: yes
   register: result
 
@@ -133,6 +142,7 @@
               - port: eth0
                 host: netdev
         authorize: yes
+      become: yes
       ignore_errors: yes
       register: result
 
@@ -150,6 +160,7 @@
           - port: dummy_port
             host: dummy_host
         authorize: yes
+      become: yes
       ignore_errors: yes
       register: result