internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-03-26 21:33:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

move imports from functions to the top of the file (#11396)

Browse Source 
* move imports from functions to the top of the file

* add changelog frag

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
Alexei Znamensky
2026-01-08 09:23:03 +13:00
committed by GitHub
parent defd15609c
commit c8356981bb
7 changed files with 21 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
plugins/modules/one_vm.py
View File

@@ -682,8 +682,12 @@ try:
except ImportError:
HAS_PYONE = False
import copy
import os
import re
import time
from collections import namedtuple
from ansible.module_utils.basic import AnsibleModule
from ansible.module_utils.common.dict_transformations import dict_merge
@@ -875,7 +879,6 @@ def get_vm_info(client, vm):
"security_groups": vm.TEMPLATE["NIC"].get("SECURITY_GROUPS", ""),
}
)
import time
current_time = time.localtime()
vm_start_time = time.localtime(vm.STIME)
@@ -1146,8 +1149,6 @@ def get_all_vms_by_attributes(client, attributes_dict, labels_list):
vm_list.append(vm)
pool = vm_list
import copy
vm_list = copy.copy(pool)
for vm in pool:
@@ -1367,8 +1368,6 @@ LCM_STATES = [
def wait_for_state(module, client, vm, wait_timeout, state_predicate):
import time
start_time = time.time()
while (time.time() - start_time) < wait_timeout:
@@ -1551,8 +1550,6 @@ def release_vm(module, client, vm):
def check_name_attribute(module, attributes):
if attributes.get("NAME"):
import re
if re.match(r"^[^#]+#*$", attributes.get("NAME")) is None:
module.fail_json(
msg=f"Illegal 'NAME' attribute: '{attributes.get('NAME')}"
@@ -1638,7 +1635,6 @@ def get_connection_info(module):
module.fail_json(msg=f"Error occurs when read ONE_AUTH file at '{authfile}'")
if not url:
module.fail_json(msg="Opennebula API url (api_url) is not specified")
from collections import namedtuple
auth_params = namedtuple("auth", ("url", "username", "password"))
@@ -1752,8 +1748,6 @@ def main():
if count_attributes:
count_attributes = {key.upper(): value for key, value in count_attributes.items()}
if not attributes:
import copy
module.warn(
"When you pass `count_attributes` without `attributes` option when deploying, `attributes` option will have same values implicitly."
)
@@ -1820,8 +1814,6 @@ def main():
module.fail_json(msg="`count` has to be greater than 0")
if permissions is not None:
import re
if re.match("^[0-7]{3}$", permissions) is None:
module.fail_json(msg="Option `mode` has to have exactly 3 digits and be in the octet format e.g. 600")