From c0c5b9a50a304acaaa471e32623939408a6c587c Mon Sep 17 00:00:00 2001 From: Denis Tiago Date: Thu, 14 Jul 2016 21:21:07 -0300 Subject: [PATCH] fix health instances count when we have more than one lb in asg --- lib/ansible/modules/cloud/amazon/ec2_asg.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ansible/modules/cloud/amazon/ec2_asg.py b/lib/ansible/modules/cloud/amazon/ec2_asg.py index 034794a14d..ebef01841a 100644 --- a/lib/ansible/modules/cloud/amazon/ec2_asg.py +++ b/lib/ansible/modules/cloud/amazon/ec2_asg.py @@ -336,7 +336,7 @@ def elb_dreg(asg_connection, module, group_name, instance_id): def elb_healthy(asg_connection, elb_connection, module, group_name): - healthy_instances = [] + healthy_instances = set() as_group = asg_connection.get_all_groups(names=[group_name])[0] props = get_properties(as_group) # get healthy, inservice instances from ASG @@ -359,7 +359,7 @@ def elb_healthy(asg_connection, elb_connection, module, group_name): for i in lb_instances: if i.state == "InService": - healthy_instances.append(i.instance_id) + healthy_instances.add(i.instance_id) log.debug("{0}: {1}".format(i.instance_id, i.state)) return len(healthy_instances)