mirror of
https://github.com/ansible-collections/community.general.git
synced 2026-05-06 13:22:48 +00:00
win_firewall: check-mode support, integration tests (#25127)
* win_firewall: check-mode support, integration tests This PR includes: - Check-mode implementation - Documentation improvements - Ensure module output is consistent (no matter what profiles are provided) - Fixed indentation - Cosmetic changes - Integration tests * win_firewall: check-mode support, integration tests This PR includes: - Check-mode implementation - Documentation improvements - Ensure module output is consistent (no matter what profiles are provided) - Fixed indentation - Cosmetic changes - Integration tests
This commit is contained in:
Dag Wieers
jhawkesworth
1
test/integration/targets/win_firewall/aliases
Normal file
1
test/integration/targets/win_firewall/aliases
Normal file
@@ -0,0 +1 @@
|
||||
windows/ci/group2
|
||||
52
test/integration/targets/win_firewall/tasks/main.yml
Normal file
52
test/integration/targets/win_firewall/tasks/main.yml
Normal file
@@ -0,0 +1,52 @@
|
||||
# NOTE: The win_firewall module only works on WMF 5+
|
||||
|
||||
- setup:
|
||||
|
||||
- name: Test Windows capabilities
|
||||
raw: Get-Command Get-NetFirewallProfile -ErrorAction SilentlyContinue; return $?
|
||||
failed_when: no
|
||||
register: get_netfirewallprofile
|
||||
|
||||
- name: Only run tests when Windows is capable
|
||||
when: get_netfirewallprofile.rc == 0 and ansible_powershell_version >= 5
|
||||
block:
|
||||
- name: Turn off Windows Firewall (begin)
|
||||
win_firewall:
|
||||
profiles: [ Domain, Private, Public ]
|
||||
state: disabled
|
||||
register: firewall_off
|
||||
|
||||
- name: Test firewall_off
|
||||
assert:
|
||||
that:
|
||||
- not firewall_off.Domain.enabled
|
||||
- not firewall_off.Private.enabled
|
||||
- not firewall_off.Public.enabled
|
||||
|
||||
|
||||
- name: Test in normal mode
|
||||
include: tests.yml
|
||||
vars:
|
||||
in_check_mode: no
|
||||
|
||||
|
||||
- name: Test in check-mode
|
||||
include: tests.yml
|
||||
vars:
|
||||
in_check_mode: yes
|
||||
check_mode: yes
|
||||
|
||||
|
||||
- name: Turn on Windows Firewall (end)
|
||||
win_firewall:
|
||||
profiles: [ Domain, Private, Public ]
|
||||
state: enabled
|
||||
register: firewall_on
|
||||
|
||||
- name: Test firewall_on
|
||||
assert:
|
||||
that:
|
||||
- firewall_on|changed
|
||||
- firewall_on.Domain.enabled
|
||||
- firewall_on.Private.enabled
|
||||
- firewall_on.Public.enabled
|
||||
185
test/integration/targets/win_firewall/tasks/tests.yml
Normal file
185
test/integration/targets/win_firewall/tasks/tests.yml
Normal file
@@ -0,0 +1,185 @@
|
||||
# We start with firewall turned off
|
||||
|
||||
- name: Turn off Windows Firewall again
|
||||
win_firewall:
|
||||
profiles: [ Domain, Private, Public ]
|
||||
state: disabled
|
||||
register: firewall_off_again
|
||||
|
||||
- name: Test firewall_off_again
|
||||
assert:
|
||||
that:
|
||||
- not firewall_off_again|changed
|
||||
- not firewall_off_again.Domain.enabled
|
||||
- not firewall_off_again.Private.enabled
|
||||
- not firewall_off_again.Public.enabled
|
||||
|
||||
- name: Turn on Windows Firewall on Public
|
||||
win_firewall:
|
||||
profiles: [ Public ]
|
||||
state: enabled
|
||||
register: firewall_public_on
|
||||
|
||||
- name: Test firewall_public_on
|
||||
assert:
|
||||
that:
|
||||
- firewall_public_on|changed
|
||||
- not firewall_public_on.Domain.enabled
|
||||
- not firewall_public_on.Private.enabled
|
||||
- firewall_public_on.Public.enabled
|
||||
|
||||
|
||||
- name: Turn on Windows Firewall on Public again
|
||||
win_firewall:
|
||||
profiles: [ Public ]
|
||||
state: enabled
|
||||
register: firewall_public_on_again
|
||||
|
||||
- name: Test firewall_public_on_again (normal mode)
|
||||
assert:
|
||||
that:
|
||||
- not firewall_public_on_again|changed
|
||||
- not firewall_public_on_again.Domain.enabled
|
||||
- not firewall_public_on_again.Private.enabled
|
||||
- firewall_public_on_again.Public.enabled
|
||||
when: not in_check_mode
|
||||
|
||||
- name: Test firewall_public_on_again (check-mode)
|
||||
assert:
|
||||
that:
|
||||
- firewall_public_on_again|changed
|
||||
- not firewall_public_on_again.Domain.enabled
|
||||
- not firewall_public_on_again.Private.enabled
|
||||
- firewall_public_on_again.Public.enabled
|
||||
when: in_check_mode
|
||||
|
||||
|
||||
# On purpose not a list
|
||||
- name: Turn on Windows Firewall on Domain
|
||||
win_firewall:
|
||||
profiles: Domain
|
||||
state: enabled
|
||||
register: firewall_domain_on
|
||||
|
||||
- name: Test firewall_domain_on (normal mode)
|
||||
assert:
|
||||
that:
|
||||
- firewall_domain_on|changed
|
||||
- firewall_domain_on.Domain.enabled
|
||||
- not firewall_domain_on.Private.enabled
|
||||
- firewall_domain_on.Public.enabled
|
||||
when: not in_check_mode
|
||||
|
||||
- name: Test firewall_domain_on (check-mode)
|
||||
assert:
|
||||
that:
|
||||
- firewall_domain_on|changed
|
||||
- firewall_domain_on.Domain.enabled
|
||||
- not firewall_domain_on.Private.enabled
|
||||
- not firewall_domain_on.Public.enabled
|
||||
when: in_check_mode
|
||||
|
||||
|
||||
- name: Turn on Windows Firewall on Domain again
|
||||
win_firewall:
|
||||
profiles: [ Domain ]
|
||||
state: enabled
|
||||
register: firewall_domain_on_again
|
||||
|
||||
- name: Test firewall_domain_on_again (normal mode)
|
||||
assert:
|
||||
that:
|
||||
- not firewall_domain_on_again|changed
|
||||
- firewall_domain_on.Domain.enabled
|
||||
- not firewall_domain_on.Private.enabled
|
||||
- firewall_domain_on.Public.enabled
|
||||
when: not in_check_mode
|
||||
|
||||
- name: Test firewall_domain_on_again (check-mode)
|
||||
assert:
|
||||
that:
|
||||
- firewall_domain_on_again|changed
|
||||
- firewall_domain_on.Domain.enabled
|
||||
- not firewall_domain_on.Private.enabled
|
||||
- not firewall_domain_on.Public.enabled
|
||||
when: in_check_mode
|
||||
|
||||
|
||||
- name: Turn on Windows Firewall
|
||||
win_firewall:
|
||||
profiles: [ Domain, Private, Public ]
|
||||
state: enabled
|
||||
register: firewall_on
|
||||
|
||||
- name: Test firewall_on
|
||||
assert:
|
||||
that:
|
||||
- firewall_on|changed
|
||||
- firewall_on.Domain.enabled
|
||||
- firewall_on.Private.enabled
|
||||
- firewall_on.Public.enabled
|
||||
|
||||
|
||||
# On purpose no profiles added
|
||||
- name: Turn on Windows Firewall again
|
||||
win_firewall:
|
||||
state: enabled
|
||||
register: firewall_on_again
|
||||
|
||||
- name: Test firewall_on_again (normal mode)
|
||||
assert:
|
||||
that:
|
||||
- not firewall_on_again|changed
|
||||
- firewall_on_again.Domain.enabled
|
||||
- firewall_on_again.Private.enabled
|
||||
- firewall_on_again.Public.enabled
|
||||
when: not in_check_mode
|
||||
|
||||
- name: Test firewall_on_again (check-mode)
|
||||
assert:
|
||||
that:
|
||||
- firewall_on_again|changed
|
||||
- firewall_on_again.Domain.enabled
|
||||
- firewall_on_again.Private.enabled
|
||||
- firewall_on_again.Public.enabled
|
||||
when: in_check_mode
|
||||
|
||||
|
||||
# On purpose no profiles added
|
||||
- name: Turn off Windows Firewall
|
||||
win_firewall:
|
||||
state: disabled
|
||||
register: firewall_off2
|
||||
|
||||
- name: Test firewall_off2 (normal mode)
|
||||
assert:
|
||||
that:
|
||||
- firewall_off2|changed
|
||||
- not firewall_off2.Domain.enabled
|
||||
- not firewall_off2.Private.enabled
|
||||
- not firewall_off2.Public.enabled
|
||||
when: not in_check_mode
|
||||
|
||||
- name: Test firewall_off2 (check-mode)
|
||||
assert:
|
||||
that:
|
||||
- not firewall_off2|changed
|
||||
- not firewall_off2.Domain.enabled
|
||||
- not firewall_off2.Private.enabled
|
||||
- not firewall_off2.Public.enabled
|
||||
when: in_check_mode
|
||||
|
||||
|
||||
- name: Turn off Windows Firewall again
|
||||
win_firewall:
|
||||
profiles: [ Domain, Private, Public ]
|
||||
state: disabled
|
||||
register: firewall_off2_again
|
||||
|
||||
- name: Test firewall_off2_again (normal mode)
|
||||
assert:
|
||||
that:
|
||||
- not firewall_off2_again|changed
|
||||
- not firewall_off2_again.Domain.enabled
|
||||
- not firewall_off2_again.Private.enabled
|
||||
- not firewall_off2_again.Public.enabled
|
||||
Reference in New Issue
Block a user