internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-08 14:22:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

move conversion of data to json in slack API handling (#1101)

Browse Source 
* move conversion of data to json in slack API handling

at one point in do_notify_slack, we do operations on the payload
variable assuming it's a dict, but it's not: it's a json encoded string.

it's useful to operate on the payload as a dict rather than a string, so
solve this problem by moving the jsonify call to right before sending
the payload to the slack API.

fixes #1097

* add changelog fragment

* Update changelogs/fragments/1101-slack-ts-fix.yaml

Co-authored-by: Felix Fontein <felix@fontein.de>

* return payload as a json encoded string for backwards compatibility

Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
Andreas Lutro
2020-10-19 09:58:14 +02:00
committed by GitHub
parent 135cc1d337
commit b5b5410575
3 changed files with 48 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
changelogs/fragments/1101-slack-ts-fix.yaml Normal file
View File

@@ -0,0 +1,2 @@
bugfixes:
- slack - avoid trying to update existing message when sending messages that contain the string "ts" (https://github.com/ansible-collections/community.general/issues/1097).