internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-07 22:02:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #12400 from mcsalgado/dict_default_argument

Browse Source 
Fix mutable default argument
This commit is contained in:
James Cammarata
2015-09-16 16:09:27 -04:00
parent 33e79203ce 54f1560d3e
commit b44bc608e7
3 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/ansible/inventory/dir.py
View File

@@ -81,7 +81,10 @@ def get_file_parser(hostsfile, groups, loader):
class InventoryDirectory(object): class InventoryDirectory(object):
''' Host inventory parser for ansible using a directory of inventories. ''' ''' Host inventory parser for ansible using a directory of inventories. '''
def __init__(self, loader, groups=dict(), filename=C.DEFAULT_HOST_LIST): def __init__(self, loader, groups=None, filename=C.DEFAULT_HOST_LIST):
if groups is None:
groups = dict()
self.names = os.listdir(filename) self.names = os.listdir(filename)
self.names.sort() self.names.sort()
self.directory = filename self.directory = filename

5
lib/ansible/inventory/ini.py
View File

@@ -38,7 +38,10 @@ class InventoryParser(object):
with their associated hosts and variable settings. with their associated hosts and variable settings.
""" """
def __init__(self, loader, groups=dict(), filename=C.DEFAULT_HOST_LIST): def __init__(self, loader, groups=None, filename=C.DEFAULT_HOST_LIST):
if groups is None:
groups = dict()
self._loader = loader self._loader = loader
self.filename = filename self.filename = filename

4
lib/ansible/inventory/script.py
View File

@@ -36,7 +36,9 @@ from ansible.module_utils.basic import json_dict_bytes_to_unicode
class InventoryScript: class InventoryScript:
''' Host inventory parser for ansible using external inventory scripts. ''' ''' Host inventory parser for ansible using external inventory scripts. '''
def __init__(self, loader, groups=dict(), filename=C.DEFAULT_HOST_LIST): def __init__(self, loader, groups=None, filename=C.DEFAULT_HOST_LIST):
if groups is None:
groups = dict()
self._loader = loader self._loader = loader
self.groups = groups self.groups = groups