From a97d8dff5aad4a40c3553de0cc7ab205d32d4d82 Mon Sep 17 00:00:00 2001 From: Diogo Baeder de Paula Pinto Date: Sun, 8 Oct 2017 05:05:37 -0300 Subject: [PATCH] Fix argspec for webfaction modules * Fixing webfaction_domain "subdomains" argument parsing - must coerce to list, not string * Fixing webfaction_db and webfaction_app "machine" argument default --- lib/ansible/modules/cloud/webfaction/webfaction_app.py | 3 +-- lib/ansible/modules/cloud/webfaction/webfaction_db.py | 3 +-- lib/ansible/modules/cloud/webfaction/webfaction_domain.py | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/ansible/modules/cloud/webfaction/webfaction_app.py b/lib/ansible/modules/cloud/webfaction/webfaction_app.py index 258c3e627a..8d7512ef82 100644 --- a/lib/ansible/modules/cloud/webfaction/webfaction_app.py +++ b/lib/ansible/modules/cloud/webfaction/webfaction_app.py @@ -82,7 +82,6 @@ options: machine: description: - The machine name to use (optional for accounts with only one machine) - default: False ''' @@ -116,7 +115,7 @@ def main(): port_open=dict(required=False, type='bool', default=False), login_name=dict(required=True), login_password=dict(required=True, no_log=True), - machine=dict(required=False, default=False), + machine=dict(required=False, default=None), ), supports_check_mode=True ) diff --git a/lib/ansible/modules/cloud/webfaction/webfaction_db.py b/lib/ansible/modules/cloud/webfaction/webfaction_db.py index be40f32cbb..332ee27dd9 100644 --- a/lib/ansible/modules/cloud/webfaction/webfaction_db.py +++ b/lib/ansible/modules/cloud/webfaction/webfaction_db.py @@ -67,7 +67,6 @@ options: machine: description: - The machine name to use (optional for accounts with only one machine) - default: false ''' EXAMPLES = ''' @@ -106,7 +105,7 @@ def main(): password=dict(required=False, default=None, no_log=True), login_name=dict(required=True), login_password=dict(required=True, no_log=True), - machine=dict(required=False, default=False), + machine=dict(required=False, default=None), ), supports_check_mode=True ) diff --git a/lib/ansible/modules/cloud/webfaction/webfaction_domain.py b/lib/ansible/modules/cloud/webfaction/webfaction_domain.py index 118572f13a..473caf47d8 100644 --- a/lib/ansible/modules/cloud/webfaction/webfaction_domain.py +++ b/lib/ansible/modules/cloud/webfaction/webfaction_domain.py @@ -93,7 +93,7 @@ def main(): argument_spec=dict( name=dict(required=True), state=dict(required=False, choices=['present', 'absent'], default='present'), - subdomains=dict(required=False, default=[]), + subdomains=dict(required=False, default=[], type='list'), login_name=dict(required=True), login_password=dict(required=True, no_log=True), ),