Lenovo cnos logging (#52978)

* Adding the module cnos_logging.py to the module suite from Lenovo

test/integration/targets/cnos_logging/aliases

@@ -0,0 +1,2 @@
+# No Lenovo Switch simulator yet, so not enabled
+unsupported

test/integration/targets/cnos_logging/cnos_logging_sample_hosts

@@ -0,0 +1,14 @@
+# You have to paste this dummy information  in /etc/ansible/hosts
+#    Notes:
+#    - Comments begin with the '#' character
+#    - Blank lines are ignored
+#    - Groups of hosts are delimited by [header] elements
+#    - You can enter hostnames or ip Addresses
+#    - A hostname/ip can be a member of multiple groups
+#
+# In the /etc/ansible/hosts file u have to enter [cnos_portchannel_sample] tag
+# Following you should specify IP Addresses details 
+# Please change <username> and <password> with appropriate value for your switch.
+
+[cnos_logging_sample]
+10.241.107.39  ansible_network_os=cnos ansible_ssh_user=<username> ansible_ssh_pass=<password> 

test/integration/targets/cnos_logging/defaults/main.yaml

@@ -0,0 +1,2 @@
+---
+testcase: "*"

test/integration/targets/cnos_logging/tasks/cli.yaml

@@ -0,0 +1,22 @@
+---
+- name: collect all cli test cases
+  find:
+    paths: "{{ role_path }}/tests/cli"
+    patterns: "{{ testcase }}.yaml"
+  register: test_cases
+  delegate_to: localhost
+
+- name: set test_items
+  set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"
+
+- name: run test cases (connection=network_cli)
+  include: "{{ test_case_to_run }}"
+  with_items: "{{ test_items }}"
+  loop_control:
+    loop_var: test_case_to_run
+
+#- name: run test case (connection=local)
+#  include: "{{ test_case_to_run }} ansible_connection=local"
+#  with_first_found: "{{ test_items }}"
+#  loop_control:
+#    loop_var: test_case_to_run

test/integration/targets/cnos_logging/tasks/main.yaml

@@ -0,0 +1,2 @@
+---
+- { include: cli.yaml, tags: ['cli'] }

test/integration/targets/cnos_logging/tests/cli/basic.yaml

@@ -0,0 +1,136 @@
+---
+# ensure logging configs are empty
+- name: Remove server logging
+  cnos_logging: &remove_server
+    dest: server
+    name: 10.241.107.224
+    state: absent
+
+- name: Remove console
+  cnos_logging:
+    dest: console
+    level: 4
+    state: absent
+
+- name: Remove buffer
+  cnos_logging:
+    dest: logfile
+    size: 8000
+    state: absent
+
+# start tests
+- name: Set up server logging
+  cnos_logging:
+    dest: server
+    name: 10.241.107.224
+    facility: local7
+    state: present
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"logging server 10.241.107.224" in result.commands'
+
+- name: Set up server logging again (idempotent)
+  cnos_logging:
+    dest: server
+    name: 10.241.107.224
+    state: present
+  register: result
+
+- assert: &unchanged
+    that:
+      - 'result.changed == true'
+
+- name: Delete/disable server logging
+  cnos_logging: *remove_server
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"no logging server 10.241.107.224" in result.commands'
+
+- name: Delete/disable server logging (idempotent)
+  cnos_logging: *remove_server
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+
+- name: Console logging with level errors
+  cnos_logging:
+    dest: console
+    level: 3 
+    state: present
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"logging console 3" in result.commands'
+
+- name: Configure Buffer size
+  cnos_logging:
+    dest: logfile
+    name: testfile
+    level: 6
+    size: 8000
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"logging logfile testfile 6 size 8000" in result.commands'
+
+
+- name: Change logging parameters using aggregate
+  cnos_logging:
+    aggregate:
+      - { dest: console, level: 5 }
+      - { dest: logfile, name: anil, level: 3, size: 9000 }
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"logging logfile anil 3 size 9000" in result.commands'
+      - '"logging console 5" in result.commands'
+
+- name: Set both logging destination and facility
+  cnos_logging: &set_both
+    dest: logfile
+    name: mylog
+    level: 1
+    size: 4096
+    state: present
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"logging logfile mylog 1 size 4096" in result.commands'
+
+- name: Set both logging destination and facility (idempotent)
+  cnos_logging: *set_both
+  register: result
+
+- assert: 
+    that:
+      - 'result.changed == false'
+
+- name: remove logging as collection tearDown
+  cnos_logging:
+    aggregate:
+      - { dest: console, level: 6 }
+      - { dest: logfile, name: mylog, size: 4096, level: 1 }
+    state: absent
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"no logging console" in result.commands'
+      - '"no logging logfile" in result.commands'

test/units/modules/network/cnos/fixtures/cnos_logging_config.cfg

@@ -0,0 +1,9 @@
+!
+logging logfile anil 4 size 10485760
+logging level vlan 4
+logging server 1.2.3.4 facility local0
+logging server 1.2.34.5 port 34
+logging server 1.2.3.5 4 facility local2 port 23
+logging server anil 5
+logging server tapas 4 facility local2 port 23
+!

test/units/modules/network/cnos/test_cnos_logging.py

@@ -0,0 +1,62 @@
+#
+# (c) 2018 Red Hat Inc.
+# Copyright (C) 2017 Lenovo.
+#
+# This file is part of Ansible
+#
+# Ansible is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# Ansible is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+#
+
+from __future__ import (absolute_import, division, print_function)
+__metaclass__ = type
+
+import json
+
+from units.compat.mock import patch
+from ansible.modules.network.cnos import cnos_logging
+from units.modules.utils import set_module_args
+from .cnos_module import TestCnosModule, load_fixture
+
+
+class TestCnosLoggingModule(TestCnosModule):
+
+    module = cnos_logging
+
+    def setUp(self):
+        super(TestCnosLoggingModule, self).setUp()
+
+        self.mock_get_config = patch('ansible.modules.network.cnos.cnos_logging.get_config')
+        self.get_config = self.mock_get_config.start()
+
+        self.mock_load_config = patch('ansible.modules.network.cnos.cnos_logging.load_config')
+        self.load_config = self.mock_load_config.start()
+
+    def tearDown(self):
+        super(TestCnosLoggingModule, self).tearDown()
+        self.mock_get_config.stop()
+        self.mock_load_config.stop()
+
+    def load_fixtures(self, commands=None):
+        self.get_config.return_value = load_fixture('cnos_logging_config.cfg')
+        self.load_config.return_value = None
+
+    def test_cnos_logging_buffer_size_changed_implicit(self):
+        set_module_args(dict(dest='logfile', name='anil'))
+        commands = ['logging logfile anil 5 size 10485760']
+        self.execute_module(changed=True, commands=commands)
+
+    def test_cnos_logging_logfile_size_changed_explicit(self):
+        set_module_args(dict(dest='logfile', name='anil', level='4', size=6000))
+        commands = ['logging logfile anil 4 size 6000']
+        self.execute_module(changed=True, commands=commands)