internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-07 22:02:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Performance improvement using in-operator on dicts

Browse Source 
Just a small cleanup for the existing occurrences.

Using the in-operator for hash lookups is faster than using .keys()
http://stackoverflow.com/questions/29314269/why-do-key-in-dict-and-key-in-dict-keys-have-the-same-output
This commit is contained in:
Dag Wieers
2016-11-17 15:32:05 +01:00
committed by Matt Clay
parent b06003e5d2
commit a417a4f4b3
3 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/ansible/modules/extras/network/haproxy.py
View File

@@ -196,10 +196,10 @@ class HAProxy(object):
"""
Capture the output for a command
"""
if not 'command' in self.command_results.keys():
if 'command' not in self.command_results:
self.command_results['command'] = []
self.command_results['command'].append(cmd)
if not 'output' in self.command_results.keys():
if 'output' not in self.command_results:
self.command_results['output'] = []
self.command_results['output'].append(output)

4
lib/ansible/modules/extras/network/snmp_facts.py
View File

@@ -153,7 +153,7 @@ def lookup_adminstatus(int_adminstatus):
2: 'down',
3: 'testing'
}
if int_adminstatus in adminstatus_options.keys():
if int_adminstatus in adminstatus_options:
return adminstatus_options[int_adminstatus]
else:
return ""
@@ -168,7 +168,7 @@ def lookup_operstatus(int_operstatus):
6: 'notPresent',
7: 'lowerLayerDown'
}
if int_operstatus in operstatus_options.keys():
if int_operstatus in operstatus_options:
return operstatus_options[int_operstatus]
else:
return ""