internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-07 13:52:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Performance improvement using in-operator on dicts

Browse Source 
Just a small cleanup for the existing occurrences.

Using the in-operator for hash lookups is faster than using .keys()
http://stackoverflow.com/questions/29314269/why-do-key-in-dict-and-key-in-dict-keys-have-the-same-output
This commit is contained in:
Dag Wieers
2016-11-17 15:32:05 +01:00
committed by Matt Clay
parent b06003e5d2
commit a417a4f4b3
3 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
lib/ansible/modules/extras/cloud/misc/rhevm.py
View File

@@ -715,22 +715,22 @@ class RHEVConn(object):
for iface in ifaces:
try:
setMsg('creating host interface ' + iface['name'])
if 'management' in iface.keys():
if 'management' in iface:
manageip = iface['ip']
if 'boot_protocol' not in iface.keys():
if 'ip' in iface.keys():
if 'boot_protocol' not in iface:
if 'ip' in iface:
iface['boot_protocol'] = 'static'
else:
iface['boot_protocol'] = 'none'
if 'ip' not in iface.keys():
if 'ip' not in iface:
iface['ip'] = ''
if 'netmask' not in iface.keys():
if 'netmask' not in iface:
iface['netmask'] = ''
if 'gateway' not in iface.keys():
if 'gateway' not in iface:
iface['gateway'] = ''
if 'network' in iface.keys():
if 'bond' in iface.keys():
if 'network' in iface:
if 'bond' in iface:
bond = []
for slave in iface['bond']:
bond.append(ifacelist[slave])