mirror of
https://github.com/ansible-collections/community.general.git
synced 2026-05-06 21:32:49 +00:00
Refactors bigip_device_ntp (#33472)
* Refactors bigip_device_ntp To be inline with current f5 conventions * Fixed incorrect key
This commit is contained in:
Tim Rupp
GitHub
13
test/units/modules/network/f5/fixtures/load_ntp.json
Normal file
13
test/units/modules/network/f5/fixtures/load_ntp.json
Normal file
@@ -0,0 +1,13 @@
|
||||
{
|
||||
"kind": "tm:sys:ntp:ntpstate",
|
||||
"selfLink": "https://localhost/mgmt/tm/sys/ntp?ver=12.1.0",
|
||||
"servers": [
|
||||
"192.168.1.1",
|
||||
"192.168.1.2"
|
||||
],
|
||||
"timezone": "America/Los_Angeles",
|
||||
"restrictReference": {
|
||||
"link": "https://localhost/mgmt/tm/sys/ntp/restrict?ver=12.1.0",
|
||||
"isSubcollection": true
|
||||
}
|
||||
}
|
||||
252
test/units/modules/network/f5/test_bigip_device_ntp.py
Normal file
252
test/units/modules/network/f5/test_bigip_device_ntp.py
Normal file
@@ -0,0 +1,252 @@
|
||||
# -*- coding: utf-8 -*-
|
||||
#
|
||||
# Copyright (c) 2017 F5 Networks Inc.
|
||||
# GNU General Public License v3.0 (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
|
||||
|
||||
from __future__ import (absolute_import, division, print_function)
|
||||
__metaclass__ = type
|
||||
|
||||
import os
|
||||
import json
|
||||
import sys
|
||||
|
||||
from nose.plugins.skip import SkipTest
|
||||
if sys.version_info < (2, 7):
|
||||
raise SkipTest("F5 Ansible modules require Python >= 2.7")
|
||||
|
||||
from ansible.compat.tests import unittest
|
||||
from ansible.compat.tests.mock import Mock
|
||||
from ansible.compat.tests.mock import patch
|
||||
from ansible.module_utils.f5_utils import AnsibleF5Client
|
||||
|
||||
try:
|
||||
from library.bigip_device_ntp import Parameters
|
||||
from library.bigip_device_ntp import ModuleManager
|
||||
from library.bigip_device_ntp import ArgumentSpec
|
||||
from ansible.module_utils.f5_utils import iControlUnexpectedHTTPError
|
||||
from test.unit.modules.utils import set_module_args
|
||||
except ImportError:
|
||||
try:
|
||||
from ansible.modules.network.f5.bigip_device_ntp import Parameters
|
||||
from ansible.modules.network.f5.bigip_device_ntp import ModuleManager
|
||||
from ansible.modules.network.f5.bigip_device_ntp import ArgumentSpec
|
||||
from ansible.module_utils.f5_utils import iControlUnexpectedHTTPError
|
||||
from units.modules.utils import set_module_args
|
||||
except ImportError:
|
||||
raise SkipTest("F5 Ansible modules require the f5-sdk Python library")
|
||||
|
||||
fixture_path = os.path.join(os.path.dirname(__file__), 'fixtures')
|
||||
fixture_data = {}
|
||||
|
||||
|
||||
def load_fixture(name):
|
||||
path = os.path.join(fixture_path, name)
|
||||
|
||||
if path in fixture_data:
|
||||
return fixture_data[path]
|
||||
|
||||
with open(path) as f:
|
||||
data = f.read()
|
||||
|
||||
try:
|
||||
data = json.loads(data)
|
||||
except Exception:
|
||||
pass
|
||||
|
||||
fixture_data[path] = data
|
||||
return data
|
||||
|
||||
|
||||
class TestParameters(unittest.TestCase):
|
||||
def test_module_parameters(self):
|
||||
ntp = ['192.168.1.1', '192.168.1.2']
|
||||
args = dict(
|
||||
ntp_servers=ntp,
|
||||
timezone='Arctic/Longyearbyen'
|
||||
)
|
||||
|
||||
p = Parameters(args)
|
||||
assert p.ntp_servers == ntp
|
||||
assert p.timezone == 'Arctic/Longyearbyen'
|
||||
|
||||
def test_api_parameters(self):
|
||||
ntp = ['192.168.1.1', '192.168.1.2']
|
||||
args = dict(
|
||||
servers=ntp,
|
||||
timezone='Arctic/Longyearbyen'
|
||||
)
|
||||
|
||||
p = Parameters(args)
|
||||
assert p.ntp_servers == ntp
|
||||
assert p.timezone == 'Arctic/Longyearbyen'
|
||||
|
||||
|
||||
@patch('ansible.module_utils.f5_utils.AnsibleF5Client._get_mgmt_root',
|
||||
return_value=True)
|
||||
class TestModuleManager(unittest.TestCase):
|
||||
|
||||
def setUp(self):
|
||||
self.spec = ArgumentSpec()
|
||||
|
||||
def test_update_ntp_servers(self, *args):
|
||||
ntp = ['10.1.1.1', '10.1.1.2']
|
||||
set_module_args(
|
||||
dict(
|
||||
ntp_servers=ntp,
|
||||
server='localhost',
|
||||
user='admin',
|
||||
password='password'
|
||||
)
|
||||
)
|
||||
|
||||
# Configure the parameters that would be returned by querying the
|
||||
# remote device
|
||||
current = Parameters(
|
||||
load_fixture('load_ntp.json')
|
||||
)
|
||||
|
||||
client = AnsibleF5Client(
|
||||
argument_spec=self.spec.argument_spec,
|
||||
supports_check_mode=self.spec.supports_check_mode,
|
||||
f5_product_name=self.spec.f5_product_name
|
||||
)
|
||||
mm = ModuleManager(client)
|
||||
|
||||
# Override methods to force specific logic in the module to happen
|
||||
mm.update_on_device = Mock(return_value=True)
|
||||
mm.read_current_from_device = Mock(return_value=current)
|
||||
|
||||
results = mm.exec_module()
|
||||
assert results['changed'] is True
|
||||
assert results['ntp_servers'] == ntp
|
||||
|
||||
def test_update_timezone(self, *args):
|
||||
set_module_args(
|
||||
dict(
|
||||
timezone='Arctic/Longyearbyen',
|
||||
server='localhost',
|
||||
user='admin',
|
||||
password='password'
|
||||
)
|
||||
)
|
||||
|
||||
# Configure the parameters that would be returned by querying the
|
||||
# remote device
|
||||
current = Parameters(
|
||||
load_fixture('load_ntp.json')
|
||||
)
|
||||
|
||||
client = AnsibleF5Client(
|
||||
argument_spec=self.spec.argument_spec,
|
||||
supports_check_mode=self.spec.supports_check_mode,
|
||||
f5_product_name=self.spec.f5_product_name
|
||||
)
|
||||
mm = ModuleManager(client)
|
||||
|
||||
# Override methods to force specific logic in the module to happen
|
||||
mm.update_on_device = Mock(return_value=True)
|
||||
mm.read_current_from_device = Mock(return_value=current)
|
||||
|
||||
results = mm.exec_module()
|
||||
assert results['changed'] is True
|
||||
assert results['timezone'] == 'Arctic/Longyearbyen'
|
||||
|
||||
def test_update_ntp_servers_and_timezone(self, *args):
|
||||
ntp = ['10.1.1.1', '10.1.1.2']
|
||||
set_module_args(
|
||||
dict(
|
||||
ntp_servers=ntp,
|
||||
timezone='Arctic/Longyearbyen',
|
||||
server='localhost',
|
||||
user='admin',
|
||||
password='password'
|
||||
)
|
||||
)
|
||||
|
||||
# Configure the parameters that would be returned by querying the
|
||||
# remote device
|
||||
current = Parameters(
|
||||
load_fixture('load_ntp.json')
|
||||
)
|
||||
|
||||
client = AnsibleF5Client(
|
||||
argument_spec=self.spec.argument_spec,
|
||||
supports_check_mode=self.spec.supports_check_mode,
|
||||
f5_product_name=self.spec.f5_product_name
|
||||
)
|
||||
mm = ModuleManager(client)
|
||||
|
||||
# Override methods to force specific logic in the module to happen
|
||||
mm.update_on_device = Mock(return_value=True)
|
||||
mm.read_current_from_device = Mock(return_value=current)
|
||||
|
||||
results = mm.exec_module()
|
||||
assert results['changed'] is True
|
||||
assert results['ntp_servers'] == ntp
|
||||
assert results['timezone'] == 'Arctic/Longyearbyen'
|
||||
|
||||
def test_absent_ntp_servers(self, *args):
|
||||
ntp = []
|
||||
set_module_args(
|
||||
dict(
|
||||
ntp_servers=ntp,
|
||||
timezone='America/Los_Angeles',
|
||||
server='localhost',
|
||||
user='admin',
|
||||
password='password',
|
||||
state='absent'
|
||||
)
|
||||
)
|
||||
|
||||
# Configure the parameters that would be returned by querying the
|
||||
# remote device
|
||||
current = Parameters(
|
||||
load_fixture('load_ntp.json')
|
||||
)
|
||||
|
||||
client = AnsibleF5Client(
|
||||
argument_spec=self.spec.argument_spec,
|
||||
supports_check_mode=self.spec.supports_check_mode,
|
||||
f5_product_name=self.spec.f5_product_name
|
||||
)
|
||||
mm = ModuleManager(client)
|
||||
|
||||
# Override methods to force specific logic in the module to happen
|
||||
mm.absent_on_device = Mock(return_value=True)
|
||||
mm.read_current_from_device = Mock(return_value=current)
|
||||
|
||||
results = mm.exec_module()
|
||||
assert results['changed'] is True
|
||||
assert results['ntp_servers'] == ntp
|
||||
assert not hasattr(results, 'timezone')
|
||||
|
||||
def test_absent_timezone(self, *args):
|
||||
set_module_args(
|
||||
dict(
|
||||
timezone='',
|
||||
server='localhost',
|
||||
user='admin',
|
||||
password='password',
|
||||
state='absent'
|
||||
)
|
||||
)
|
||||
|
||||
# Configure the parameters that would be returned by querying the
|
||||
# remote device
|
||||
current = Parameters(
|
||||
load_fixture('load_ntp.json')
|
||||
)
|
||||
|
||||
client = AnsibleF5Client(
|
||||
argument_spec=self.spec.argument_spec,
|
||||
supports_check_mode=self.spec.supports_check_mode,
|
||||
f5_product_name=self.spec.f5_product_name
|
||||
)
|
||||
mm = ModuleManager(client)
|
||||
|
||||
# Override methods to force specific logic in the module to happen
|
||||
mm.absent_on_device = Mock(return_value=True)
|
||||
mm.read_current_from_device = Mock(return_value=current)
|
||||
|
||||
results = mm.exec_module()
|
||||
assert results['changed'] is False
|
||||
Reference in New Issue
Block a user