Remove deprecated options from modules (#50246)

* Remove deprecated options from modules

* Update tests

* Add porting guide notes

test/integration/targets/ios_config/tasks/cli.yaml

@@ -10,7 +10,7 @@
   set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"
 
 - name: run test cases (connection=network_cli)
-  include: "{{ test_case_to_run }}"
+  include: "{{ test_case_to_run }} ansible_connection=network_cli"
   with_items: "{{ test_items }}"
   loop_control:
     loop_var: test_case_to_run

test/integration/targets/ios_config/tasks/cli_config.yaml

@@ -9,7 +9,7 @@
 - name: set test_items
   set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"
 
-- name: run test case (connection=network_cli)
+- name: run test cases (connection=network_cli)
   include: "{{ test_case_to_run }} ansible_connection=network_cli"
   with_items: "{{ test_items }}"
   loop_control:

test/integration/targets/ios_config/tests/cli/save.yaml

@@ -9,22 +9,17 @@
     parents:
       - interface Loopback999
     match: none
+    save_when: modified
 
-
-- name: save config
+- name: save should always run
   ios_config:
-    save: true
+    save_when: always
   register: result
 
 - assert:
     that:
       - "result.changed == true"
 
-- name: save should always run
-  ios_config:
-    save: true
-  register: result
-
 - name: delete config (setup)
   ios_config:
     replace: line
@@ -33,7 +28,7 @@
     save_when: modified
   register: result
 
-- name: save should always run
+- name: save should run when changed
   ios_config:
     replace: line
     lines: