internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-07 05:42:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

ACI: Cleanup deprecated boolean behaviour (#55207)

Browse Source 
* ACI: Cleanup deprecated boolean behaviour

* Remove from sanity ignore list
This commit is contained in:
Dag Wieers
2019-04-16 14:13:24 +02:00
committed by GitHub
parent 521e62aa38
commit 9495ddbc21
7 changed files with 6 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
lib/ansible/module_utils/network/aci/aci.py
View File

@@ -141,23 +141,6 @@ class ACIModule(object):
elif value is False:
return false
# When we expect value is of type=raw, deprecate in Ansible v2.8 (and all modules use type=bool)
try:
# This supports all Ansible boolean types
bool_value = boolean(value)
if bool_value is True:
return true
elif bool_value is False:
return false
except Exception:
# This provides backward compatibility to Ansible v2.4, deprecate in Ansible v2.8
if value == true:
self.module.deprecate("Boolean value '%s' is no longer valid, please use 'yes' as a boolean value." % value, '2.9')
return true
elif value == false:
self.module.deprecate("Boolean value '%s' is no longer valid, please use 'no' as a boolean value." % value, '2.9')
return false
# If all else fails, escalate back to user
self.module.fail_json(msg="Boolean value '%s' is an invalid ACI boolean value.")