internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-08 06:12:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

[PR #11119/41923e43 backport][stable-12] fix ruff case SIM103 (#11132)

Browse Source 
fix ruff case SIM103 (#11119)

* fix ruff case SIM103

* add changelog frag

(cherry picked from commit 41923e43bd)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
This commit is contained in:
patchback[bot]
2025-11-12 21:32:10 +01:00
committed by GitHub
parent ac6c6df2c7
commit 93d23cfef6
39 changed files with 115 additions and 230 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
plugins/modules/oneandone_firewall_policy.py
View File

@@ -229,9 +229,7 @@ def _add_server_ips(module, oneandone_conn, firewall_id, server_ids):
attach_servers.append(attach_server)
if module.check_mode:
if attach_servers:
return True
return False
return bool(attach_servers)
firewall_policy = oneandone_conn.attach_server_firewall_policy(
firewall_id=firewall_id, server_ips=attach_servers
@@ -248,9 +246,7 @@ def _remove_firewall_server(module, oneandone_conn, firewall_id, server_ip_id):
try:
if module.check_mode:
firewall_server = oneandone_conn.get_firewall_server(firewall_id=firewall_id, server_ip_id=server_ip_id)
if firewall_server:
return True
return False
return bool(firewall_server)
firewall_policy = oneandone_conn.remove_firewall_server(firewall_id=firewall_id, server_ip_id=server_ip_id)
return firewall_policy
@@ -273,9 +269,7 @@ def _add_firewall_rules(module, oneandone_conn, firewall_id, rules):
if module.check_mode:
firewall_policy_id = get_firewall_policy(oneandone_conn, firewall_id)
if firewall_rules and firewall_policy_id:
return True
return False
return bool(firewall_rules and firewall_policy_id)
firewall_policy = oneandone_conn.add_firewall_policy_rule(
firewall_id=firewall_id, firewall_policy_rules=firewall_rules
@@ -292,9 +286,7 @@ def _remove_firewall_rule(module, oneandone_conn, firewall_id, rule_id):
try:
if module.check_mode:
rule = oneandone_conn.get_firewall_policy_rule(firewall_id=firewall_id, rule_id=rule_id)
if rule:
return True
return False
return bool(rule)
firewall_policy = oneandone_conn.remove_firewall_rule(firewall_id=firewall_id, rule_id=rule_id)
return firewall_policy