internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-06 21:32:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

cloudstack: added fetch_list=True where appropriate (#40233)

Browse Source
This commit is contained in:
Peter Farmer
2018-05-17 11:16:43 +01:00
committed by René Moser
parent 44eaa2c007
commit 912e07a036
17 changed files with 50 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/ansible/modules/cloud/cloudstack/cs_firewall.py
View File

@@ -242,7 +242,8 @@ class AnsibleCloudStackFirewall(AnsibleCloudStack):
args = {
'account': self.get_account('name'),
'domainid': self.get_domain('id'),
'projectid': self.get_project('id')
'projectid': self.get_project('id'),
'fetch_list': True,
}
if fw_type == 'egress':
args['networkid'] = self.get_network(key='id')
@@ -255,8 +256,8 @@ class AnsibleCloudStackFirewall(AnsibleCloudStack):
self.module.fail_json(msg="missing required argument for type ingress: ip_address")
firewall_rules = self.query_api('listFirewallRules', **args)
if firewall_rules and 'firewallrule' in firewall_rules:
for rule in firewall_rules['firewallrule']:
if firewall_rules:
for rule in firewall_rules:
type_match = self._type_cidrs_match(rule, cidrs)
protocol_match = (