[PR #11049/396f467b backport][stable-12] Improve Python code: address unused variables (#11058)

Improve Python code: address unused variables (#11049)

* Address F841 (unused variable).

* Reformat.

* Add changelog fragment.

* More cleanup.

* Remove trailing whitespace.

* Readd removed code as a comment with TODO.

(cherry picked from commit 396f467bbb)

Co-authored-by: Felix Fontein <felix@fontein.de>

plugins/modules/portinstall.py

@@ -71,13 +71,11 @@ def query_package(module, name):
 
     # Assume that if we have pkg_info, we haven't upgraded to pkgng
     if pkg_info_path:
-        pkgng = False
-        pkg_glob_path = module.get_bin_path("pkg_glob", True)
+        module.get_bin_path("pkg_glob", True)
         # TODO: convert run_comand() argument to list!
         rc, out, err = module.run_command(f"{pkg_info_path} -e `pkg_glob {shlex_quote(name)}`", use_unsafe_shell=True)
         pkg_info_path = [pkg_info_path]
     else:
-        pkgng = True
         pkg_info_path = [module.get_bin_path("pkg", True), "info"]
         rc, out, err = module.run_command(pkg_info_path + [name])