mirror of
https://github.com/ansible-collections/community.general.git
synced 2026-05-06 13:22:48 +00:00
Fix remote_tmp when become with non admin user (#42396)
* Fix tmpdir on non root become
- also avoid exception if tmpdir and remote_tmp are None
- give 'None' on deescalation so tempfile will fallback to it's default behaviour
and use system dirs
- fix issue with bad tempdir (not existing/not createable/not writeable)
i.e nobody and ~/.ansible/tmp
- added tests for blockfile case
* Revert "Temporarily revert c119d54"
This reverts commit 5c614a59a6.
* changes based on PR feedback and changelog fragment
* changes based on the review
* Fix tmpdir when makedirs failed so we just use the system tmp
* Let missing remote_tmp fail
If remote_tmp is missing then there's something more basic wrong in the
communication from the controller to the module-side. It's better to
be alerted in this case than to silently ignore it.
jborean and I have independently checked what happens if the user sets
ansible_remote_tmp to empty string and !!null and both cases work fine.
(null is turned into a default value controller-side. empty string
triggers the warning because it is probably not a directory that the
become user is able to use).
This commit is contained in:
committed by
Toshio Kuratomi
parent
6339e37abd
commit
8bdd04c147
@@ -67,10 +67,13 @@ class ConnectionMock(object):
|
||||
transport = None
|
||||
_new_stdin = StdinMock()
|
||||
|
||||
get_option = MagicMock(return_value='root')
|
||||
|
||||
# my shell
|
||||
_shell = MagicMock()
|
||||
_shell.mkdtemp.return_value = 'mkdir command'
|
||||
_shell.join_path.side_effect = os.path.join
|
||||
_shell.get_option = MagicMock(return_value=['root', 'toor'])
|
||||
|
||||
|
||||
class PlayContextMock(object):
|
||||
|
||||
Reference in New Issue
Block a user