Make diff header lines more explicit about what the diff is about

This gives a more readable output when producing diff for a task
with multiple items (with_items).
This commit is contained in:
Stoned Elipot
2013-02-26 16:53:59 +01:00
parent 1b8c9bab35
commit 8816dc7ca7
3 changed files with 12 additions and 2 deletions

View File

@@ -126,6 +126,7 @@ class ActionModule(object):
dest_contents = base64.b64decode(dest_contents)
else:
raise Exception("unknown encoding, failed: %s" % dest_result.result)
diff['before_header'] = destination
diff['before'] = dest_contents
src = open(source)
@@ -137,6 +138,7 @@ class ActionModule(object):
diff['src_larger'] = utils.MAX_FILE_SIZE_FOR_DIFF
else:
src.seek(0)
diff['after_header'] = source
diff['after'] = src.read()
return diff

View File

@@ -104,7 +104,7 @@ class ActionModule(object):
module_args = "%s src=%s dest=%s" % (module_args, xfered, dest)
if self.runner.check:
return ReturnData(conn=conn, comm_ok=True, result=dict(changed=True), diff=dict(before=dest_contents, after=resultant))
return ReturnData(conn=conn, comm_ok=True, result=dict(changed=True), diff=dict(before_header=dest, after_header=source, before=dest_contents, after=resultant))
else:
res = self.runner._execute_module(conn, tmp, 'copy', module_args, inject=inject)
res.diff = dict(before=dest_contents, after=resultant)