internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-07 22:02:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[feat] proxmox_snap: snapshot containers with configured mountpoints (#5274) (#5317)

Browse Source 
* module_utils.proxmox: new `api_task_ok` helper + integrated with existing modules

* proxmox_snap: add `unbind` param to snapshot containers with mountpoints

* [fix] errors reported by 'test sanity pep8'
at
https://github.com/ansible-collections/community.general/pull/5274#issuecomment-1242932079

* module_utils.proxmox.api_task_ok: small improvement

* proxmox_snap.unbind: version_added, formatting errors, changelog fragment

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* proxmox_snap.unbind: update version_added tag

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 25e3031c2f)

Co-authored-by: nxet <nxet821@protonmail.com>
This commit is contained in:
patchback[bot]
2022-09-28 23:20:21 +02:00
committed by GitHub
parent d25b6e7681
commit 869e1a1eab
6 changed files with 117 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
plugins/modules/cloud/misc/proxmox_template.py
View File

@@ -131,8 +131,7 @@ class ProxmoxTemplateAnsible(ProxmoxAnsible):
Check the task status and wait until the task is completed or the timeout is reached.
"""
while timeout:
task_status = self.proxmox_api.nodes(node).tasks(taskid).status.get()
if task_status['status'] == 'stopped' and task_status['exitstatus'] == 'OK':
if self.api_task_ok(node, taskid):
return True
timeout = timeout - 1
if timeout == 0: