Update validate-modules (#20932)

* Update validate-modules

* Validates ANSIBLE_METADATA
* Ensures imports happen after documentation vars
* Some pep8 cleanup

* Clean up some left over unneeded code

* Update modules for new module guidelines and validate-modules checks

* Update imports for ec2_vpc_route_table and ec2_vpc_nat_gateway

lib/ansible/modules/web_infrastructure/ansible_tower/tower_organization.py

@@ -16,6 +16,10 @@
 # You should have received a copy of the GNU General Public License
 # along with this software.  If not, see <http://www.gnu.org/licenses/>.
 
+ANSIBLE_METADATA = {'status': ['preview'],
+                    'supported_by': 'community',
+                    'version': '1.0'}
+
 DOCUMENTATION = '''
 ---
 module: tower_organization

lib/ansible/modules/web_infrastructure/jenkins_plugin.py

@@ -18,20 +18,6 @@
 # You should have received a copy of the GNU General Public License
 # along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
 
-
-from ansible.module_utils.basic import AnsibleModule
-from ansible.module_utils.pycompat24 import get_exception
-from ansible.module_utils.urls import fetch_url, url_argument_spec
-from ansible.module_utils._text import to_native
-import base64
-import hashlib
-import json
-import os
-import tempfile
-import time
-import urllib
-
-
 ANSIBLE_METADATA = {'status': ['preview'],
                     'supported_by': 'community',
                     'version': '1.0'}
@@ -307,6 +293,18 @@ state:
     sample: "present"
 '''
 
+from ansible.module_utils.basic import AnsibleModule
+from ansible.module_utils.pycompat24 import get_exception
+from ansible.module_utils.urls import fetch_url, url_argument_spec
+from ansible.module_utils._text import to_native
+import base64
+import hashlib
+import json
+import os
+import tempfile
+import time
+import urllib
+
 
 class JenkinsPlugin(object):
     def __init__(self, module):

lib/ansible/modules/web_infrastructure/jenkins_script.py

@@ -20,6 +20,10 @@
 # along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
 
 
+ANSIBLE_METADATA = {'status': ['preview'],
+                    'supported_by': 'community',
+                    'version': '1.0'}
+
 DOCUMENTATION = '''
 ---
 author: James Hogarth

lib/ansible/modules/web_infrastructure/letsencrypt.py

@@ -18,12 +18,6 @@
 # You should have received a copy of the GNU General Public License
 # along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
 
-import binascii
-import copy
-import locale
-import textwrap
-from datetime import datetime
-
 ANSIBLE_METADATA = {'status': ['preview'],
                     'supported_by': 'community',
                     'version': '1.0'}
@@ -168,6 +162,13 @@ authorizations:
         type: dict
 '''
 
+import binascii
+import copy
+import locale
+import textwrap
+from datetime import datetime
+
+
 def nopad_b64(data):
     return base64.urlsafe_b64encode(data).decode('utf8').replace("=", "")
 

lib/ansible/modules/web_infrastructure/supervisorctl.py

@@ -18,9 +18,6 @@
 # You should have received a copy of the GNU General Public License
 # along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
 #
-import os
-from ansible.module_utils.basic import AnsibleModule, is_executable
-
 ANSIBLE_METADATA = {'status': ['preview'],
                     'supported_by': 'community',
                     'version': '1.0'}
@@ -111,6 +108,9 @@ EXAMPLES = '''
     server_url: http://localhost:9001
 '''
 
+import os
+from ansible.module_utils.basic import AnsibleModule, is_executable
+
 
 def main():
     arg_spec = dict(