fix nxos_vpc issues (#35868)

test/integration/targets/nxos_vpc/tests/common/sanity.yaml

@@ -19,14 +19,9 @@
     nxos_vpc: &conf_vpc
       state: present
       domain: 100
-      role_priority: 500
-      system_priority: 2000
       pkl_dest: 192.168.100.4
       pkl_src: 10.1.100.20
       pkl_vrf: ntc
-      peer_gw: true
-      delay_restore: 5
-      auto_recovery: true
       provider: "{{ connection }}"
     register: result
 
@@ -42,18 +37,134 @@
       that:
         - "result.changed == false"
 
+  - name: Configure vpc1
+    nxos_vpc: &conf_vpc1
+      state: present
+      domain: 100
+      role_priority: 500
+      system_priority: 2000
+      peer_gw: True
+      delay_restore: 5
+      provider: "{{ connection }}"
+    register: result
+
+  - assert: *true
+
+  - name: "Conf Idempotence"
+    nxos_vpc: *conf_vpc1
+    register: result
+
+  - assert: *false
+
+  - block:
+    - name: Configure auto1
+      nxos_vpc: &auto_false
+        state: present
+        domain: 100
+        auto_recovery: False
+        provider: "{{ connection }}"
+      register: result
+
+    - assert: *true
+
+    - name: "Conf Idempotence"
+      nxos_vpc: *auto_false
+      register: result
+
+    - assert: *false
+
+    - name: Configure auto2
+      nxos_vpc: &auto_true
+        state: present
+        domain: 100
+        auto_recovery: True
+        provider: "{{ connection }}"
+      register: result
+
+    - assert: *true
+
+    - name: "Conf Idempotence"
+      nxos_vpc: *auto_true
+      register: result
+
+    - assert: *false
+
+    when: (platform is search("N7K|N9K-F"))
+
+  - block:
+    - name: Configure auto1
+      nxos_vpc: &auto_true1
+        state: present
+        domain: 100
+        auto_recovery: True
+        provider: "{{ connection }}"
+      register: result
+
+    - assert: *true
+
+    - name: "Conf Idempotence"
+      nxos_vpc: *auto_true1
+      register: result
+
+    - assert: *false
+
+    - name: Configure auto2
+      nxos_vpc: &auto_false1
+        state: present
+        domain: 100
+        auto_recovery: False
+        provider: "{{ connection }}"
+      register: result
+
+    - assert: *true
+
+    - name: "Conf Idempotence"
+      nxos_vpc: *auto_false1
+      register: result
+
+    - assert: *false
+
+    when: not (platform is search("N7K|N9K-F"))
+
+  - name: Configure vpc2
+    nxos_vpc: &conf_vpc2
+      state: present
+      domain: 100
+      role_priority: default
+      system_priority: default
+      peer_gw: True
+      delay_restore: default
+      provider: "{{ connection }}"
+    register: result
+
+  - assert: *true
+
+  - name: "Conf Idempotence"
+    nxos_vpc: *conf_vpc2
+    register: result
+
+  - assert: *false
+
+  - name: Configure vpc3
+    nxos_vpc: &conf_vpc3
+      state: present
+      domain: 100
+      peer_gw: False
+      provider: "{{ connection }}"
+    register: result
+
+  - assert: *true
+
+  - name: "Conf Idempotence"
+    nxos_vpc: *conf_vpc3
+    register: result
+
+  - assert: *false
+
   - name: remove vpc
     nxos_vpc: &rem_vpc
       state: absent
       domain: 100
-      role_priority: 32667
-      system_priority: 2000
-      pkl_dest: 192.168.100.4
-      pkl_src: 10.1.100.20
-      pkl_vrf: ntc
-      peer_gw: true
-      delay_restore: 5
-      auto_recovery: false
       provider: "{{ connection }}"
     register: result
 

test/units/modules/network/nxos/test_nxos_vpc.py

@@ -61,6 +61,6 @@ class TestNxosVpcModule(TestNxosModule):
                              peer_gw=True, auto_recovery=True))
         self.execute_module(changed=True, commands=[
             'vpc domain 100', 'terminal dont-ask', 'role priority 32667', 'system-priority 2000',
-            'peer-keepalive destination 192.168.100.4 source 10.1.100.20 vrf management',
+            'peer-keepalive destination 192.168.100.4 source 10.1.100.20',
             'peer-gateway', 'auto-recovery',
         ])