nxos CI failures bugfix (#42240)

* fix nxos_portchannel and remove deprecated param in test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix _nxos_switchport CI failures

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix nxapi nxos_command test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* remove unsupported param nxos_smoke test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix nxos_vxlan_vtep_vni

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* syntax error

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

test/integration/targets/nxos_command/tests/cli/contains.yaml

@@ -9,7 +9,6 @@
     wait_for:
       - "result[0] contains NX-OS"
       - "result[1].TABLE_interface.ROW_interface.interface contains mgmt"
-    provider: "{{ connection }}"
   register: result
 
 - assert:

test/integration/targets/nxos_command/tests/nxapi/contains.yaml

@@ -0,0 +1,19 @@
+---
+- debug: msg="START common/contains.yaml on connection={{ ansible_connection }}"
+
+- name: test contains operator
+  nxos_command:
+    commands:
+      - { command: 'show version', output: 'text' }
+      - { command: 'show interface mgmt0', output: 'json' }
+    wait_for:
+      - "result[0] contains NX-OS"
+      - "result[1].TABLE_interface.ROW_interface.interface contains mgmt"
+    provider: "{{ connection }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == false"
+
+- debug: msg="END common/contains.yaml on connection={{ ansible_connection }}"

test/integration/targets/nxos_portchannel/tests/common/sanity.yaml

@@ -34,7 +34,6 @@
     force: 'true'
     provider: "{{ connection }}"
     state: absent
-    timeout: 60
 
 - block:
   - name: Configure port-channel mode active
@@ -45,7 +44,6 @@
       force: 'true'
       provider: "{{ connection }}"
       state: present
-      timeout: 60
     register: result
 
   - assert: &true
@@ -68,7 +66,6 @@
       force: 'true'
       provider: "{{ connection }}"
       state: present
-      timeout: 60
     register: result
 
   - assert: *true
@@ -91,7 +88,6 @@
       feature: lacp
       provider: "{{ connection }}"
       state: disabled
-      timeout: 60
 
   always:
   - name: Delete port-channel

test/integration/targets/nxos_smoke/tests/common/common_config.yaml

@@ -30,7 +30,6 @@
 - name: delete backup files
   file:
     path: "{{ item.path }}"
-    provider: "{{ connection }}"
     state: absent
   with_items: "{{backup_files.files|default([])}}"