internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-08 14:22:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Warn on provider with network_cli (#33355)

Browse Source 
* Warn on `provider` with network_cli

also unify action plugins

* Add to porting guide about connection warnings
This commit is contained in:
Nathaniel Case
2017-12-01 12:22:54 -05:00
committed by GitHub
parent 717b6e7c1a
commit 7f90c9d1a7
8 changed files with 129 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib/ansible/plugins/action/ios.py
View File

@@ -39,11 +39,14 @@ except ImportError:
class ActionModule(_ActionModule):
def run(self, tmp=None, task_vars=None):
socket_path = None
if self._play_context.connection == 'local':
provider = load_provider(ios_provider_spec, self._task.args)
if self._play_context.connection == 'network_cli':
provider = self._task.args.get('provider', {})
if any(provider.values()):
display.warning('provider is unnecessary when using network_cli and will be ignored')
elif self._play_context.connection == 'local':
provider = load_provider(ios_provider_spec, self._task.args)
pc = copy.deepcopy(self._play_context)
pc.connection = 'network_cli'
pc.network_os = 'ios'
@@ -70,10 +73,6 @@ class ActionModule(_ActionModule):
task_vars['ansible_socket'] = socket_path
if self._play_context.become_method == 'enable':
self._play_context.become = False
self._play_context.become_method = None
# make sure we are in the right cli context which should be
# enable mode and not config module
if socket_path is None:
@@ -87,5 +86,4 @@ class ActionModule(_ActionModule):
out = conn.get_prompt()
result = super(ActionModule, self).run(tmp, task_vars)
return result