internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-08 06:12:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

uri: check unexpected failure doesn't occur when file cannot be saved (#45824)

Browse Source 
* uri: fix TypeError when file can't be saved

Fix the following exception (and others):

    Traceback (most recent call last):
      File "/home/lilou/debug_dir/__main__.py", line 604, in <module>
        main()
      File "/home/lilou/debug_dir/__main__.py", line 554, in main
        write_file(module, url, dest, content, resp)
      File "/home/lilou/debug_dir/__main__.py", line 320, in write_file
        module.fail_json(msg="Destination dir '%s' not writable" % os.path.dirname(dest), **resp)
    TypeError: fail_json() got multiple values for keyword argument 'msg'

I would rather remove **resp from returned values but this module is
flagged as stableinterface.

* Static imports are more straight forward and preferred unless dynamic inclusion is required.
This commit is contained in:
Pilou
2019-02-04 16:29:05 +01:00
committed by Sam Doran
parent 28284c23a9
commit 7a3582d651
4 changed files with 56 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
changelogs/fragments/45824-uri-fix-TypeError.yaml Normal file
View File

@@ -0,0 +1,3 @@
---
bugfixes:
- "uri: fix TypeError when file can't be saved"