internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-06 13:22:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid default serialization of classes in dump_attrs

Browse Source 
For playbook base objects, when dumping attributes via dump_attrs() an
attribute like loop_control is a class. Using the default serialization
for these is slow and consumes a lot of memory. Since LoopControl is also
based on the Base class, we can use serialize() instead and save a lot of
resources.

This also adds a from_attrs() complimentary method to nicely turn the
dumped attrs back into proper field attributes.

Fixes #23579
This commit is contained in:
James Cammarata
2017-05-11 14:57:30 -05:00
parent 409fe1a3c3
commit 78478e80ea
2 changed files with 21 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/ansible/plugins/strategy/__init__.py
View File

@@ -332,8 +332,7 @@ class StrategyBase:
found_task = iterator.get_original_task(original_host, task_result._task)
original_task = found_task.copy(exclude_parent=True, exclude_tasks=True)
original_task._parent = found_task._parent
for (attr, val) in iteritems(task_result._task_fields):
setattr(original_task, attr, val)
original_task.from_attrs(task_result._task_fields)
task_result._host = original_host
task_result._task = original_task