Enable more pylint rules and fix reported issues. (#30539)

* Enable pylint unreachable test.
* Enable pylint suppressed-message test.
* Enable pylint redundant-unittest-assert test.
* Enable pylint bad-open-mode test.
* Enable pylint signature-differs test.
* Enable pylint unnecessary-pass test.
* Enable pylint unnecessary-lambda test.
* Enable pylint raising-bad-type test.
* Enable pylint logging-not-lazy test.
* Enable pylint logging-format-interpolation test.
* Enable pylint useless-else-on-loop test.

test/sanity/pylint/disable.txt

@@ -8,7 +8,6 @@ attribute-defined-outside-init
 bad-continuation
 bad-indentation
 bad-mcs-classmethod-argument
-bad-open-mode
 bad-whitespace
 bare-except
 blacklisted-name
@@ -34,8 +33,6 @@ invalid-encoded-data
 invalid-name
 line-too-long
 locally-disabled
-logging-format-interpolation
-logging-not-lazy
 method-hidden
 misplaced-comparison-constant
 missing-docstring
@@ -52,18 +49,14 @@ old-style-class
 pointless-statement
 pointless-string-statement
 protected-access
-raising-bad-type
 redefined-builtin
 redefined-outer-name
 redefined-variable-type
-redundant-unittest-assert
 reimported
 relative-import
-signature-differs
 simplifiable-if-statement
 super-init-not-called
 superfluous-parens
-suppressed-message
 too-few-public-methods
 too-many-ancestors
 too-many-arguments
@@ -80,10 +73,7 @@ too-many-statements
 undefined-loop-variable
 ungrouped-imports
 unidiomatic-typecheck
-unnecessary-lambda
-unnecessary-pass
 unneeded-not
-unreachable
 unsubscriptable-object
 unsupported-membership-test
 unused-argument
@@ -91,7 +81,6 @@ unused-import
 unused-variable
 unused-wildcard-import
 used-before-assignment
-useless-else-on-loop
 wildcard-import
 wrong-import-order
 wrong-import-position

test/units/module_utils/json_utils/test_filter_non_json_lines.py

@@ -87,6 +87,6 @@ class TestAnsibleModuleExitJson(unittest.TestCase):
         for i in self.unparsable_cases:
             self.assertRaises(
                 ValueError,
-                lambda data: _filter_non_json_lines(data),
+                _filter_non_json_lines,
                 data=i
             )

test/units/modules/network/radware/test_vdirect_file.py

@@ -106,7 +106,7 @@ class TestManager(unittest.TestCase):
                 params = NONE_PARAMS.copy()
                 del params['vdirect_ip']
                 vdirect_file.VdirectFile(params)
-                self.assertFalse("KeyError was not thrown for missing parameter")
+                self.fail("KeyError was not thrown for missing parameter")
             except KeyError:
                 assert True
 
@@ -134,7 +134,7 @@ class TestManager(unittest.TestCase):
             file = vdirect_file.VdirectFile(NONE_PARAMS)
             try:
                 file.upload("missing_file.vm")
-                self.assertFalse("IOException was not thrown for missing file")
+                self.fail("IOException was not thrown for missing file")
             except IOError:
                 assert True
 

test/units/parsing/vault/test_vault_editor.py

@@ -467,7 +467,6 @@ class TestVaultEditor(unittest.TestCase):
         try:
             ve.decrypt_file(v11_file.name)
         except errors.AnsibleError:
-            raise
             error_hit = True
 
         # verify decrypted content
@@ -493,7 +492,6 @@ class TestVaultEditor(unittest.TestCase):
         try:
             ve.rekey_file(v10_file.name, vault.match_encrypt_secret(new_secrets)[1])
         except errors.AnsibleError:
-            raise
             error_hit = True
 
         # verify decrypted content
@@ -510,7 +508,6 @@ class TestVaultEditor(unittest.TestCase):
         try:
             dec_data = vl.decrypt(fdata)
         except errors.AnsibleError:
-            raise
             error_hit = True
 
         os.unlink(v10_file.name)